Skip to content

Modernize rttest and tlsf_cpp for C++20 part 2 #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahcorde merged 4 commits into from
Jun 19, 2026
+9 −8
Merged

Modernize rttest and tlsf_cpp for C++20 part 2 #148

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
068b800
fixed page-fault accumulator and removed non-deducible converting con…
ahcorde Jun 16, 2026
8211ffd
Modernize rttest and tlsf_cpp for C++20
ahcorde Jun 16, 2026
d2d6d7c
Modernize rttest and tlsf_cpp for C++20 part 2
ahcorde Jun 16, 2026
0ed3cab
Merge branch 'rolling' into ahcorde/rolling/improvements_part3
ahcorde Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions rttest/include/rttest/utils.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,10 @@
#include <stdint.h>
#include <time.h>

#define NSEC_PER_SEC 1000000000
// Typed compile-time constant replacing the former object-like macro.
static constexpr int64_t NSEC_PER_SEC = 1000000000;

static inline bool timespec_gt(
static constexpr bool timespec_gt(
const struct timespec * t1,
const struct timespec * t2)
{
Expand All @@ -33,7 +34,7 @@ static inline bool timespec_gt(
return t1->tv_nsec > t2->tv_nsec;
}

static inline void normalize_timespec(struct timespec * t)
static constexpr void normalize_timespec(struct timespec * t)
{
// TODO(jacquelinekay) improve
while (t->tv_nsec >= NSEC_PER_SEC) {
Expand All @@ -42,7 +43,7 @@ static inline void normalize_timespec(struct timespec * t)
}
}

static inline void add_timespecs(
static constexpr void add_timespecs(
const struct timespec * t1,
const struct timespec * t2,
struct timespec * dst)
Expand All @@ -52,7 +53,7 @@ static inline void add_timespecs(
normalize_timespec(dst);
}

static inline bool subtract_timespecs(
static constexpr bool subtract_timespecs(
const struct timespec * t1,
const struct timespec * t2,
struct timespec * dst)
Expand All @@ -68,20 +69,20 @@ static inline bool subtract_timespecs(
return true;
}

static inline uint64_t timespec_to_uint64(const struct timespec * t)
static constexpr uint64_t timespec_to_uint64(const struct timespec * t)
{
return static_cast<uint64_t>(t->tv_sec) * NSEC_PER_SEC + static_cast<uint64_t>(t->tv_nsec);
}

static inline void uint64_to_timespec(const uint64_t input, struct timespec * t)
static constexpr void uint64_to_timespec(const uint64_t input, struct timespec * t)
{
uint64_t nsecs = input % NSEC_PER_SEC;
uint64_t secs = (input - nsecs) / NSEC_PER_SEC;
t->tv_sec = static_cast<time_t>(secs);
t->tv_nsec = static_cast<long>(nsecs); // NOLINT for C type long
}

static inline void multiply_timespec(
static constexpr void multiply_timespec(
const struct timespec * t, const uint32_t i,
struct timespec * result)
{
Expand Down