refactor: adopt eco library and restructure result handling#19
Merged
Conversation
…into wip/result-and-error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces
ecoas the foundation for result and error handling across the application, replacing the internalResultandErrorutilities. Alongside the library adoption, the application layer was restructured to enforce a clear separation between validation (Input) and execution (UseCase).Error handling
src/Core/Utils/Result.phpandsrc/Core/Utils/Error.phpeco'sResultandErrorclassesInput value objects
RollDiceInputandStartSessionInputas dedicated value objectseco'sensure()pipelineRollDiceUseCaseInputandStartSessionUseCaseInputUse cases
try/catchblocks fromRollDiceUseCaseandStartSessionUseCaseUseCasesuffix (RollDiceOutput,StartSessionOutput)Domain
DiceModifiervalue object withfromString()andapply()try/catchfromRollDiceActionStrHandlerfor string sanitizationConsole
Tests
RollDiceActionTest,DiceModifierTest,RollDiceInputTest,StartSessionInputTest,StartSessionUseCaseTestBreaking changes
ecois now a required dependency — runcomposer installafter pullingRollDiceUseCaseInput,StartSessionUseCaseInputand the internalResult/Errorclasses have been removed