Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions .github/issues.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
[
{
"title": "(refactor): Return types and throwing exceptions",
"body": "Its necessary to update the return types of the use case and its input, as well as to throw exceptions for invalid input. This will improve the robustness and clarity of the code.",
"labels": ["refactor"]
},
{
"title": "(refactor): Command structure",
"body": "Update the command structure to something more clear and abstract, too many information in one single command can be overwhelming and hard to maintain. Consider breaking it down into smaller, more focused commands or methods.",
"labels": ["refactor"]
"title": "(feat): Advantage dices",
"body": "Implement advantage and disadvantage mechanics for dice rolls.\n\nAdvantage: roll two dice of the same type and keep the highest result.\nDisadvantage: roll two dice of the same type and keep the lowest result.\n\nThis is a common mechanic in tabletop RPG systems such as D&D 5e and should integrate naturally with the existing `RollDiceInput` and `RollDiceUseCase` pipeline.",
"labels": ["enhancement"]
}
]
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/vendor/
coverage
.phpunit.result.cache
obsidian
obsidian
.obsidian
6 changes: 1 addition & 5 deletions bin/console
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ require __DIR__ . '/../bootstrap.php';

use Monolog\Handler\StreamHandler;
use Monolog\Logger;
use RPGPlayground\Infrastructure\EntryPoints\Console\Dice\RollDiceCommand;
use RPGPlayground\Infrastructure\EntryPoints\Console\Session\StartSessionCommand;
use RPGPlayground\Infrastructure\Handler\LogHandler;
use RPGPlayground\Core\Handler\LogHandler;
use Symfony\Component\Console\Application;

LogHandler::bind(new Logger('console'));
Expand All @@ -18,8 +16,6 @@ LogHandler::stream(new StreamHandler(__DIR__ . '/../logs/console.log'));
$application = new Application();

$application->addCommands([
new RollDiceCommand(),
new StartSessionCommand(),
]);

$application->run();
6 changes: 4 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"name": "valb/php.rpg-playground",
"autoload": {
"psr-4": {
"RPGPlayground\\": "src/"
"RPGPlayground\\": "src/",
"Tests\\": "tests/"
}
},
"authors": [
Expand All @@ -23,6 +24,7 @@
"symfony/console": "^8.0",
"symfony/var-dumper": "^8.0",
"monolog/monolog": "^3.10",
"azjezz/psl": "^4.3"
"azjezz/psl": "^4.3",
"valb/eco": "^4.0"
}
}
123 changes: 88 additions & 35 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

File renamed without changes.
5 changes: 3 additions & 2 deletions mago.toml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ check-missing-type-hints = true
register-super-globals = true
excludes = ["obsidian"]
ignore = [
{ code = "missing-override-attribute" , in = "tests" },
{ code = "unhandled-thrown-type", in = "tests" }
{ code = "missing-override-attribute" , in = "tests" },
{ code = "unhandled-thrown-type", in = "tests" },
{ code = "possibly-undefined-array-index", in = "tests" }
]
1 change: 0 additions & 1 deletion obsidian/.obsidian/app.json

This file was deleted.

1 change: 0 additions & 1 deletion obsidian/.obsidian/appearance.json

This file was deleted.

3 changes: 0 additions & 3 deletions obsidian/.obsidian/community-plugins.json

This file was deleted.

Loading
Loading