feat!: upgrade unplugin-vue to v7 and add release tooling#7
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75c3dac158
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
| "dependencies": { | ||
| "unplugin-vue": "^6.2.0" | ||
| "unplugin-vue": "^7.1.1" |
There was a problem hiding this comment.
Upgrading to unplugin-vue@^7.1.1 raises the effective runtime requirement to Node 20.19+, but this package still publishes without an engines.node constraint, so consumers on Node 18 (or older Node 20 minors) can install successfully and only hit failures later when the plugin executes. Declaring the new engine floor in package.json would make the breaking change explicit at install time and prevent unsupported environments from silently taking this release.
Useful? React with 👍 / 👎.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades unplugin-vue to v7 and refreshes the development tooling, including a migration to Biome v2. The changes largely consist of configuration updates and dependency bumps, which align with the PR's goals. However, I've identified two critical issues in the playground components where variables in the <script setup> block have been renamed (likely by a linter), but their references in the <template> have not been updated. This will lead to runtime errors and break the playground examples.
| import { ref } from 'vue'; | ||
| const button = ref('Hello World!'); | ||
|
|
||
| const _button = ref('Hello World!'); |
There was a problem hiding this comment.
The variable _button is defined here, but the template refers to button. This will cause a reference error at runtime. It seems a linter auto-fix might have incorrectly renamed the variable, considering it unused. In Vue's <script setup>, top-level bindings are automatically exposed to the template and are thus considered used.
const button = ref('Hello World!');
| import { ref } from 'vue'; | ||
| const card = ref('Hello World!'); | ||
|
|
||
| const _card = ref('Hello World!'); |
There was a problem hiding this comment.
The variable _card is defined here, but the template refers to card. This will cause a reference error at runtime. Similar to the other component, this seems to be an incorrect auto-fix from a linter. In Vue's <script setup>, top-level bindings are exposed to the template.
const card = ref('Hello World!');
1 participant
Summary
unplugin-vueto v7, refresh related tooling deps, and migrate the repo to Biome v2 configbumppproject configuration, including aformatscript and release commit formatRelease v%sunplugin-vuev7 drops Node 18 support, so this plugin now effectively requires Node >= 20.19Testing
pnpm formatpnpm buildpnpm exec playwright test 'test/rslib/index.test.ts'pnpm exec playwright test 'test/rsbuild/rsbuild.test.ts'pnpm exec playwright test 'test/rsbuild/rsbuild.v1.test.ts'