Skip to content

feat!: upgrade unplugin-vue to v7 and add release tooling #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fi3ework merged 1 commit into from
Mar 17, 2026
Merged

feat!: upgrade unplugin-vue to v7 and add release tooling #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/renovate.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": ["config:base", "schedule:monthly", "group:allNonMajor"],
"extends": [
"config:recommended",
"schedule:monthly",
"group:allNonMajor"
],
"rangeStrategy": "bump",
"packageRules": [{ "depTypeList": ["peerDependencies"], "enabled": false }]
}
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: Release

on:
# Run `npm run bump` to bump the version and create a git tag.
# Trigger on version tags or run manually.
push:
tags:
- "v*"
Expand Down
8 changes: 3 additions & 5 deletions biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,14 @@
{
"$schema": "https://biomejs.dev/schemas/1.8.3/schema.json",
"organizeImports": {
"enabled": true
},
"$schema": "https://biomejs.dev/schemas/2.4.7/schema.json",
"assist": { "actions": { "source": { "organizeImports": "on" } } },
"vcs": {
"enabled": true,
"defaultBranch": "main",
"clientKind": "git",
"useIgnoreFile": true
},
"files": {
"ignore": ["./test/rslib/index.test.ts-snapshots/**"]
"includes": ["**", "!test/rslib/index.test.ts-snapshots"]
},
"formatter": {
"indentStyle": "space"
Expand Down
7 changes: 7 additions & 0 deletions bump.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import { defineConfig } from 'bumpp';

export default defineConfig({
commit: 'Release v%s',
tag: false,
push: false,
});
16 changes: 10 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,26 +14,30 @@
"main": "./dist/index.js",
"module": "./dist/index.mjs",
"types": "./dist/index.d.ts",
"files": ["dist"],
"files": [
"dist"
],
"scripts": {
"build": "rslib build",
"dev": "rslib build --watch",
"format": "biome check . --write --unsafe",
"lint": "biome check .",
"lint:write": "biome check . --write",
"prepare": "simple-git-hooks && npm run build",
"test": "playwright test",
"bump": "npx bumpp"
"bump": "bumpp"
},
"simple-git-hooks": {
"pre-commit": "npm run lint:write"
"pre-commit": "npm run format"
},
"devDependencies": {
"@biomejs/biome": "^1.9.4",
"@biomejs/biome": "^2.4.7",
"@playwright/test": "^1.58.2",
"@rsbuild/core": "2.0.0-beta.8",
"@rsbuild/core-v1": "npm:@rsbuild/core@^1.7.3",
"@rslib/core": "^0.20.0",
"@types/node": "^22.19.15",
"@types/node": "^25.5.0",
"bumpp": "^11.0.1",
"playwright": "^1.58.2",
"simple-git-hooks": "^2.13.1",
"typescript": "^5.9.3",
Expand All @@ -53,6 +57,6 @@
"registry": "https://registry.npmjs.org/"
},
"dependencies": {
"unplugin-vue": "^6.2.0"
"unplugin-vue": "^7.1.1"

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add Node engine floor for unplugin-vue v7 upgrade

Upgrading to unplugin-vue@^7.1.1 raises the effective runtime requirement to Node 20.19+, but this package still publishes without an engines.node constraint, so consumers on Node 18 (or older Node 20 minors) can install successfully and only hit failures later when the plugin executes. Declaring the new engine floor in package.json would make the breaking change explicit at install time and prevent unsupported environments from silently taking this release.

Useful? React with 👍 / 👎.

}
}
2 changes: 1 addition & 1 deletion playground/rsbuild/src/env.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ declare module '*.vue' {
import type { DefineComponent } from 'vue';

// biome-ignore lint/complexity/noBannedTypes: reason
// biome-ignore lint/suspicious/noExplicitAny: <explanation>
// biome-ignore lint/suspicious/noExplicitAny: Vue component typings use `any` here.
const component: DefineComponent<{}, {}, any>;
export default component;
}
3 changes: 2 additions & 1 deletion playground/rslib/src/Button.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
<script setup>
import './style.css';
import { ref } from 'vue';
const button = ref('Hello World!');

const _button = ref('Hello World!');

@gemini-code-assist gemini-code-assist Bot Mar 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The variable _button is defined here, but the template refers to button. This will cause a reference error at runtime. It seems a linter auto-fix might have incorrectly renamed the variable, considering it unused. In Vue's <script setup>, top-level bindings are automatically exposed to the template and are thus considered used.

const button = ref('Hello World!');

</script>

<template>
Expand Down
3 changes: 2 additions & 1 deletion playground/rslib/src/Card.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<script setup>
import { ref } from 'vue';
const card = ref('Hello World!');

const _card = ref('Hello World!');

@gemini-code-assist gemini-code-assist Bot Mar 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The variable _card is defined here, but the template refers to card. This will cause a reference error at runtime. Similar to the other component, this seems to be an incorrect auto-fix from a linter. In Vue's <script setup>, top-level bindings are exposed to the template.

const card = ref('Hello World!');

</script>

<template>
Expand Down
Loading
Loading