Skip to content

chore: build before stage publish#100

Open
chenjiahan wants to merge 1 commit into
mainfrom
codex/build-before-stage-publish
Open

chore: build before stage publish#100
chenjiahan wants to merge 1 commit into
mainfrom
codex/build-before-stage-publish

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Summary

  • Build packages in the release workflow before pnpm stage publish.
  • Remove duplicate build commands from scripts.prepare where present.

Validation

  • Verified staged publish workflows have a preceding pnpm build.
  • Ran git diff --check.

@chenjiahan chenjiahan marked this pull request as ready for review May 29, 2026 12:59
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 14d49bc8c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
"build-storybook": "storybook build",
"storybook": "storybook dev -p 6006",
"prepare": "rslib && simple-git-hooks",
"prepare": "simple-git-hooks",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep building during package preparation

With rslib removed from prepare, a clean checkout that is packed or published outside this one GitHub workflow (for example pnpm pack, a manual pnpm publish, or a consumer installing this repo as a git dependency) no longer generates dist, while this package only publishes files: ["dist"] and all exports point into ./dist/.... The new workflow build covers pnpm stage publish only; the package-manager lifecycle still runs prepare before packing/publishing per the npm lifecycle docs, so these other supported paths now produce/install a package with missing entry points.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant