chore: build before stage publish#100
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14d49bc8c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "build-storybook": "storybook build", | ||
| "storybook": "storybook dev -p 6006", | ||
| "prepare": "rslib && simple-git-hooks", | ||
| "prepare": "simple-git-hooks", |
There was a problem hiding this comment.
Keep building during package preparation
With rslib removed from prepare, a clean checkout that is packed or published outside this one GitHub workflow (for example pnpm pack, a manual pnpm publish, or a consumer installing this repo as a git dependency) no longer generates dist, while this package only publishes files: ["dist"] and all exports point into ./dist/.... The new workflow build covers pnpm stage publish only; the package-manager lifecycle still runs prepare before packing/publishing per the npm lifecycle docs, so these other supported paths now produce/install a package with missing entry points.
Useful? React with 👍 / 👎.
Summary
pnpm stage publish.scripts.preparewhere present.Validation
pnpm build.git diff --check.