Skip to content

chore: build before stage publish #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chenjiahan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: build before stage publish #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,8 @@ jobs:
- name: Install Dependencies
run: pnpm i

- name: Build Packages
run: pnpm build

- name: Publish
run: pnpm stage publish --no-git-checks
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"dev": "pnpm run storybook",
"build-storybook": "storybook build",
"storybook": "storybook dev -p 6006",
"prepare": "rslib && simple-git-hooks",
"prepare": "simple-git-hooks",
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep building during package preparation

With rslib removed from prepare, a clean checkout that is packed or published outside this one GitHub workflow (for example pnpm pack, a manual pnpm publish, or a consumer installing this repo as a git dependency) no longer generates dist, while this package only publishes files: ["dist"] and all exports point into ./dist/.... The new workflow build covers pnpm stage publish only; the package-manager lifecycle still runs prepare before packing/publishing per the npm lifecycle docs, so these other supported paths now produce/install a package with missing entry points.

Useful? React with 👍 / 👎.

"build": "rslib",
"build:watch": "rslib -w",
"test": "rstest",
Expand Down
Loading