Replace multi_json and oj gems with standard Ruby json gem#64
Open
larouxn wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Note that we either need to merge this or alternatively a smaller PR that just drops PR to drop no-longer-supported serializers: |
ed35caf to
f75925e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proposing we remove the
multi_jsonandojgems in favour of the standard Rubyjsongem as it's now as fast or faster in the majority of cases compared tooj. Additionally allows us to simplify code quite a bit too. ✨Related efforts
jsongem for 4.0.0-beta.5 opensearch-project/opensearch-ruby#290ojand its initializer and addjsonto the Gemfile mastodon/mastodon#37752Implementation
Generally it's a pretty simple swap and cleanup. That said, the one quirk comes from the fact that
ojcould apparently handle non-finite doubles such as infinity. As the Standard JSON (RFC 8259) does not support non-finite doubles such asNaN,Infinity, and-Infinityas numeric values, theJSONgem can raise aJSON::GeneratorErrorwhen passed such values for generation. Thus, I'm proposing we use string representation + type for such values. Open to opinions.Probably worth reviewing with whitespace disabled re: the indentation changes in
spec/api_spec.rb. Link below.https://github.com/ruby-rdf/json-ld/pull/64/changes?w=1
Notes
Apparently v1.20.0 of
multi_jsondropped support forok_json. 🤷♂️ 🔥