Drop support for ok_json and json_pure as multi_json has done#66
Open
larouxn wants to merge 1 commit into
Open
Drop support for ok_json and json_pure as multi_json has done#66larouxn wants to merge 1 commit into
ok_json and json_pure as multi_json has done#66larouxn wants to merge 1 commit into
Conversation
larouxn
changed the title
ok_json and json_pure as multi_json has done
jcoyne
approved these changes
Jun 22, 2026
larouxn
force-pushed
the
drop_ok_json_and_json_pure_support
branch
from
b7d6255 to
48b43c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to bring this gem up-to-date and get CI passing I came across the fact that modern
multi_jsonhas removed support forok_json(dropped) andjson_pure(aliased tojson_gem). Thus, short of us removingmulti_json, which I'm also proposing in #64, we need to drop those two adapters as a preliminary fix.ok_json| https://github.com/sferik/multi_json/blob/9ae5a429e519fb70440833d8b8968a2123da9098/CHANGELOG.md#1200json_pure| https://github.com/sferik/multi_json/blob/9ae5a429e519fb70440833d8b8968a2123da9098/CHANGELOG.md#1160