no-complex-attribute-binding: take converters into consideration#126
Open
43081j wants to merge 1 commit intorunem:masterfrom
Open
no-complex-attribute-binding: take converters into consideration#12643081j wants to merge 1 commit intorunem:masterfrom
43081j wants to merge 1 commit intorunem:masterfrom
Conversation
43081j
commented
Jul 25, 2020
packages/lit-analyzer/src/rules/util/type/is-assignable-in-attribute-binding.ts
Show resolved
Hide resolved
Owner
|
I see that you needed to manually run |
Contributor
Author
|
Good question. I just commit via git through a terminal so I would have expected husky to be fine. I'll have a look tomorrow and see if there's any obvious reason it isn't |
Contributor
Author
|
@runem is this still a valid PR? could we try get it merged if its still needed. i can catch it up, presumably its pretty far behind by now |
43081j
force-pushed
the
complex-converter
branch
from
f0c6be4 to
956006b
Compare
43081j
force-pushed
the
complex-converter
branch
from
91ebc41 to
26dca25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #123
like i mention in the issue, i might add on to this to make
no-incompatible-type-bindingalso take them into account.let me know if you think thats sensible