Skip to content

Add Octave input request#83

Merged
rgbkrk merged 2 commits into
runtimed:mainfrom
SylvainCorlay:input-name
Apr 4, 2026
Merged

Add Octave input request#83
rgbkrk merged 2 commits into
runtimed:mainfrom
SylvainCorlay:input-name

Conversation

@SylvainCorlay
Copy link
Copy Markdown
Collaborator

@SylvainCorlay SylvainCorlay commented Apr 2, 2026

test_input_42 is not a valid mock input for GNU Octave, which causes the test failure.

input

The input string should be a valid Octave expression, like "hello" or 1, but just typing hello will trigger an error if the hello variable is not defined.

@SylvainCorlay
Copy link
Copy Markdown
Collaborator Author

SylvainCorlay commented Apr 2, 2026

A fix would be to change

let mock_input = "test_input_42";

into

let mock_input = "\"test_input_42\"";

but maybe a cleaner fix would be to use a language-dependent input string.

@JohanMabille JohanMabille enabled auto-merge (squash) April 2, 2026 13:06
@JohanMabille JohanMabille disabled auto-merge April 2, 2026 13:06
@SylvainCorlay
Copy link
Copy Markdown
Collaborator Author

It does not seem that we can merge over the Conformance Matrix check failing to post the comment on the PR:

Screenshot 2026-04-02 at 15 11 21

It seems that the previous PR by Johan had the same test failing and you merged. It seems to be a permission issue with a GitHub token.

@rgbkrk rgbkrk closed this Apr 4, 2026
@rgbkrk rgbkrk reopened this Apr 4, 2026
@rgbkrk rgbkrk merged commit 9c8a6ea into runtimed:main Apr 4, 2026
95 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants