Skip to content

Add Octave input request #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgbkrk merged 2 commits into from
Apr 4, 2026
Merged

Add Octave input request #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c69d266
Add Octave input request
SylvainCorlay Apr 2, 2026
0876f03
Update mock input
SylvainCorlay Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion snippets/snippets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@
"incomplete_code": "if true",
"complete_code": "x = 1;",
"syntax_error": "1 +",
"input_prompt": "% Octave stdin doesn't support Jupyter input protocol",
"input_prompt": "name = input(\"Enter: \")",
"sleep_code": "pause(2)",
"completion_var": "test_variable_for_completion",
"completion_setup": "test_variable_for_completion = 42;",
Expand Down
6 changes: 5 additions & 1 deletion src/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,7 +701,11 @@ fn test_stdin_input_request(
return TestResult::Unsupported;
}

let mock_input = "test_input_42";
// Mock input includes quotes to ensure validity in languages like
// GNU Octave, where unquoted undefined variables (e.g. `test_input_42`)
// would cause a kernel error.
// TODO: Make mock input language-dependent for robustness.
let mock_input = "\"test_input_42\"";

match kernel.execute_with_stdin(&code, mock_input).await {
Ok((reply, _iopub, received_input_request)) => {
Expand Down
Loading