Merged
Conversation
Improving wording
Because it's always empty.
Because it's always empty.
It's unused.
…recovery Something seems to have gotten out of sync during the creation of rust-lang#81177, where both the argument and comment were introduced.
Co-authored-by: David Wood <agile.lion3441@fuligin.ink>
…d, r=cjgillot Make must_not_suspend lint see through references when drop tracking is enabled See rust-lang#97333. With drop tracking enabled, sometimes values that were previously linted are now considered dropped and not linted. This change makes must_not_suspend traverse through references to still catch these values. Unfortunately, this leads to duplicate warnings in some cases (e.g. [dedup.rs](https://cs.github.com/rust-lang/rust/blob/9a74608543d499bcc7dd505e195e8bfab9447315/src/test/ui/lint/must_not_suspend/dedup.rs#L4)), so we only use the new behavior when drop tracking is enabled. cc ``@guswynn``
avoid assertion failures in try_to_scalar_int Given that this is called `try_to_scalar_int`, we probably shouldn't `assert_int` here. Similarly `try_to_bits` also doesn't `assert!` that the size is correct. Also add some `track_caller` for debugging, while we are at it. r? ```@oli-obk```
…ents, r=tmandry Improving Fuchsia rustc support documentation * Adjusting `package/meta/package` to fit current schema * Adding repository server step * Adjusting step to give default repository * Adding "recreate" step for easier step following
…adowing-another-type, r=estebank Point at a type parameter shadowing another type This patch fixes a part of rust-lang#97459.
…nd_transcribe, r=davidtwco Migrations for rustc_expand transcribe.rs This PR includes some migrations to the new diagnostics API for the `rustc_expand` module. r? ```@davidtwco```
…spastorino Attribute cleanups r? `@ghost`
…docs, r=davidtwco Fix documentation of rustc_parse::parser::Parser::parse_stmt_without_recovery Something seems to have gotten out of sync during the creation of rust-lang#81177, where both the argument and comment were introduced.
…e-diag, r=davidtwco Migrate lint reports in typeck::check_unused to LintDiagnostic In this PR, I migrate two lint reports in `typeck::check_unused` by `LintDiagnostic`, all of which is about extern crates. ```@rustbot``` label +A-translation r? rust-lang/diagnostics
…sleywiser `ty::Error` does not match other types for region constraints Fixes rust-lang#100684
Member
Author
|
@bors r+ rollup=never p=10 |
Collaborator
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Aug 18, 2022
Collaborator
|
Finished benchmarking commit (f241c0c): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesThis benchmark run did not return any relevant results for this metric. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ty::Errordoes not match other types for region constraints #100688 (ty::Errordoes not match other types for region constraints)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup