Migrate rustc_ty_utils to SessionDiagnostic#100735
Merged
bors merged 1 commit intorust-lang:masterfrom Aug 27, 2022
Merged
Conversation
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @fee1-dead (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
added
A-translation
Collaborator
|
|
rust-highfive
added
the
S-waiting-on-review
Member
|
r? @davidtwco |
estebank
approved these changes
Aug 19, 2022
davidtwco
reviewed
Aug 19, 2022
davidtwco
approved these changes
Aug 19, 2022
Member
|
@bors r+ |
Collaborator
|
📌 Commit c817dc30cfd464a8a1e3121d2dcd06a61be1461f has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
Member
|
@bors r- |
bors
added
S-waiting-on-author
petermused
force-pushed
the
ty-utils-translation
branch
from
c817dc3 to
8028ec1
Compare
Contributor
Author
|
I have moved the |
Member
|
@bors r+ |
Collaborator
|
📌 Commit 8028ec186e8dcb583c6e9740e26863378da5d0dd has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
This comment was marked as resolved.
This comment was marked as resolved.
bors
added
S-waiting-on-author
petermused
force-pushed
the
ty-utils-translation
branch
from
8028ec1 to
2957815
Compare
Collaborator
|
📌 Commit 7affbb0f163f24033161ae38c8038cf667c20282 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
This comment was marked as resolved.
This comment was marked as resolved.
bors
added
S-waiting-on-author
Member
|
Re-request a review once you've resolved the conflicts so that I can re-approve. |
petermused
force-pushed
the
ty-utils-translation
branch
from
7affbb0 to
7754ab1
Compare
Contributor
Author
|
r? @davidtwco |
Member
|
@bors r+ |
Collaborator
|
📌 Commit 7754ab1441b43663ddbf3fa576ad75d0c744d475 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
This comment was marked as resolved.
This comment was marked as resolved.
bors
added
S-waiting-on-author
petermused
force-pushed
the
ty-utils-translation
branch
from
7754ab1 to
01c1616
Compare
Contributor
Author
|
Fixed some more merge conficts r? @davidtwco |
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Contributor
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 27, 2022
…mpiler-errors Rollup of 9 pull requests Successful merges: - rust-lang#100724 (Migrate ast lowering to session diagnostic) - rust-lang#100735 (Migrate `rustc_ty_utils` to `SessionDiagnostic`) - rust-lang#100738 (Diagnostics migr const eval) - rust-lang#100744 (Migrate rustc_mir_dataflow to diagnostic structs) - rust-lang#100776 (Migrate `rustc_lint` errors to `SessionDiagnostic`) - rust-lang#100817 (sugg: suggest the usage of boolean value when there is a typo in the keyword) - rust-lang#100836 (Migrate `rustc_attr` crate diagnostics) - rust-lang#100890 (Migrate rustc_driver to SessionDiagnostic) - rust-lang#100900 (on `region_errors.rs`) Failed merges: - rust-lang#100831 (Migrate `symbol_mangling` module to new diagnostics structs) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have migrated the
rustc_ty_utilscrate to useSessionDiagnostic, motivated by the recent blog post about the diagnostic translation effort.This is my first PR to the Rust repository, so if I have missed anything, or anything needs to be changed, please let me know! 😄
@rustbot label +A-translation