Migrate rustc_driver to SessionDiagnostic#100890
Merged
bors merged 6 commits intorust-lang:masterfrom Aug 27, 2022
adriantombu:migrate_diagnostic_rustc_driver
Merged
Migrate rustc_driver to SessionDiagnostic#100890bors merged 6 commits intorust-lang:masterfrom adriantombu:migrate_diagnostic_rustc_driver
bors merged 6 commits intorust-lang:masterfrom
adriantombu:migrate_diagnostic_rustc_driver
Conversation
rustbot
added
A-translation
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wesleywiser (or someone else) soon. Please see the contribution instructions for more information. |
Collaborator
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
davidtwco
requested changes
Aug 23, 2022
Member
davidtwco
left a comment
davidtwco
left a comment
There was a problem hiding this comment.
This is a great start, I've left some pointers.
davidtwco
changed the title
Member
|
r? @davidtwco |
Member
|
We actually have a no merge policy, would you be able to rebase instead? |
Contributor
Author
|
Absolutely, sorry about that! |
This comment has been minimized.
This comment has been minimized.
davidtwco
reviewed
Aug 24, 2022
Member
davidtwco
left a comment
davidtwco
left a comment
There was a problem hiding this comment.
I think this is almost ready, I've left another couple comments, thanks for your work on this
davidtwco
added
S-waiting-on-author
Member
|
Use |
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
davidtwco
reviewed
Aug 24, 2022
This comment has been minimized.
This comment has been minimized.
davidtwco
reviewed
Aug 25, 2022
Member
davidtwco
left a comment
davidtwco
left a comment
There was a problem hiding this comment.
This is great, one or two comments then we can land this.
davidtwco
approved these changes
Aug 26, 2022
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Contributor
Author
|
Thanks for your explanations and patience @davidtwco! |
Contributor
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 27, 2022
…mpiler-errors Rollup of 9 pull requests Successful merges: - rust-lang#100724 (Migrate ast lowering to session diagnostic) - rust-lang#100735 (Migrate `rustc_ty_utils` to `SessionDiagnostic`) - rust-lang#100738 (Diagnostics migr const eval) - rust-lang#100744 (Migrate rustc_mir_dataflow to diagnostic structs) - rust-lang#100776 (Migrate `rustc_lint` errors to `SessionDiagnostic`) - rust-lang#100817 (sugg: suggest the usage of boolean value when there is a typo in the keyword) - rust-lang#100836 (Migrate `rustc_attr` crate diagnostics) - rust-lang#100890 (Migrate rustc_driver to SessionDiagnostic) - rust-lang#100900 (on `region_errors.rs`) Failed merges: - rust-lang#100831 (Migrate `symbol_mangling` module to new diagnostics structs) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First timer noob here 👋🏽 I'm having a problem understanding how I can retrieve the span, and how to properly construct the error structs to avoid the current compilation errors.
Any help pointing me in the right direction would be much appreciated 🙌🏽