Merged
Conversation
Since 6a5f8b1, this class is no longer styled.
…ntheses, r=lcnr Suggest parentheses for possible range method calling Fixes rust-lang#102396
only allow `ConstEquate` with `feature(gce)`
…-outlives, r=lcnr Do not register placeholder `RegionOutlives` obligations when `considering_regions` is false **NOTE:** I'm kinda just putting this up for discussion. I'm not certain this is correct...? This was introduced in [`608625d`](rust-lang@608625d#diff-6e54b18681342ec725d75591dbf384ad08cd73df29db00485fe51b4e90f76ff7R361). Interestingly, we only check `data.has_placeholders()` for `RegionOutlives`, and not for `TypeOutlives`... why? For the record, that different treatment between `RegionOutlives` and `TypeOutlives` is why the fix "The compiling succeeds when all `'a : 'b` are replaced with `&'a () : 'b`" in rust-lang#100689 _"works"_, but it seems like an implementation detail considering this. Also, why do we care about placeholder regions being registered if `considering_regions` is false? It doesn't seem to affect any UI tests, for example. r? `@lcnr` Fixes rust-lang#102899 Fixes rust-lang#100689
… r=GuillaumeGomez rustdoc: remove unused HTML class `sidebar-title` Since 6a5f8b1, this class is no longer styled.
rustbot
added
A-translation
Member
Author
|
@bors r+ rollup=never p=4 |
Collaborator
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: a9d1cafa87 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Oct 17, 2022
Merged
Collaborator
|
Finished benchmarking commit (9c2797d): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ConstEquatewithfeature(gce)#102466 (only allowConstEquatewithfeature(gce))RegionOutlivesobligations whenconsidering_regionsis false #102945 (Do not register placeholderRegionOutlivesobligations whenconsidering_regionsis false)sidebar-title#103091 (rustdoc: remove unused HTML classsidebar-title)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup