Recover from common if let syntax mistakes/typos

[chenyukang]

Fixes #103587

[rustbot]

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

[rustbot]

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

[jackh726]

LGTM with subdiagnostic added

[davidtwco]

@bors r=jackh276,davidtwco

[bors]

📌 Commit 9e7d228 has been approved by jackh276,davidtwco

It is now in the queue for this repository.

[chenyukang]

@bors r-

#104176 (comment)

@Manishearth How to run this single test case in local?
Seems this command not working:

x test ./src/tools/clippy/tests/ui/crashes/ice-6250.rs --bless

[Manishearth]

That ought to work, perhaps ask on Zulip? I wouldn't know without seeing more of the error.

[davidtwco]

@Manishearth How to run this single test case in local? Seems this command not working:

x test ./src/tools/clippy/tests/ui/crashes/ice-6250.rs --bless

Wouldn't it be more like x test ./src/tools/clippy/ --test-args ice-6250 --bless?

[chenyukang]

@Manishearth How to run this single test case in local? Seems this command not working:

x test ./src/tools/clippy/tests/ui/crashes/ice-6250.rs --bless

Wouldn't it be more like x test ./src/tools/clippy/ --test-args ice-6250 --bless?

No, not working...

cat@LAPTOP-V6U0QKD4:~/code/rust$  x test ./src/tools/clippy/ --test-args ice-6250 --bless
Building rustbuild
    Finished dev [unoptimized] target(s) in 0.04s
Building stage0 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized + debuginfo] target(s) in 0.21s
Copying stage0 std from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage0 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized + debuginfo] target(s) in 0.20s
Copying stage0 rustc from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Assembling stage1 compiler (x86_64-unknown-linux-gnu)
Building stage1 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized + debuginfo] target(s) in 0.14s
Copying stage1 std from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage1 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized + debuginfo] target(s) in 0.19s
Copying stage1 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage1 tool clippy-driver (x86_64-unknown-linux-gnu)
    Finished release [optimized + debuginfo] target(s) in 0.15s
Building rustdoc for stage1 (x86_64-unknown-linux-gnu)
    Finished release [optimized + debuginfo] target(s) in 0.15s
    Finished release [optimized + debuginfo] target(s) in 0.18s
     Running unittests src/driver.rs (build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/clippy_driver-613db7c0b8c82598)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s

     Running tests/check-fmt.rs (build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/check_fmt-7dc715d9b3ea3888)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s

     Running tests/compile-test.rs (build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/compile_test-a1006319e4c0efbe)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 3 filtered out; finished in 0.00s

     Running tests/dogfood.rs (build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/dogfood-4d21110a169a32d8)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s

     Running tests/integration.rs (build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/integration-0664f500aaf92777)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/lint_message_convention.rs (build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/lint_message_convention-c7b02f26e4d0bb14)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s

     Running tests/missing-test-files.rs (build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/missing_test_files-cfe393cf71d33d5d)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s

     Running tests/versioncheck.rs (build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/versioncheck-6c900a9e1e2297ff)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 2 filtered out; finished in 0.00s

     Running tests/workspace.rs (build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/workspace-b27e5604761ba5c8)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s

Build completed successfully in 0:00:02

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

[chenyukang]

Got it by this way:

x.py test --help --verbose | grep clippy

Then:

./x.py test src/tools/clippy --bless

[jyn514]

Clippy is a special snowflake and uses TESTNAME to tell it how to run individual tests instead of an argument to compiletest. I need to integrate it with x.py at some point. For now you can use TESTNAME=ice-6250 x test src/tools/clippy --bless.

I think this would also be fixed by #103266.

[chenyukang]

@rustbot ready

[davidtwco]

@bors r=jackh276,davidtwco

[bors]

📌 Commit 91b4e7c has been approved by jackh276,davidtwco

It is now in the queue for this repository.

[bors]

⌛ Testing commit 91b4e7c with merge 11fa085...

[bors]

☀️ Test successful - checks-actions
Approved by: jackh276,davidtwco
Pushing 11fa085 to master...

[rust-timer]

Finished benchmarking commit (11fa085): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[1.4%, 2.8%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.1%	[2.8%, 3.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0