Make `Hash`, `Hasher` and `BuildHasher` `#[const_trait]` and make `Sip` const `Hasher` by onestacked · Pull Request #104060 · rust-lang/rust

onestacked · 2022-11-06T16:46:51Z

This PR enables using Hashes in const context.

rustbot · 2022-11-06T16:46:59Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

onestacked · 2022-11-06T16:56:33Z

@rustbot label +T-libs-api -T-libs

onestacked · 2022-11-06T23:42:54Z

@rustbot label +const-hack

library/core/src/hash/sip.rs

fee1-dead

Left some nits. Also, I would like to see some tests to ensure that it works (maybe not as an ui test, but under library/core/tests, next to the hash tests)

library/core/src/hash/mod.rs

library/core/src/hash/sip.rs

library/std/src/lib.rs

onestacked · 2022-11-08T13:21:05Z

Left some nits. Also, I would like to see some tests to ensure that it works (maybe not as an ui test, but under library/core/tests, next to the hash tests)

Should I add a new file or make the current tests const and add some asserts that check for differences between RT and CT?

fee1-dead · 2022-11-08T13:22:17Z

Should I add a new file or make the current tests const and add some asserts that check for differences between RT and CT?

You should add const tests alongside the runtime asserts. Differences between RT and CT are generally not needed to test if you copy all runtime tests and make them const alongside the original tests.

onestacked · 2022-11-08T13:23:11Z

So copy the entire file and make it const there?

fee1-dead · 2022-11-08T13:32:48Z

Just the general tests. for example, in https://github.com/rust-lang/rust/blob/master/library/core/tests/hash/mod.rs you don't need test_indirect_hasher and below as those do not currently make sense in const contexts. You could also put the const logic in the same function as the runtime logic using const items.

fee1-dead · 2022-11-10T00:07:53Z

@bors r+

bors · 2022-11-10T00:07:55Z

📌 Commit 56e59bc has been approved by fee1-dead

It is now in the queue for this repository.

…-dead Make `Hash`, `Hasher` and `BuildHasher` `#[const_trait]` and make `Sip` const `Hasher` This PR enables using Hashes in const context. r? `@fee1-dead`

…earth Rollup of 9 pull requests Successful merges: - rust-lang#101939 (Add loongarch64 abi support) - rust-lang#103863 (Use `TraitEngine` in more places, restrict visibility of `FulfillmentCtxt` constructor) - rust-lang#104036 (Suggest `is_some` when we've found `Option` but expected `bool`) - rust-lang#104060 (Make `Hash`, `Hasher` and `BuildHasher` `#[const_trait]` and make `Sip` const `Hasher`) - rust-lang#104077 (Use aapcs for efiapi calling convention on arm) - rust-lang#104186 (Tighten the 'introduce new binding' suggestion) - rust-lang#104194 (`EarlyBinder` docs) - rust-lang#104233 (Don't ICE when encountering `ConstKind::Error` in `RequiredConstsVisitor`) - rust-lang#104235 (Use `const_error_with_guaranteed` more) Failed merges: - rust-lang#104078 (Print "Checking/Building ..." message even when --dry-run is passed) - rust-lang#104169 (Migrate `:target` rules to use CSS variables) r? `@ghost` `@rustbot` modify labels: rollup

onestacked added 3 commits November 4, 2022 21:30

Made Hash and Hasher const_trait

1bcf9fa

Make BuildHasher const_trait

3ea4165

Made Sip const Hasher

5f9899b

rustbot assigned fee1-dead Nov 6, 2022

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 6, 2022

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Nov 6, 2022

onestacked mentioned this pull request Nov 6, 2022

Tracking Issue for Hashing in const context #104061

Closed

3 tasks

rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 6, 2022

Added const_hash tracking issue id

dc1f1a8

onestacked mentioned this pull request Nov 6, 2022

Constify TypeId ordering impls #101698

Merged

rustbot added the const-hack label Nov 6, 2022

fee1-dead reviewed Nov 7, 2022

View reviewed changes

library/core/src/hash/sip.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Removed unnecessary Trait bound

cebce1e

onestacked force-pushed the const_hash branch from 04ab88f to cebce1e Compare November 7, 2022 14:36

fee1-dead requested changes Nov 8, 2022

View reviewed changes

library/core/src/hash/mod.rs Outdated Show resolved Hide resolved

library/core/src/hash/mod.rs Outdated Show resolved Hide resolved

library/core/src/hash/sip.rs Show resolved Hide resolved

library/std/src/lib.rs Outdated Show resolved Hide resolved

onestacked force-pushed the const_hash branch 2 times, most recently from 8adc0da to d20c739 Compare November 8, 2022 16:35

Test const Hash, fix nits

56e59bc

onestacked force-pushed the const_hash branch from d20c739 to 56e59bc Compare November 8, 2022 16:39

onestacked requested a review from fee1-dead November 9, 2022 21:02

fee1-dead approved these changes Nov 10, 2022

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2022

Manishearth mentioned this pull request Nov 10, 2022

Rollup of 11 pull requests #104228

Closed

Manishearth mentioned this pull request Nov 10, 2022

Rollup of 9 pull requests #104246

Merged

bors merged commit 150e0ec into rust-lang:master Nov 10, 2022

rustbot added this to the 1.67.0 milestone Nov 10, 2022

onestacked deleted the const_hash branch February 4, 2023 16:29

Uh oh!

Conversation

onestacked commented Nov 6, 2022

Uh oh!

rustbot commented Nov 6, 2022

Uh oh!

onestacked commented Nov 6, 2022

Uh oh!

onestacked commented Nov 6, 2022

Uh oh!

Uh oh!

This comment has been minimized.

fee1-dead left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

onestacked commented Nov 8, 2022

Uh oh!

fee1-dead commented Nov 8, 2022

Uh oh!

onestacked commented Nov 8, 2022

Uh oh!

fee1-dead commented Nov 8, 2022

Uh oh!

fee1-dead commented Nov 10, 2022

Uh oh!

bors commented Nov 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants