Skip to content

Replace libc::{type} with crate::ffi::{type}#105524

Merged
bors merged 1 commit intorust-lang:masterfrom
Ayush1325:libc-free
Jan 28, 2023
Merged

Replace libc::{type} with crate::ffi::{type}#105524
bors merged 1 commit intorust-lang:masterfrom
Ayush1325:libc-free

Conversation

@Ayush1325
Copy link
Contributor

@Ayush1325 Ayush1325 commented Dec 10, 2022

Replace libc::{type} imports with crate::ffi::{type} outside of std::sys and std::os.

Signed-off-by: Ayush Singh ayushsingh1325@gmail.com

@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2022

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 10, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@bors
Copy link
Collaborator

bors commented Dec 31, 2022

☔ The latest upstream changes (presumably #106324) made this pull request unmergeable. Please resolve the merge conflicts.

@Ayush1325
Copy link
Contributor Author

Ayush1325 commented Dec 31, 2022

@joshtriplett is there any interest in merging this, or should I close it?

@pitaj
Copy link
Contributor

pitaj commented Jan 28, 2023 •
edited
Loading

This PR looks pretty good to me (an outsider). The T-libs PR backlog is just very long right now.

ChrisDenton
ChrisDenton approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... for areas that don't otherwise need libc I think it definitely makes some sense to do this. For other code, I'd be slightly less convinced its worth the churn. But this PR is small and the changes modest so r=me if you rebase.

@Ayush1325
Replace libc::{type} with crate::ffi::{type}
c50d3e2 
Replace libc::{type} imports with crate::ffi::{type} outside of
`std::sys` and `std::os`.

Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
@ChrisDenton
Copy link
Member

ChrisDenton commented Jan 28, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 28, 2023

📌 Commit c50d3e2 has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 28, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2023
@bors
Auto merge of rust-lang#107408 - matthiaskrgr:rollup-b5vz2ow, r=matth…
bca8b4d 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#104012 (Improve unexpected close and mismatch delimiter hint in TokenTreesReader)
 - rust-lang#104252 (Stabilize the const_socketaddr feature)
 - rust-lang#105524 (Replace libc::{type} with crate::ffi::{type})
 - rust-lang#107096 (Detect references to non-existant messages in Fluent resources)
 - rust-lang#107355 (Add regression test for rust-lang#60755)
 - rust-lang#107384 (Remove `BOOL_TY_FOR_UNIT_TESTING`)
 - rust-lang#107385 (Use `FallibleTypeFolder` for `ConstInferUnifier` not `TypeRelation`)
 - rust-lang#107391 (rustdoc: remove inline javascript from copy-path button)
 - rust-lang#107398 (Remove `ControlFlow::{BREAK, CONTINUE}`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 45430a5 into rust-lang:master Jan 28, 2023
@rustbot rustbot added this to the 1.69.0 milestone Jan 28, 2023
@Ayush1325 Ayush1325 deleted the libc-free branch January 28, 2023 16:20
flip1995 pushed a commit to flip1995/rust that referenced this pull request Feb 10, 2023
@bors
Auto merge of rust-lang#107408 - matthiaskrgr:rollup-b5vz2ow, r=matth…
75c8179 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#104012 (Improve unexpected close and mismatch delimiter hint in TokenTreesReader)
 - rust-lang#104252 (Stabilize the const_socketaddr feature)
 - rust-lang#105524 (Replace libc::{type} with crate::ffi::{type})
 - rust-lang#107096 (Detect references to non-existant messages in Fluent resources)
 - rust-lang#107355 (Add regression test for rust-lang#60755)
 - rust-lang#107384 (Remove `BOOL_TY_FOR_UNIT_TESTING`)
 - rust-lang#107385 (Use `FallibleTypeFolder` for `ConstInferUnifier` not `TypeRelation`)
 - rust-lang#107391 (rustdoc: remove inline javascript from copy-path button)
 - rust-lang#107398 (Remove `ControlFlow::{BREAK, CONTINUE}`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisDenton ChrisDenton ChrisDenton approved these changes

Assignees

@ChrisDenton ChrisDenton

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.69.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Ayush1325 @rustbot @bors @pitaj @ChrisDenton @joshtriplett