Structured suggestion for &mut dyn Iterator when possible#106363
Merged
bors merged 4 commits intorust-lang:masterfrom Jan 9, 2023
Merged
Structured suggestion for &mut dyn Iterator when possible#106363bors merged 4 commits intorust-lang:masterfrom
&mut dyn Iterator when possible#106363bors merged 4 commits intorust-lang:masterfrom
Conversation
Collaborator
|
r? @Nilstrieb (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Noratrieb
reviewed
Jan 3, 2023
Member
Noratrieb
left a comment
Noratrieb
left a comment
There was a problem hiding this comment.
The approach looks good to me modulo a few nits. It probably makes sense for another reviewer to look over it afterwards as I'm not very familiar with this kind of typeck code
estebank
force-pushed
the
mutability-mismatch-arg
branch
from
7d7077f to
bfffa7c
Compare
estebank
force-pushed
the
mutability-mismatch-arg
branch
from
bfffa7c to
b693365
Compare
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jan 9, 2023
…r=Nilstrieb Structured suggestion for `&mut dyn Iterator` when possible Fix rust-lang#37914.
This was referenced Jan 9, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 9, 2023
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#104163 (Don't derive Debug for `OnceWith` & `RepeatWith`) - rust-lang#106131 (Mention "signature" rather than "fn pointer" when impl/trait methods are incompatible) - rust-lang#106363 (Structured suggestion for `&mut dyn Iterator` when possible) - rust-lang#106497 (Suggest using clone when we have &T and T implemented Clone) - rust-lang#106584 (Document that `Vec::from_raw_parts[_in]` must be given a pointer from the correct allocator.) - rust-lang#106600 (Suppress type errors that come from private fields) - rust-lang#106602 (Add goml scripts to tidy checks) - rust-lang#106606 (Do not emit structured suggestion for turbofish with wrong span) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #37914.