Merged
Conversation
…omments, r=jackh726 Remove double spaces after dots in comments Most of the comments do not have double spaces, so I assume these are typos.
…fleLapkin prevent E0512 from emitting [type error] by checking the references_error but still emit E0512 this will fix rust-lang#106695
…nged, r=lcnr new trait solver: only consider goal changed if response is not identity I think this is the right way of implementing it.. r? `@lcnr`
Mention the lack of `windows_mut` in `windows` This is a common request, going back to at least 2015 (rust-lang#23783), so mention in the docs that it can't be done and offer a workaround using <https://doc.rust-lang.org/std/cell/struct.Cell.html#method.as_slice_of_cells>. (See also URLO threads like <https://internals.rust-lang.org/t/a-windows-mut-method-on-slice/16941/10?u=scottmcm>.)
…=michaelwoerister Use `scope_expr_id` from `ProbeCtxt` We already store it in the `ProbeCtxt`, so just retrieve it from there.
…s, r=lcnr Switch to `EarlyBinder` for `item_bounds` query Part of the work to finish rust-lang#105779 (also see rust-lang/types-team#78). Several queries `X` have a `bound_X` variant that wraps the output in `EarlyBinder`. This adds `EarlyBinder` to the return type of the `item_bounds` query and removes `bound_item_bounds`. r? `@lcnr`
…l_instead, r=lcnr Hide `_use_mk_alias_ty_instead` in `<AliasTy as Debug>::fmt`
rustbot
added
A-query-system
Member
Author
|
@bors r+ rollup=never p=7 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: 3984bc5833 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (edefa41): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
windows_mutinwindows#106889 (Mention the lack ofwindows_mutinwindows)scope_expr_idfromProbeCtxt#106963 (Usescope_expr_idfromProbeCtxt)EarlyBinderforitem_boundsquery #106970 (Switch toEarlyBinderforitem_boundsquery)_use_mk_alias_ty_insteadin<AliasTy as Debug>::fmt#106980 (Hide_use_mk_alias_ty_insteadin<AliasTy as Debug>::fmt)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup