Merged
Conversation
…e query responses after
Signed-off-by: ozkanonur <work@onurozkan.dev>
…inking Signed-off-by: ozkanonur <work@onurozkan.dev>
… r=jyn514 ship tools with sysroot Provides tool binaries under the sysroot which can be used/tested with `cargo +custom-toolchain $tool` Clippy and fmt works without any problem. But can't say the same for miri: ```sh ~/devspace/.other/chunk-list stable $ cargo +stage2 miri setup Running `"rustup" "component" "add" "rust-src"` to install the `rust-src` component for the selected toolchain. error: stage2 is a custom toolchain fatal error: failed to install the `rust-src` component for the selected toolchain ``` it's looking for `$sysroot/lib/rustlib/src/rust/library` and that simply doesn't exists for `x build`. cc `@jyn514` (I thought you might be interested on this, since you did few review iterations on previous PRs of adding tools to sysroot) -- **Update** Now we are able to use `miri` as well. After running `x b miri cargo-miri --stage 2`, I am able to run `cargo +stage2 miri setup` which works as expected. Resolves rust-lang#110625 Resolves rust-lang#97762 Resolves rust-lang#81431
…t-items, r=cjgillot Substitute missing trait items suggestion correctly Properly substitute missing item suggestions, so that when they reference generics from their parent trait they actually have the right time for the impl. Also, some other minor tweaks like using `/* Type */` to signify a GAT's type is actually missing, and fixing generic arg suggestions for GATs in general.
fix(error): normalize whitespace during msg_to_buffer close rust-lang#110547
…=compiler-errors remove unused ftl messages r? `@davidtwco` does it make sense to check via tidy that there exist no ftl message names which are never mentioned in `compiler/**.rs`
…-reexport-pub-reexport, r=notriddle Add regression test for rust-lang#46506 Fixes rust-lang#46506. This issue was fixed very likely alongside the others when we cleaned up the re-exports code. r? `@notriddle`
… r=BoxyUwU Track if EvalCtxt has been tainted, make sure it can't be used to make query responses after Just some additional protection against missing probes or strange candidate assembly behavior in the new solver. For background, we don't ever want to call `evaluate_added_goals_and_make_canonical_response` if a previous call to `try_evaluate_added_goals` has bailed with `NoSolution`, since our nested goals are left in an undefined state at that point. This most commonly suggests a missing `EvalCtxt::probe`, but could also signify some other shenanigans like dropping a `QueryResult` on the floor without properly `?`'ing it. r? `@lcnr`
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ rollup=never p=6 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: 77778e075d In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (b92a41c): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup