make sure panic_nounwind_fmt can still be fully inlined (e.g. for panic_immediate_abort)

[RalfJung]

Follow-up to #110303.

[rustbot]

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

[RalfJung]

@saethlin is there any reason you used different attributes for this function than what all the others in this file do?

[saethlin]

Argh we should really have codegen tests for this feature. That would settle all this fiddling with attributes, or at least we could know that whatever is in the code works as intended. I'll open an issue later if I remember.

I think #[cold] discourages inlining but if the body has been optimized to just an unreachable terminator it still gets optimized away. Whether by the MIR inliner or LLVM I'm not sure.

[saethlin]

#118393

[RalfJung]

r? libs

[thomcc]

LGTM

@bors r+

[bors]

📌 Commit 8de5bd0 has been approved by thomcc

It is now in the queue for this repository.

[bors]

⌛ Testing commit 8de5bd0 with merge 154f645...

[bors]

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing 154f645 to master...

[rust-timer]

Finished benchmarking commit (154f645): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.4%, 0.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.5%	[3.5%, 3.5%]	1
Improvements ✅ (primary)	-2.0%	[-2.0%, -2.0%]	1
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-2.0%	[-2.0%, -2.0%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.0%	[-5.2%, -4.9%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.029s -> 674.255s (-0.11%)
Artifact size: 314.15 MiB -> 314.15 MiB (-0.00%)