Encode hir attributes cross-crate properly

[jdonszelmann]

r? @oli-obk

This should return the lost perf in #138165

cc: @therealprof

[rustbot]

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit a1e655d with merge 3d3aa78...

[bors]

☀️ Try build successful - checks-actions
Build commit: 3d3aa78 (3d3aa7894aface06da60fe7023a7ad0455576db7)

[rust-timer]

Finished benchmarking commit (3d3aa78): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.7%, 2.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.8%, -0.2%]	13
Improvements ✅ (secondary)	-0.6%	[-0.8%, -0.2%]	20
All ❌✅ (primary)	-0.1%	[-0.8%, 2.7%]	14

Max RSS (memory usage)

Results (primary -1.3%, secondary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.3%	[-1.4%, -1.2%]	3
Improvements ✅ (secondary)	-2.0%	[-3.0%, -0.7%]	12
All ❌✅ (primary)	-1.3%	[-1.4%, -1.2%]	3

Cycles

Results (primary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.9%, 2.9%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.9%	[2.9%, 2.9%]	1

Binary size

Results (primary -0.1%, secondary -0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.6%, -0.0%]	85
Improvements ✅ (secondary)	-0.2%	[-0.8%, -0.0%]	40
All ❌✅ (primary)	-0.1%	[-0.6%, 1.1%]	86

Bootstrap: 691.482s -> 692.142s (0.10%)
Artifact size: 371.94 MiB -> 371.94 MiB (0.00%)

[oli-obk]

@bors r+

[bors]

📌 Commit a1e655d has been approved by oli-obk

It is now in the queue for this repository.

[therealprof]

@jdonszelmann Sweet, thanks for looking into it.

[jdonszelmann]

still don't get the +2.7% on clap

[jdonszelmann]

@therealprof is it a problem that the perf regression is now going to be on Beta? I believe the cutoff for that just happened

[workingjubilee]

forcing rollup=never drain:

@bors p=5

[bors]

⌛ Testing commit a1e655d with merge c545bad...

[bors]

💔 Test failed - checks-actions

[jdonszelmann]

@bors r+

[bors]

📌 Commit 64a1a98 has been approved by jdonszelmann

It is now in the queue for this repository.

[jdonszelmann]

ah shit,

@bors r-
@bors r=oli-obk

[bors]

📌 Commit 64a1a98 has been approved by oli-obk

It is now in the queue for this repository.

[bors]

⌛ Testing commit 64a1a98 with merge 0fa4ec6...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 0fa4ec6 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d14d202 (parent) -> 0fa4ec6 (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 0fa4ec6cde46fa17ab07acb5531cfe0dc1349ffa --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. x86_64-apple-2: 3909.6s -> 5022.5s (28.5%)
2. dist-x86_64-apple: 7812.6s -> 9968.9s (27.6%)
3. x86_64-rust-for-linux: 2487.9s -> 2935.6s (18.0%)
4. x86_64-gnu-tools: 3287.5s -> 3795.6s (15.5%)
5. x86_64-gnu-llvm-20-1: 3286.5s -> 3744.0s (13.9%)
6. dist-aarch64-apple: 6040.1s -> 5296.5s (-12.3%)
7. aarch64-gnu-debug: 3662.4s -> 4088.2s (11.6%)
8. i686-gnu-2: 5682.3s -> 6318.8s (11.2%)
9. i686-gnu-1: 7275.1s -> 8085.5s (11.1%)
10. mingw-check-1: 1575.1s -> 1748.2s (11.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (0fa4ec6): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-1.4%, -0.1%]	16
Improvements ✅ (secondary)	-0.6%	[-1.3%, -0.2%]	20
All ❌✅ (primary)	-0.4%	[-1.4%, -0.1%]	16

Max RSS (memory usage)

Results (primary -1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.4%	[3.4%, 3.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.7%	[-4.7%, -0.9%]	7
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.1%	[-4.7%, 3.4%]	8

Cycles

Results (secondary 1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.5%	[1.5%, 1.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.2%, secondary -0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.6%, -0.0%]	86
Improvements ✅ (secondary)	-0.2%	[-0.8%, -0.0%]	40
All ❌✅ (primary)	-0.2%	[-0.6%, -0.0%]	86

Bootstrap: 689.033s -> 689.313s (0.04%)
Artifact size: 372.09 MiB -> 372.06 MiB (-0.01%)

[jdonszelmann]

well, that seems to have had positive effects. Maybe not perfect but it's good that that merged @therealprof :)