Port `#[track_caller]` to the new attribute system by jdonszelmann · Pull Request #142825 · rust-lang/rust

jdonszelmann · 2025-06-21T12:10:23Z

depends on #142493

(didn't add a test for this, this situation should simply never come up again, the code was simply wrong. lmk if I should add it, but it won't test something very useful)

rustbot · 2025-06-21T12:10:29Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

jdonszelmann · 2025-06-21T12:11:33Z

compiler/rustc_passes/src/check_attr.rs

            // erroneously allowed it and some crates used it accidentally, to be compatible
            // with crates depending on them, we can't throw an error here.
            Target::Field | Target::Arm | Target::MacroDef => {
-                for attr in attrs {


this entire loop is simply wrong and unnecessary

bors · 2025-06-21T18:51:17Z

☔ The latest upstream changes (presumably #142826) made this pull request unmergeable. Please resolve the merge conflicts.

jdonszelmann · 2025-06-24T10:26:51Z

@oli-obk should be ready for review

oli-obk · 2025-06-24T12:31:26Z

ok this one was like just a straight forward translation. With all the infrastructure in place from the previous ones further ones seem to be getting simpler ^^

@bors r+

bors · 2025-06-24T12:31:29Z

📌 Commit c7530e3 has been approved by oli-obk

It is now in the queue for this repository.

bors · 2025-06-24T14:40:39Z

☔ The latest upstream changes (presumably #142956) made this pull request unmergeable. Please resolve the merge conflicts.

Rollup of 7 pull requests Successful merges: - #137268 (Allow comparisons between `CStr`, `CString`, and `Cow<CStr>`.) - #142704 (Remove the deprecated unstable `concat_idents!` macro) - #142742 ([win][aarch64] Fix linking statics on Arm64EC, take 2) - #142843 (Enable reproducible-build-2 for Windows MSVC) - #142916 (rustdoc-json: Add test for `#[optimize(..)]`) - #142919 (rustdoc-json: Add test for `#[cold]`) - #142944 (Stats output tweaks) Failed merges: - #142825 (Port `#[track_caller]` to the new attribute system) r? `@ghost` `@rustbot` modify labels: rollup

jdonszelmann · 2025-06-24T20:37:47Z

@bors r=oli-obk

bors · 2025-06-24T20:37:50Z

📌 Commit 6801500 has been approved by oli-obk

It is now in the queue for this repository.

jdonszelmann · 2025-06-24T20:43:33Z

@bors r-

jdonszelmann · 2025-06-24T22:20:23Z

@bors r=oli-obk

bors · 2025-06-24T22:20:26Z

📌 Commit f9cdf3f has been approved by oli-obk

It is now in the queue for this repository.

Port `#[track_caller]` to the new attribute system r? `@oli-obk` depends on rust-lang#142493 Closes rust-lang#142783 (didn't add a test for this, this situation should simply never come up again, the code was simply wrong. lmk if I should add it, but it won't test something very useful)

Rollup of 15 pull requests Successful merges: - #135731 (Implement parsing of pinned borrows) - #138780 (Add `#[loop_match]` for improved DFA codegen) - #142453 (Windows: make `read_dir` stop iterating after the first error is encountered) - #142633 (Error on invalid signatures for interrupt ABIs) - #142768 (Avoid a bitcast FFI call in transmuting) - #142825 (Port `#[track_caller]` to the new attribute system) - #142844 (Enable short-ice for Windows) - #142934 (Tweak `-Zmacro-stats` measurement.) - #142955 (Couple of test suite fixes for cg_clif) - #142977 (rustdoc: Don't mark `#[target_feature]` functions as ⚠) - #142980 (Reduce mismatched-lifetime-syntaxes suggestions to MaybeIncorrect) - #142982 (Corrected spelling mistake in c_str.rs) - #142983 (Taint body on invalid call ABI) - #142988 (Update wasm-component-ld to 0.5.14) - #142993 (Update cargo) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #142825 - jdonszelmann:track-caller, r=oli-obk Port `#[track_caller]` to the new attribute system r? ``@oli-obk`` depends on #142493 Closes #142783 (didn't add a test for this, this situation should simply never come up again, the code was simply wrong. lmk if I should add it, but it won't test something very useful)

Rollup of 15 pull requests Successful merges: - rust-lang/rust#135731 (Implement parsing of pinned borrows) - rust-lang/rust#138780 (Add `#[loop_match]` for improved DFA codegen) - rust-lang/rust#142453 (Windows: make `read_dir` stop iterating after the first error is encountered) - rust-lang/rust#142633 (Error on invalid signatures for interrupt ABIs) - rust-lang/rust#142768 (Avoid a bitcast FFI call in transmuting) - rust-lang/rust#142825 (Port `#[track_caller]` to the new attribute system) - rust-lang/rust#142844 (Enable short-ice for Windows) - rust-lang/rust#142934 (Tweak `-Zmacro-stats` measurement.) - rust-lang/rust#142955 (Couple of test suite fixes for cg_clif) - rust-lang/rust#142977 (rustdoc: Don't mark `#[target_feature]` functions as ⚠) - rust-lang/rust#142980 (Reduce mismatched-lifetime-syntaxes suggestions to MaybeIncorrect) - rust-lang/rust#142982 (Corrected spelling mistake in c_str.rs) - rust-lang/rust#142983 (Taint body on invalid call ABI) - rust-lang/rust#142988 (Update wasm-component-ld to 0.5.14) - rust-lang/rust#142993 (Update cargo) r? `@ghost` `@rustbot` modify labels: rollup

…kingjubilee Rollup of 15 pull requests Successful merges: - rust-lang#135731 (Implement parsing of pinned borrows) - rust-lang#138780 (Add `#[loop_match]` for improved DFA codegen) - rust-lang#142453 (Windows: make `read_dir` stop iterating after the first error is encountered) - rust-lang#142633 (Error on invalid signatures for interrupt ABIs) - rust-lang#142768 (Avoid a bitcast FFI call in transmuting) - rust-lang#142825 (Port `#[track_caller]` to the new attribute system) - rust-lang#142844 (Enable short-ice for Windows) - rust-lang#142934 (Tweak `-Zmacro-stats` measurement.) - rust-lang#142955 (Couple of test suite fixes for cg_clif) - rust-lang#142977 (rustdoc: Don't mark `#[target_feature]` functions as ⚠) - rust-lang#142980 (Reduce mismatched-lifetime-syntaxes suggestions to MaybeIncorrect) - rust-lang#142982 (Corrected spelling mistake in c_str.rs) - rust-lang#142983 (Taint body on invalid call ABI) - rust-lang#142988 (Update wasm-component-ld to 0.5.14) - rust-lang#142993 (Update cargo) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 15 pull requests Successful merges: - rust-lang/rust#135731 (Implement parsing of pinned borrows) - rust-lang/rust#138780 (Add `#[loop_match]` for improved DFA codegen) - rust-lang/rust#142453 (Windows: make `read_dir` stop iterating after the first error is encountered) - rust-lang/rust#142633 (Error on invalid signatures for interrupt ABIs) - rust-lang/rust#142768 (Avoid a bitcast FFI call in transmuting) - rust-lang/rust#142825 (Port `#[track_caller]` to the new attribute system) - rust-lang/rust#142844 (Enable short-ice for Windows) - rust-lang/rust#142934 (Tweak `-Zmacro-stats` measurement.) - rust-lang/rust#142955 (Couple of test suite fixes for cg_clif) - rust-lang/rust#142977 (rustdoc: Don't mark `#[target_feature]` functions as ⚠) - rust-lang/rust#142980 (Reduce mismatched-lifetime-syntaxes suggestions to MaybeIncorrect) - rust-lang/rust#142982 (Corrected spelling mistake in c_str.rs) - rust-lang/rust#142983 (Taint body on invalid call ABI) - rust-lang/rust#142988 (Update wasm-component-ld to 0.5.14) - rust-lang/rust#142993 (Update cargo) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned oli-obk Jun 21, 2025

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 21, 2025

jdonszelmann commented Jun 21, 2025

View reviewed changes

jdonszelmann mentioned this pull request Jun 22, 2025

Tracking issue: Attribute refactor #131229

Open

9 tasks

jdonszelmann force-pushed the track-caller branch from ae97fcd to c7530e3 Compare June 24, 2025 10:26

oli-obk approved these changes Jun 24, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2025

GuillaumeGomez mentioned this pull request Jun 24, 2025

Rollup of 7 pull requests #142962

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 24, 2025

jdonszelmann force-pushed the track-caller branch from c7530e3 to 6801500 Compare June 24, 2025 20:33

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 24, 2025

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 24, 2025

Rewrite #[track_caller]

5d44fdd

jdonszelmann added 2 commits June 24, 2025 23:00

fix clippy

40a33af

fix 142783

f9cdf3f

jdonszelmann force-pushed the track-caller branch from 6801500 to f9cdf3f Compare June 24, 2025 21:15

jdonszelmann mentioned this pull request Jun 24, 2025

Port #[export_name] to the new attribute parsing infrastructure #142986

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 24, 2025

This was referenced Jun 25, 2025

Rollup of 15 pull requests #142995

Closed

Rollup of 15 pull requests #142997

Merged

bors merged commit 2ad6272 into rust-lang:master Jun 25, 2025
10 checks passed

rustbot added this to the 1.90.0 milestone Jun 25, 2025

Uh oh!

Conversation

jdonszelmann commented Jun 21, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 21, 2025

Uh oh!

jdonszelmann Jun 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bors commented Jun 21, 2025

Uh oh!

jdonszelmann commented Jun 24, 2025

Uh oh!

oli-obk commented Jun 24, 2025

Uh oh!

bors commented Jun 24, 2025

Uh oh!

bors commented Jun 24, 2025

Uh oh!

jdonszelmann commented Jun 24, 2025

Uh oh!

bors commented Jun 24, 2025

Uh oh!

This comment has been minimized.

jdonszelmann commented Jun 24, 2025

Uh oh!

jdonszelmann commented Jun 24, 2025

Uh oh!

bors commented Jun 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jdonszelmann commented Jun 21, 2025 •

edited by rustbot

Loading

jdonszelmann Jun 21, 2025 •

edited

Loading