Add `ToolTarget` to bootstrap by Kobzol · Pull Request #143641 · rust-lang/rust

Kobzol · 2025-07-08T15:54:37Z

Oh, you thought I'm done with refactoring bootstrap tools? Na-ah, think again! After the failure of #143581, ToolTarget is back with a vengeance. This time, I implemented the test changes and tool cleanups without forcing these tools to be built with the stage0 compiler.

There are still some small wins though, LlvmBitcodeLinker now starts at stage 1, and not stage 2. Cargo should also be ported to this new mode, but I'm leaving that for a follow-up PR.

Hopefully X-th time's the charm 🤞

r? @jieyouxu

Kobzol · 2025-07-09T09:47:08Z

#142357 was merged, so undrafting.

jieyouxu

I need to sit on this scheme a bit, I still find it a bit confusing.

(I was reviewing this commit-by-commit, but now I realize I should've looked at the overall diff)

src/bootstrap/src/core/build_steps/tool.rs

jieyouxu

Thanks. I'm on-board with the overall change, just some small nits and a double-check.

src/bootstrap/src/core/build_steps/tool.rs

jieyouxu · 2025-07-15T02:24:09Z

@rustbot author

Kobzol · 2025-07-15T17:48:09Z

Clarified comments.

@rustbot ready

jieyouxu · 2025-07-16T00:28:56Z

Thanks
@bors r+ rollup=never

Add `ToolTarget` to bootstrap Oh, you thought I'm done with refactoring bootstrap tools? Na-ah, think again! After the failure of #143581, `ToolTarget` is back with a vengeance. This time, I implemented the test changes and tool cleanups without forcing these tools to be built with the stage0 compiler. There are still some small wins though, `LlvmBitcodeLinker` now starts at stage 1, and not stage 2. Cargo should also be ported to this new mode, but I'm leaving that for a follow-up PR. Hopefully X-th time's the charm 🤞 r? `@jieyouxu`

bors · 2025-07-19T03:40:31Z

⌛ Testing commit 4f1b3e3 with merge 826842b...

bors · 2025-07-19T05:01:34Z

💔 Test failed - checks-actions

Kobzol · 2025-07-19T08:28:05Z

@bors2 try jobs=dist-aarch64-windows-gnullvm

rust-bors · 2025-07-19T08:28:09Z

⌛ Trying commit f16016a with merge a0e3c55…

To cancel the try build, run the command @bors2 try cancel.

Add `ToolTarget` to bootstrap Oh, you thought I'm done with refactoring bootstrap tools? Na-ah, think again! After the failure of #143581, `ToolTarget` is back with a vengeance. This time, I implemented the test changes and tool cleanups without forcing these tools to be built with the stage0 compiler. There are still some small wins though, `LlvmBitcodeLinker` now starts at stage 1, and not stage 2. Cargo should also be ported to this new mode, but I'm leaving that for a follow-up PR. Hopefully X-th time's the charm 🤞 r? `@jieyouxu` try-job: dist-aarch64-windows-gnullvm

rust-bors · 2025-07-19T09:59:26Z

☀️ Try build successful (CI)
Build commit: a0e3c55 (a0e3c5564fd0a9dd131941fbc58387ba38233c7f, parent: 1079c5edb2bd837e5c4cf8c7db2892db359a3862)

Kobzol · 2025-07-19T10:02:31Z

I switched the dist LLVM bitcode linker to also use a build compiler instead of a target compiler, because the existing dist code was using that, and it would be hard to change right now.

@rustbot ready

jieyouxu

Thanks

jieyouxu · 2025-07-19T10:28:54Z

@bors r+ rollup=never

bors · 2025-07-19T10:28:57Z

📌 Commit f16016a has been approved by jieyouxu

It is now in the queue for this repository.

bors · 2025-07-19T14:10:00Z

⌛ Testing commit f16016a with merge f63685d...

bors · 2025-07-19T17:14:35Z

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing f63685d to master...

github-actions · 2025-07-19T17:17:44Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 12865ff (parent) -> f63685d (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f63685ddf3d3c92a61158cd55d44bde17c2b024f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 6423.5s -> 9416.4s (46.6%)
dist-x86_64-apple: 7864.0s -> 10215.2s (29.9%)
pr-check-2: 2608.3s -> 2161.1s (-17.1%)
aarch64-gnu-debug: 4432.2s -> 3783.9s (-14.6%)
pr-check-1: 1697.5s -> 1489.5s (-12.3%)
i686-gnu-1: 8081.2s -> 7152.8s (-11.5%)
dist-powerpc64le-linux-musl: 5002.0s -> 5553.3s (11.0%)
x86_64-gnu-tools: 3777.0s -> 3368.2s (-10.8%)
x86_64-rust-for-linux: 2837.2s -> 2531.0s (-10.8%)
dist-aarch64-windows-gnullvm: 4391.7s -> 4822.6s (9.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-07-19T18:26:22Z

Finished benchmarking commit (f63685d): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 465.616s -> 465.551s (-0.01%)
Artifact size: 374.55 MiB -> 374.61 MiB (0.02%)

Add `ToolTarget` to bootstrap Oh, you thought I'm done with refactoring bootstrap tools? Na-ah, think again! After the failure of rust-lang#143581, `ToolTarget` is back with a vengeance. This time, I implemented the test changes and tool cleanups without forcing these tools to be built with the stage0 compiler. There are still some small wins though, `LlvmBitcodeLinker` now starts at stage 1, and not stage 2. Cargo should also be ported to this new mode, but I'm leaving that for a follow-up PR. Hopefully X-th time's the charm 🤞 r? `@jieyouxu`

rustbot assigned jieyouxu Jul 8, 2025

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 8, 2025

Kobzol added 7 commits July 9, 2025 11:46

Rename compiler to build_compiler

86c6197

Add Mode::ToolTarget

2fbc642

Port RemoteTestServer to ToolTarget

6511ece

Make WasmComponentLd a ToolTarget tool

89370e0

Make LldWrapper a ToolTarget tool

c571b97

Extend dist extended tools test

d79e98c

Make LlvmBitcodeLinker a ToolTarget tool

5933053

Kobzol force-pushed the tool-target branch from c2fdea5 to 5933053 Compare July 9, 2025 09:46

Kobzol marked this pull request as ready for review July 9, 2025 09:46

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 9, 2025

jieyouxu reviewed Jul 10, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Kobzol added 2 commits July 10, 2025 12:40

Rename for_compiler to for_use_by_compiler

205587b

Clarify get_tool_target_compiler

85c286a

Kobzol force-pushed the tool-target branch from a840253 to 85c286a Compare July 10, 2025 10:40

Remove min-specialization feature from WasmComponentLd

e6bb644

Kobzol mentioned this pull request Jul 11, 2025

Implement check for compiletest and RA using tool macro #143816

Merged

jieyouxu approved these changes Jul 15, 2025

View reviewed changes

src/bootstrap/src/core/build_steps/tool.rs Show resolved Hide resolved

src/bootstrap/src/core/build_steps/tool.rs Outdated Show resolved Hide resolved

src/bootstrap/src/core/build_steps/tool.rs Show resolved Hide resolved

src/bootstrap/src/core/build_steps/tool.rs Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2025

Clarify comments

4f1b3e3

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 15, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2025

Kobzol mentioned this pull request Jul 17, 2025

./x test library/std fails with library profile #142505

Open

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 19, 2025

Fix compiler for dist LLVM bitcode linker

f16016a

jieyouxu approved these changes Jul 19, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 19, 2025

bors merged commit f63685d into rust-lang:master Jul 19, 2025
13 checks passed

rustbot added this to the 1.90.0 milestone Jul 19, 2025

Kobzol deleted the tool-target branch July 19, 2025 17:23

bors mentioned this pull request Jul 19, 2025

Add relnotes-api-list in-tree tool #143053

Draft

4 tasks

Uh oh!

Conversation

Kobzol commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kobzol commented Jul 9, 2025

Uh oh!

jieyouxu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Jul 15, 2025

Uh oh!

Kobzol commented Jul 15, 2025

Uh oh!

jieyouxu commented Jul 16, 2025

Uh oh!

bors commented Jul 19, 2025

Uh oh!

This comment has been minimized.

bors commented Jul 19, 2025

Uh oh!

Kobzol commented Jul 19, 2025

Uh oh!

rust-bors bot commented Jul 19, 2025

Uh oh!

rust-bors bot commented Jul 19, 2025

Uh oh!

Kobzol commented Jul 19, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Jul 19, 2025

Uh oh!

bors commented Jul 19, 2025

Uh oh!

bors commented Jul 19, 2025

Uh oh!

bors commented Jul 19, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 19, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jul 19, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Kobzol commented Jul 8, 2025 •

edited

Loading

jieyouxu left a comment •

edited

Loading