Simplify library dependencies on compiler-builtins#144683
Merged
bors merged 3 commits intorust-lang:masterfrom Aug 1, 2025
Merged
Simplify library dependencies on compiler-builtins#144683bors merged 3 commits intorust-lang:masterfrom
compiler-builtins#144683bors merged 3 commits intorust-lang:masterfrom
Conversation
core via rustc-std-workspace-core in library/panic*compiler-builtins
Collaborator
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
Contributor
Author
|
Things pass locally, assuming similar luck in CI |
This comment has been minimized.
This comment has been minimized.
38dea0f to
d7654b9
Compare
Member
|
@bors r+ |
Collaborator
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Jul 31, 2025
…e, r=bjorn3 Simplify library dependencies on `compiler-builtins` The three panic-related library crates need to have access to `core`, and `compiler-builtins` needs to be in the crate graph. Rather than specifying both dependencies, switch these crates to use `rustc-std-workspace-core` which already does this. This means there is now a single place that the `compiler-builtins` dependency needs to get configured, for everything other than `alloc` and `std`. The second commit removes `compiler-builtins` from `std` (more details in the message).
bors
added a commit
that referenced
this pull request
Jul 31, 2025
Rollup of 6 pull requests Successful merges: - #135975 (Implement `push_mut`) - #143672 (Fix Box allocator drop elaboration) - #144232 (Implement support for `become` and explicit tail call codegen for the LLVM backend) - #144663 (coverage: Re-land "Enlarge empty spans during MIR instrumentation") - #144683 (Simplify library dependencies on `compiler-builtins`) - #144685 (Only extract lang items once in codegen_fn_attrs) r? `@ghost` `@rustbot` modify labels: rollup
Member
|
@bors r- |
Contributor
Author
|
...okay what? Added in 61e550a, @Ayush1325 why doesn't that create slices and do |
Contributor
Author
|
@bors2 try jobs=dist-various-2 |
Contributor
rust-bors bot
added a commit
that referenced
this pull request
Jul 31, 2025
Simplify library dependencies on `compiler-builtins` try-job: dist-various-2
Contributor
`compiler_builtins` shouldn't be called directly. Change the `PartialEq` implementation for `DevicePathNode` to use slice equality instead, which will call `memcmp`/`bcmp` via the intrinsic.
The three panic-related library crates need to have access to `core`, and `compiler-builtins` needs to be in the crate graph. Rather than specifying both dependencies, switch these crates to use `rustc-std-workspace-core` which already does this. This means there is now a single place that the `compiler-builtins` dependency needs to get configured, for everything other than `alloc` and `std`.
`compiler-builtins` is already in the crate graph via `alloc`, and all features related to `compiler-builtins` goes through `alloc`. There isn't any reason that `std` needs this direct dependency, so remove it.
4f7f450 to
42bf044
Compare
Contributor
Author
|
Thanks Nora! @bors r=bjorn3,Noratrieb |
Collaborator
bors
added a commit
that referenced
this pull request
Aug 1, 2025
Rollup of 7 pull requests Successful merges: - #143849 (rustdoc: never link to unnamable items) - #144683 (Simplify library dependencies on `compiler-builtins`) - #144691 (Extend `is_case_difference` to handle digit-letter confusables) - #144700 (rustdoc-json: Move `#[macro_export]` from `Other` to it's own variant) - #144751 (Add correct dynamic_lib_extension for aix) - #144757 (Ping Muscraft when emitter change) - #144759 (triagebot: Label `compiler-builtins` T-libs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Aug 1, 2025
Rollup merge of #144683 - tgross35:builtins-via-std-workspace, r=bjorn3,Noratrieb Simplify library dependencies on `compiler-builtins` The three panic-related library crates need to have access to `core`, and `compiler-builtins` needs to be in the crate graph. Rather than specifying both dependencies, switch these crates to use `rustc-std-workspace-core` which already does this. This means there is now a single place that the `compiler-builtins` dependency needs to get configured, for everything other than `alloc` and `std`. The second commit removes `compiler-builtins` from `std` (more details in the message).
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Aug 4, 2025
…e, r=bjorn3,Noratrieb Simplify library dependencies on `compiler-builtins` The three panic-related library crates need to have access to `core`, and `compiler-builtins` needs to be in the crate graph. Rather than specifying both dependencies, switch these crates to use `rustc-std-workspace-core` which already does this. This means there is now a single place that the `compiler-builtins` dependency needs to get configured, for everything other than `alloc` and `std`. The second commit removes `compiler-builtins` from `std` (more details in the message).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three panic-related library crates need to have access to
core, andcompiler-builtinsneeds to be in the crate graph. Rather than specifying both dependencies, switch these crates to userustc-std-workspace-corewhich already does this.This means there is now a single place that the
compiler-builtinsdependency needs to get configured, for everything other thanallocandstd.The second commit removes
compiler-builtinsfromstd(more details in the message).r? @ghost