rustdoc-json: Move #[macro_export] from Other to it's own variant#144700
Merged
bors merged 2 commits intorust-lang:masterfrom Aug 1, 2025
Merged
rustdoc-json: Move #[macro_export] from Other to it's own variant#144700bors merged 2 commits intorust-lang:masterfrom
#[macro_export] from Other to it's own variant#144700bors merged 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
A-rustdoc-json
Collaborator
|
rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi These commits modify Please ensure that if you've changed the output:
|
GuillaumeGomez
approved these changes
Jul 31, 2025
Member
|
Thanks! @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
Contributor
|
@bors r- |
bors
added
S-waiting-on-author
Contributor
|
could we wait like a little bit with this? |
Contributor
|
this is about to merge to make it a parsed attribute: #143857. Expect it to merge today, and it's been open for a long time. I kind of want to let it go through and implement this based on that if that's okay with you all. |
Contributor
|
if the other one doesn't make it today I'll r+ this again and we'll do it the other way round |
Contributor
|
@bors r=GuillaumeGomez (talked to the author of the other PR) |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 1, 2025
Rollup of 7 pull requests Successful merges: - #143849 (rustdoc: never link to unnamable items) - #144683 (Simplify library dependencies on `compiler-builtins`) - #144691 (Extend `is_case_difference` to handle digit-letter confusables) - #144700 (rustdoc-json: Move `#[macro_export]` from `Other` to it's own variant) - #144751 (Add correct dynamic_lib_extension for aix) - #144757 (Ping Muscraft when emitter change) - #144759 (triagebot: Label `compiler-builtins` T-libs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Aug 1, 2025
Rollup merge of #144700 - aDotInTheVoid:macro-rules-for-macro-fools, r=GuillaumeGomez rustdoc-json: Move `#[macro_export]` from `Other` to it's own variant Followup to #142936. cargo-semver-checks [cares about this attribute](https://github.com/obi1kenobi/trustfall-rustdoc-adapter/blob/4a0d1b0ca19b3115bb65d0b6695c388d7f474ac9/src/visibility_tracker.rs#L459-L476), and it wasn't included in the initial PR for structured attributes CC `@obi1kenobi.` r? `@GuillaumeGomez`
This was referenced Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #142936.
cargo-semver-checks cares about this attribute, and it wasn't included in the initial PR for structured attributes CC @obi1kenobi.
r? @GuillaumeGomez