Use attribute name in message for "outer attr used as inner attr" errors by scrabsha · Pull Request #145792 · rust-lang/rust

scrabsha · 2025-08-23T17:58:35Z

rustbot · 2025-08-23T17:58:39Z

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2025-08-23T17:58:41Z

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

scrabsha · 2025-08-23T18:17:44Z

Discussed with @jdonszelmann: this does not work for the new attribute infrastructure. Ideally we want the each *Parser implementation to say whether an attribute is a crate-level or normal attribute.

jdonszelmann · 2025-08-24T07:23:00Z

@rustbot author

rustbot · 2025-08-24T07:23:04Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot · 2025-08-24T17:46:43Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

rustbot · 2025-08-24T17:46:44Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

scrabsha · 2025-08-24T17:53:02Z

The force-push contains:

A rebase to a newer master (after the merge of Port #[crate_name] to the new attribute parsing infrastructure #137729, which makes it easy to test this MR for new style attributes).
The type/style/position checks for the new style attributes.

@rustbot review

compiler/rustc_passes/messages.ftl

tests/ui/lint/linker-warning.stderr

compiler/rustc_passes/src/check_attr.rs

scrabsha · 2025-08-25T19:36:22Z

compiler/rustc_passes/src/errors.rs

+pub(crate) struct OuterCrateLevelAttr {
+    #[subdiagnostic]
+    pub suggestion: OuterCrateLevelAttrSuggestion,
+}
+
+#[derive(Subdiagnostic)]
+#[multipart_suggestion(passes_outer_crate_level_attr_suggestion, style = "verbose")]
+pub(crate) struct OuterCrateLevelAttrSuggestion {
+    #[suggestion_part(code = "!")]
+    pub bang_position: Span,
+}


i spent a long time trying to figure out how to make a correct subdiagnostic and i would not be surprised if this was massively suboptimal. reviewer, please double-check this bit :3

I think it's alright, at least similar to ones I've made before.

jdonszelmann

Lovely

View changes since this review

jdonszelmann · 2025-08-26T19:23:24Z

@bors r+ rollup

bors · 2025-08-26T19:23:27Z

📌 Commit a8e9ca1 has been approved by jdonszelmann

It is now in the queue for this repository.

Rollup of 9 pull requests Successful merges: - #144499 (ci: Begin running ui tests with `rust.debuginfo-level-tests=1`) - #145790 (Improve dist for gnullvm hosts) - #145792 (Use attribute name in message for "outer attr used as inner attr" errors) - #145840 (rustc_codegen_ssa: More comprehensive RISC-V ELF flags) - #145876 (Enable building/disting standard library in stage 0) - #145887 (bootstrap: Don't panic if codegen-backends is set to empty) - #145888 (platform-support: Fix LoongArch32 host column) - #145892 (add a flag to codegen fn attrs for foreign items) - #145901 (Fix typo in comment of library/alloc/src/raw_vec/mod.rs) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #145792 - scrabsha:push-umpytyxunpxq, r=jdonszelmann Use attribute name in message for "outer attr used as inner attr" errors

Rollup of 9 pull requests Successful merges: - rust-lang/rust#144499 (ci: Begin running ui tests with `rust.debuginfo-level-tests=1`) - rust-lang/rust#145790 (Improve dist for gnullvm hosts) - rust-lang/rust#145792 (Use attribute name in message for "outer attr used as inner attr" errors) - rust-lang/rust#145840 (rustc_codegen_ssa: More comprehensive RISC-V ELF flags) - rust-lang/rust#145876 (Enable building/disting standard library in stage 0) - rust-lang/rust#145887 (bootstrap: Don't panic if codegen-backends is set to empty) - rust-lang/rust#145888 (platform-support: Fix LoongArch32 host column) - rust-lang/rust#145892 (add a flag to codegen fn attrs for foreign items) - rust-lang/rust#145901 (Fix typo in comment of library/alloc/src/raw_vec/mod.rs) r? `@ghost` `@rustbot` modify labels: rollup

Port limit attributes to the new attribute parsing infrastructure Doesn't pass tests, to be rebased on rust-lang#145792 which will solve that r? `@fmease`

Port limit attributes to the new attribute parsing infrastructure Doesn't pass tests, to be rebased on rust-lang#145792 which will solve that r? ``@fmease``

Rollup merge of #145819 - jdonszelmann:convert-limits, r=fmease Port limit attributes to the new attribute parsing infrastructure Doesn't pass tests, to be rebased on #145792 which will solve that r? `@fmease`

Rollup of 9 pull requests Successful merges: - rust-lang/rust#144499 (ci: Begin running ui tests with `rust.debuginfo-level-tests=1`) - rust-lang/rust#145790 (Improve dist for gnullvm hosts) - rust-lang/rust#145792 (Use attribute name in message for "outer attr used as inner attr" errors) - rust-lang/rust#145840 (rustc_codegen_ssa: More comprehensive RISC-V ELF flags) - rust-lang/rust#145876 (Enable building/disting standard library in stage 0) - rust-lang/rust#145887 (bootstrap: Don't panic if codegen-backends is set to empty) - rust-lang/rust#145888 (platform-support: Fix LoongArch32 host column) - rust-lang/rust#145892 (add a flag to codegen fn attrs for foreign items) - rust-lang/rust#145901 (Fix typo in comment of library/alloc/src/raw_vec/mod.rs) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned jdonszelmann Aug 23, 2025

rustbot added the A-attributes Area: Attributes (`#[…]`, `#![…]`) label Aug 23, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 23, 2025

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 24, 2025

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 24, 2025

jdonszelmann mentioned this pull request Aug 24, 2025

Port limit attributes to the new attribute parsing infrastructure #145819

Merged

scrabsha force-pushed the push-umpytyxunpxq branch from d51a8c0 to 0238462 Compare August 24, 2025 17:46

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 24, 2025

scrabsha mentioned this pull request Aug 24, 2025

Use AcceptContext in AttribueParser::check_target #145826

Merged

This comment has been minimized.

Sign in to view

scrabsha force-pushed the push-umpytyxunpxq branch from 0238462 to 63d3dd8 Compare August 24, 2025 18:53

jdonszelmann reviewed Aug 25, 2025

View reviewed changes

compiler/rustc_passes/messages.ftl Outdated Show resolved Hide resolved

tests/ui/lint/linker-warning.stderr Outdated Show resolved Hide resolved

Use attribute name in message for "outer attr used as inner attr" errors

a8e9ca1

scrabsha force-pushed the push-umpytyxunpxq branch from 63d3dd8 to a8e9ca1 Compare August 25, 2025 19:31

scrabsha commented Aug 25, 2025

View reviewed changes

compiler/rustc_passes/src/check_attr.rs Show resolved Hide resolved

scrabsha commented Aug 25, 2025

View reviewed changes

jdonszelmann approved these changes Aug 26, 2025

View reviewed changes

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 26, 2025

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 26, 2025

samueltardieu mentioned this pull request Aug 26, 2025

Rollup of 9 pull requests #145906

Merged

bors merged commit fbf247d into rust-lang:master Aug 27, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 27, 2025

rust-timer added a commit that referenced this pull request Aug 27, 2025

Unrolled build for #145792

09b5fbd

Rollup merge of #145792 - scrabsha:push-umpytyxunpxq, r=jdonszelmann Use attribute name in message for "outer attr used as inner attr" errors

scrabsha deleted the push-umpytyxunpxq branch August 27, 2025 07:59

scrabsha mentioned this pull request Sep 1, 2025

Fix message style for "crate-level attr used as outer attr" and "invalid custom_mir" errors #146080

Closed

Uh oh!

Conversation

scrabsha commented Aug 23, 2025

Uh oh!

rustbot commented Aug 23, 2025

Uh oh!

rustbot commented Aug 23, 2025

Uh oh!

scrabsha commented Aug 23, 2025

Uh oh!

jdonszelmann commented Aug 24, 2025

Uh oh!

rustbot commented Aug 24, 2025

Uh oh!

rustbot commented Aug 24, 2025

Uh oh!

rustbot commented Aug 24, 2025

Uh oh!

scrabsha commented Aug 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

scrabsha Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

jdonszelmann Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

jdonszelmann left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdonszelmann commented Aug 26, 2025

Uh oh!

bors commented Aug 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

scrabsha commented Aug 24, 2025 •

edited

Loading

jdonszelmann left a comment •

edited by rustbot

Loading