fully deprecate the legacy integral modules by cyrgani · Pull Request #146882 · rust-lang/rust

cyrgani · 2025-09-22T11:58:40Z

This PR implements the last step of #68490: marking the std::u8 etc. modules and the constants in std::f32 and std::f64 (but not the undeprecated consts submodule) as fully deprecated.

Revival of #107587 (cc @tgross35).

Closes: #68490

r? libs-api

BurntSushi · 2025-09-22T12:45:34Z

I'm still kind of meh on these deprecations personally, but we should probably finish what was started.

With that said, I'm strongly opposed to applying #[doc(hidden)] to deprecated items. I'm not sure why you're doing that here. It seems like an obviously bad user experience that only serves to gaslight users. Imagine reading old code, wondering what a function does and then going to look it up in the docs only to find that... it isn't there?

Once the #[doc(hidden)] attributes are removed, I'd be happy to kick off an FCP.

cyrgani · 2025-09-22T13:23:56Z

I've removed the #[doc(hidden] attributes.
Regarding why I added them, it is mostly the feeling that having twelve deprecated modules right on the front page of the std documentation is not a good user experience either.
Also, people who would search the docs for core::u8::MAX would still get u8::MAX as their first search result to find out what the constant means.

BurntSushi · 2025-09-22T13:26:53Z

Regarding why I added them, it is mostly the feeling that having twelve deprecated modules right on the front page of the std documentation is not a good user experience either.

Perhaps! But the solution is definitely not to completely hide them.

Also, people who would search the docs for core::u8::MAX would still get u8::MAX as their first search result to find out what the constant means.

Sure, same thing applies here. I don't know anything about how rustdoc's search result ranking works, but it seems reasonable that it could take deprecation status into account.

BurntSushi · 2025-09-22T13:27:51Z

@rfcbot merge

rust-rfcbot · 2025-09-22T13:27:53Z

Team member @BurntSushi has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

Needed for rust-lang/rust#146882.

…mdev give a better example why `std` modules named like primitives are needed A small update to the `std` `lib.rs` introduction to replace mentions of `std::i32` (never needed) with `std::char` (sometimes needed). Related to rust-lang#146882.

Rollup merge of #147373 - cyrgani:cyrgani-patch-1, r=ibraheemdev give a better example why `std` modules named like primitives are needed A small update to the `std` `lib.rs` introduction to replace mentions of `std::i32` (never needed) with `std::char` (sometimes needed). Related to #146882.

…mdev give a better example why `std` modules named like primitives are needed A small update to the `std` `lib.rs` introduction to replace mentions of `std::i32` (never needed) with `std::char` (sometimes needed). Related to rust-lang#146882.

give a better example why `std` modules named like primitives are needed A small update to the `std` `lib.rs` introduction to replace mentions of `std::i32` (never needed) with `std::char` (sometimes needed). Related to rust-lang/rust#146882.

rust-rfcbot · 2025-10-15T15:28:40Z

🔔 This is now entering its final comment period, as per the review above. 🔔

RalfJung · 2025-10-23T08:08:27Z

marking the std::u8 etc. modules as fully deprecated and as #[doc(hidden)].

It seems the doc(hidden) part got removed; please also update the PR description since it will permanently become part pf the git history.

matthiasg · 2025-10-26T12:25:26Z

I've removed the #[doc(hidden] attributes. Regarding why I added them, it is mostly the feeling that having twelve deprecated modules right on the front page of the std documentation is not a good user experience either.

This might be a general area of improvement of Rust Docs. Move older deprecated modules/structs/etc into a hidden state (if anything was deprecated an automatic mention at top to 'optionally include them'), search would not be affected of course.

When I say 'older' I literally mean code deprecated eg 12 months ago based on publishing date.

Needed for rust-lang#146882.

rustbot · 2025-12-25T12:51:51Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rustbot · 2025-12-25T14:02:41Z

The Miri subtree was changed

cc @rust-lang/miri

rustbot · 2025-12-25T14:44:26Z

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

rustbot · 2025-12-25T18:38:47Z

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

rustbot · 2025-12-25T22:08:50Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

RalfJung · 2025-12-26T17:41:50Z

src/tools/miri/tests/pass/float.rs

    macro_rules! fixed_atan2_cases{
        ($float_type:ident) => {{
            use std::$float_type::consts::{PI, FRAC_PI_2, FRAC_PI_4};
-            use $float_type::{INFINITY, NEG_INFINITY};


Does useing these no longer work? I'd prefer not to make the tests below more verbose with all these long paths.

Unfortunately, there is no good way for this. I added two constants instead for now, but I'm not happy with that solution either.

Needed for rust-lang/rust#146882.

rustbot assigned BurntSushi Sep 22, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 22, 2025

cyrgani added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 22, 2025

This comment has been minimized.

Sign in to view

cyrgani force-pushed the deprecate-legacy-int-mods branch from 438bfa3 to 7fa9c6a Compare September 22, 2025 13:11

This comment has been minimized.

Sign in to view

cyrgani changed the title ~~fully deprecate and hide the legacy integral modules~~ fully deprecate the legacy integral modules Sep 22, 2025

rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Sep 22, 2025

cyrgani mentioned this pull request Sep 22, 2025

Remove usage of the to-be-deprecated core::f32, core::f64 items rust-lang/compiler-builtins#1022

Merged

tgross35 pushed a commit to rust-lang/compiler-builtins that referenced this pull request Sep 22, 2025

Remove usage of the to-be-deprecated core::f32, core::f64 items

829c4f8

Needed for rust-lang/rust#146882.

cyrgani mentioned this pull request Oct 5, 2025

give a better example why std modules named like primitives are needed #147373

Merged

rust-rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Oct 15, 2025

rust-rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Oct 25, 2025

tgross35 mentioned this pull request Dec 3, 2025

Formally deprecate numeric consts modules #149249

Open

tgross35 pushed a commit to tgross35/rust that referenced this pull request Dec 3, 2025

Remove usage of the to-be-deprecated core::f32, core::f64 items

ee1b36a

Needed for rust-lang#146882.

rust-cloud-vms bot force-pushed the deprecate-legacy-int-mods branch from 7fa9c6a to d7984d2 Compare December 25, 2025 12:51

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the deprecate-legacy-int-mods branch from d7984d2 to 6ae2c73 Compare December 25, 2025 13:08

rustbot added the A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) label Dec 25, 2025

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the deprecate-legacy-int-mods branch 2 times, most recently from aab59e6 to ddd855f Compare December 25, 2025 14:02

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the deprecate-legacy-int-mods branch from ddd855f to 5ecd92b Compare December 25, 2025 14:44

rustbot added the T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. label Dec 25, 2025

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the deprecate-legacy-int-mods branch from 5ecd92b to 6002eba Compare December 25, 2025 18:38

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the deprecate-legacy-int-mods branch from 6002eba to e7e27f5 Compare December 25, 2025 20:58

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the deprecate-legacy-int-mods branch from e7e27f5 to bde8767 Compare December 25, 2025 22:08

rustbot added the T-clippy Relevant to the Clippy team. label Dec 25, 2025

RalfJung reviewed Dec 26, 2025

View reviewed changes

fully deprecate the legacy integral modules

1767156

rust-cloud-vms bot force-pushed the deprecate-legacy-int-mods branch from bde8767 to 1767156 Compare December 26, 2025 18:33

apiraino removed the to-announce Announce this issue on triage meeting label Jan 29, 2026

tgross35 pushed a commit to rust-lang/compiler-builtins that referenced this pull request Jan 31, 2026

Remove usage of the to-be-deprecated core::f32, core::f64 items

057dc7f

Needed for rust-lang/rust#146882.

Uh oh!

Conversation

cyrgani commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

BurntSushi commented Sep 22, 2025

Uh oh!

This comment has been minimized.

cyrgani commented Sep 22, 2025

Uh oh!

BurntSushi commented Sep 22, 2025

Uh oh!

BurntSushi commented Sep 22, 2025

Uh oh!

rust-rfcbot commented Sep 22, 2025 • edited by Amanieu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-rfcbot commented Oct 15, 2025

Uh oh!

RalfJung commented Oct 23, 2025

Uh oh!

matthiasg commented Oct 26, 2025

Uh oh!

rustbot commented Dec 25, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rustbot commented Dec 25, 2025

Uh oh!

This comment has been minimized.

rustbot commented Dec 25, 2025

Uh oh!

This comment has been minimized.

rustbot commented Dec 25, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rustbot commented Dec 25, 2025

Uh oh!

RalfJung Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

cyrgani Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

cyrgani commented Sep 22, 2025 •

edited

Loading

rust-rfcbot commented Sep 22, 2025 •

edited by Amanieu

Loading