sort attribute targets for more consistent error messages#147445
sort attribute targets for more consistent error messages#147445bors merged 1 commit intorust-lang:masterfrom
Conversation
|
This PR modifies |
rustbot
added
A-attributes
|
|
jdonszelmann
force-pushed
the
sort-targets
branch
from
21fbaf9 to
6c7cdcd
Compare
This comment has been minimized.
This comment has been minimized.
|
(range diff is very useful here, neat) |
|
☔ The latest upstream changes (presumably #147449) made this pull request unmergeable. Please resolve the merge conflicts. |
jdonszelmann
force-pushed
the
sort-targets
branch
from
6c7cdcd to
1dbe831
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors delegate=@JonathanBrouwer |
|
✌️ @JonathanBrouwer, you can now approve this pull request! If @WaffleLapkin told you to " |
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup |
Rollup of 5 pull requests Successful merges: - #146385 (rustdoc-search: redesign throbber to be less distracting) - #147390 (Use globals instead of metadata for std::autodiff) - #147445 (sort attribute targets for more consistent error messages) - #147448 (collect-license-metadata: update submodules before running) - #147451 (fix panic with extra-const-ub-checks) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #147445 - jdonszelmann:sort-targets, r=JonathanBrouwer sort attribute targets for more consistent error messages In this PR I noticed that we don't sort attribute targets, so a rather trivial change to the source changed the ordering in an error message even though its meaning stayed the same. See: #147418 (comment) I think sorting might be a good thing to do in general. I also prefer it when reading error messages. Quite a few tests changed, but not in meaning, only sorting order obviously. r? `@jieyouxu`
6 participants
In this PR I noticed that we don't sort attribute targets, so a rather trivial change to the source changed the ordering in an error message even though its meaning stayed the same.
See: #147418 (comment)
I think sorting might be a good thing to do in general. I also prefer it when reading error messages. Quite a few tests changed, but not in meaning, only sorting order obviously.
r? @jieyouxu