Fix target list of `link_section` by JonathanBrouwer · Pull Request #147418 · rust-lang/rust

JonathanBrouwer · 2025-10-06T21:23:16Z

Fixes #147411 (comment)

r? @jdonszelmann
@rustbot beta-nominate T-compiler

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

rustbot · 2025-10-06T21:23:19Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

JonathanBrouwer · 2025-10-06T21:24:12Z

@rustbot label beta-nominated

JonathanBrouwer · 2025-10-06T21:25:23Z

Actually, would like to add a regression test for this
@rustbot author

rustbot · 2025-10-06T21:25:27Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

compiler/rustc_attr_parsing/src/attributes/link_attrs.rs

JonathanBrouwer · 2025-10-07T06:24:33Z

Actually, would like to add a regression test for this
@rustbot author

I commented that above already, that's why it's waiting on author :)

jieyouxu · 2025-10-07T06:25:48Z

Oh sorry, I managed to read every other comment but missed that specific comment 😂

JonathanBrouwer · 2025-10-07T07:42:02Z

@rustbot ready
r? @jieyouxu (feel free to assign back to Jana if you don't feel like reviewing this)

rustbot · 2025-10-07T07:42:08Z

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

jdonszelmann · 2025-10-07T14:30:53Z

tests/ui/attributes/attr-on-mac-call.stderr

   |
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
-   = help: `#[link_section]` can be applied to statics and functions
+   = help: `#[link_section]` can be applied to functions and statics


maybe we should sort this list in the future, so this doesn't happen

better for incremental too actually hehe

jdonszelmann · 2025-10-07T14:35:22Z

yea this seems like something we missed during migration. Looking good, apart from link name on traits which I agree is weird
@bors r+

bors · 2025-10-07T14:35:26Z

📌 Commit 1589c6c has been approved by jdonszelmann

It is now in the queue for this repository.

jdonszelmann · 2025-10-07T14:46:05Z

@bors r- I guess the beta backport first should be accepted

jdonszelmann · 2025-10-07T14:46:34Z

r=me when it does

jdonszelmann · 2025-10-07T14:49:37Z

@bors r+ #t-compiler/backports > #147418: beta-nominated @ 💬

bors · 2025-10-07T14:49:40Z

📌 Commit 1589c6c has been approved by jdonszelmann

It is now in the queue for this repository.

Rollup of 7 pull requests Successful merges: - #145943 (stdlib docs: document lifetime extension for `format_args!`'s arguments) - #147243 (cmse: disallow `impl Trait` in `cmse-nonsecure-entry` return types) - #147402 ([rustdoc] Don't serialize & deserialize data that doesn't go OTW) - #147418 (Fix target list of `link_section`) - #147429 (Print tip for human error format in runtest) - #147441 (Fix comments error for Provenance impls) - #147442 (c-variadic: fix thir-print for `...` without a pattern) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #147418 - JonathanBrouwer:link_section_targets, r=jdonszelmann Fix target list of `link_section` Fixes #147411 (comment) r? `@jdonszelmann` `@rustbot` beta-nominate T-compiler

…hanBrouwer sort attribute targets for more consistent error messages In this PR I noticed that we don't sort attribute targets, so a rather trivial change to the source changed the ordering in an error message even though its meaning stayed the same. See: rust-lang#147418 (comment) I think sorting might be a good thing to do in general. I also prefer it when reading error messages. Quite a few tests changed, but not in meaning, only sorting order obviously. r? `@jieyouxu`

Rollup merge of #147445 - jdonszelmann:sort-targets, r=JonathanBrouwer sort attribute targets for more consistent error messages In this PR I noticed that we don't sort attribute targets, so a rather trivial change to the source changed the ordering in an error message even though its meaning stayed the same. See: #147418 (comment) I think sorting might be a good thing to do in general. I also prefer it when reading error messages. Quite a few tests changed, but not in meaning, only sorting order obviously. r? `@jieyouxu`

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#145943 (stdlib docs: document lifetime extension for `format_args!`'s arguments) - rust-lang#147243 (cmse: disallow `impl Trait` in `cmse-nonsecure-entry` return types) - rust-lang#147402 ([rustdoc] Don't serialize & deserialize data that doesn't go OTW) - rust-lang#147418 (Fix target list of `link_section`) - rust-lang#147429 (Print tip for human error format in runtest) - rust-lang#147441 (Fix comments error for Provenance impls) - rust-lang#147442 (c-variadic: fix thir-print for `...` without a pattern) r? `@ghost` `@rustbot` modify labels: rollup

apiraino · 2025-10-09T14:12:33Z

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels handled by them.

@rustbot label +beta-accepted

[beta] backports - Don't normalize higher-ranked assumptions if they're not used #147299 - Fix target list of `link_section` #147418 - bootstrap: add `Builder::rustc_cmd` that includes the lib path #147419 - Update LLVM to 21.1.2 #146953 - Remove the temporary directory when a check ends -- part of #147518 r? cuviper

Fix target list of link_section

4787834

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2025

rustbot assigned jdonszelmann Oct 6, 2025

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 6, 2025

This comment was marked as outdated.

Sign in to view

rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 6, 2025

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2025

JonathanBrouwer commented Oct 6, 2025

View reviewed changes

compiler/rustc_attr_parsing/src/attributes/link_attrs.rs Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

JonathanBrouwer mentioned this pull request Oct 7, 2025

Narrow down the list of targets #[link_section] and other link attributes can be applied to #147432

Closed

Add regression test for link_section targets

1589c6c

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 7, 2025

rustbot assigned jieyouxu and unassigned jdonszelmann Oct 7, 2025

jdonszelmann reviewed Oct 7, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2025

jdonszelmann assigned jdonszelmann and unassigned jieyouxu Oct 7, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 7, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 7, 2025

jdonszelmann mentioned this pull request Oct 7, 2025

sort attribute targets for more consistent error messages #147445

Merged

matthiaskrgr mentioned this pull request Oct 7, 2025

Rollup of 7 pull requests #147449

Merged

bors merged commit 0072d0c into rust-lang:master Oct 7, 2025
10 checks passed

rustbot added this to the 1.92.0 milestone Oct 7, 2025

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 9, 2025

cuviper mentioned this pull request Oct 10, 2025

[beta] backports #147571

Merged

cuviper modified the milestones: 1.92.0, 1.91.0 Oct 11, 2025

cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 11, 2025

Uh oh!

Conversation

JonathanBrouwer commented Oct 6, 2025

Uh oh!

rustbot commented Oct 6, 2025

Uh oh!

This comment was marked as outdated.

JonathanBrouwer commented Oct 6, 2025

Uh oh!

JonathanBrouwer commented Oct 6, 2025

Uh oh!

rustbot commented Oct 6, 2025

Uh oh!

Uh oh!

This comment was marked as resolved.

JonathanBrouwer commented Oct 7, 2025

Uh oh!

jieyouxu commented Oct 7, 2025

Uh oh!

JonathanBrouwer commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 7, 2025

Uh oh!

jdonszelmann Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

jdonszelmann Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

jdonszelmann Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

jdonszelmann commented Oct 7, 2025

Uh oh!

bors commented Oct 7, 2025

Uh oh!

jdonszelmann commented Oct 7, 2025

Uh oh!

jdonszelmann commented Oct 7, 2025

Uh oh!

jdonszelmann commented Oct 7, 2025

Uh oh!

bors commented Oct 7, 2025

Uh oh!

Uh oh!

apiraino commented Oct 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

JonathanBrouwer commented Oct 7, 2025 •

edited

Loading