Rollup of 7 pull requests by matthiaskrgr · Pull Request #147449 · rust-lang/rust

matthiaskrgr · 2025-10-07T15:42:16Z

Successful merges:

stdlib docs: document lifetime extension for format_args!'s arguments #145943 (stdlib docs: document lifetime extension for format_args!'s arguments)
cmse: disallow impl Trait in cmse-nonsecure-entry return types #147243 (cmse: disallow impl Trait in cmse-nonsecure-entry return types)
[rustdoc] Don't serialize & deserialize data that doesn't go OTW #147402 ([rustdoc] Don't serialize & deserialize data that doesn't go OTW)
Fix target list of link_section #147418 (Fix target list of link_section)
Print tip for human error format in runtest #147429 (Print tip for human error format in runtest)
Fix comments error for Provenance impls #147441 (Fix comments error for Provenance impls)
c-variadic: fix thir-print for ... without a pattern #147442 (c-variadic: fix thir-print for ... without a pattern)

r? @ghost
@rustbot modify labels: rollup

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

…joboet stdlib docs: document lifetime extension for `format_args!`'s arguments Since rust-lang#140748 is stable and rust-lang#92698 is closed, the section about `format_args!`'s argument lifetime limitation is outdated. I've updated it to point to the Reference docs, which will specify lifetime extension rules for builtin macros once rust-lang/reference#1980 or equivalent is merged. I've also taken the liberty of updating one of the doctests to assign the result of `format_args!` to a variable, both to provide an example and because I think it reads a little better. r? `@m-ou-se`

…=davidtwco cmse: disallow `impl Trait` in `cmse-nonsecure-entry` return types tracking issue: rust-lang#75835 fixes rust-lang#147242 Refactors some logic to be more robust in the future, and then disallows `impl Trait` as a return type for the cmse ABIs. The `is_valid_cmse_output_layout` function disallows `union` values like before. That is not entirely correct, but preserves the current behavior. Some additional logic is needed for `union` values (and any types where parts may be uninitialized) that I'll tackle in a later PR. can be reviewed commit-by-commit. r? types

…/impl-display, r=GuillaumeGomez [rustdoc] Don't serialize & deserialize data that doesn't go OTW `@GuillaumeGomez`

…ts, r=jdonszelmann Fix target list of `link_section` Fixes rust-lang#147411 (comment) r? `@jdonszelmann` `@rustbot` beta-nominate T-compiler

…fmease Print tip for human error format in runtest When working on rust-lang#147354, spent some time to figure out that there is `//~ ERROR` left on test file, this PR will give a better error message for this scenario.

…ents, r=RalfJung Fix comments error for Provenance impls r? `@RalfJung`

…r=fmease c-variadic: fix thir-print for `...` without a pattern tracking issue: rust-lang#44930 fixes rust-lang#147409 r? `@fmease`

matthiaskrgr · 2025-10-07T15:42:43Z

@bors r+ rollup=never p=5

bors · 2025-10-07T15:42:46Z

📌 Commit 5f03328 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-10-07T17:38:00Z

⌛ Testing commit 5f03328 with merge d62f33a...

bors · 2025-10-07T20:46:05Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing d62f33a to master...

rust-timer · 2025-10-07T20:48:09Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#145943	stdlib docs: document lifetime extension for `format_args!`…	`66f7eceb5fd41f03223033fc8dd975225cb69e49` (link)
#147243	cmse: disallow `impl Trait` in `cmse-nonsecure-entry` retur…	`f25d004980009b260b138db4e7320618905ab5de` (link)
#147402	[rustdoc] Don't serialize & deserialize data that doesn't g…	`dc88e990da741641d7bf75d2719b0d4f6c5135b7` (link)
#147418	Fix target list of `link_section`	`b454e60ba42877591cc031117796ba4f0fc6e38b` (link)
#147429	Print tip for human error format in runtest	`a46ae00fb06cff8b5d12a39ea0a8f9a351c00046` (link)
#147441	Fix comments error for Provenance impls	`06eec823d64532612e836828deafa78dc857cc71` (link)
#147442	c-variadic: fix thir-print for `...` without a pattern	`c5ecf0401359b77e8560fced713d33239730b0b3` (link)

previous master: fed46ffd50

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-10-07T20:48:41Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing fed46ff (parent) -> d62f33a (this PR)

Test differences

Show 76 test diffs

Stage 1

[ui] tests/ui/thir-print/c-variadic.rs: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/thir-print/c-variadic.rs: [missing] -> pass (J0)

Additionally, 74 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard d62f33a7c684473bf6efa2f3ff57093bb8986141 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-apple: 8340.7s -> 7332.3s (-12.1%)
pr-check-1: 1375.2s -> 1530.2s (11.3%)
i686-gnu-1: 7333.4s -> 8130.9s (10.9%)
x86_64-gnu-llvm-20: 2466.6s -> 2703.2s (9.6%)
x86_64-gnu-tools: 3398.6s -> 3723.6s (9.6%)
x86_64-msvc-ext2: 5678.4s -> 6153.0s (8.4%)
dist-x86_64-apple: 7078.3s -> 7610.1s (7.5%)
dist-various-1: 4179.8s -> 3870.4s (-7.4%)
aarch64-msvc-1: 7484.8s -> 6976.5s (-6.8%)
i686-gnu-2: 5739.6s -> 6076.9s (5.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-10-07T22:53:26Z

Finished benchmarking commit (d62f33a): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.3%, -0.1%]	8
Improvements ✅ (secondary)	-0.5%	[-0.5%, -0.5%]	1
All ❌✅ (primary)	-0.2%	[-0.3%, -0.1%]	8

Max RSS (memory usage)

Results (primary -0.3%, secondary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.1%, 1.9%]	3
Regressions ❌ (secondary)	2.4%	[2.4%, 2.4%]	1
Improvements ✅ (primary)	-5.8%	[-5.8%, -5.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-5.8%, 1.9%]	4

Cycles

Results (primary -5.0%, secondary -1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-5.0%	[-5.0%, -5.0%]	1
Improvements ✅ (secondary)	-1.0%	[-1.0%, -1.0%]	1
All ❌✅ (primary)	-5.0%	[-5.0%, -5.0%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.165s -> 470.014s (-0.88%)
Artifact size: 388.38 MiB -> 388.40 MiB (0.00%)

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#145943 (stdlib docs: document lifetime extension for `format_args!`'s arguments) - rust-lang#147243 (cmse: disallow `impl Trait` in `cmse-nonsecure-entry` return types) - rust-lang#147402 ([rustdoc] Don't serialize & deserialize data that doesn't go OTW) - rust-lang#147418 (Fix target list of `link_section`) - rust-lang#147429 (Print tip for human error format in runtest) - rust-lang#147441 (Fix comments error for Provenance impls) - rust-lang#147442 (c-variadic: fix thir-print for `...` without a pattern) r? `@ghost` `@rustbot` modify labels: rollup

dianne and others added 18 commits August 27, 2025 12:06

document lifetime extension for format_args!'s arguments

ee9986b

cmse: use BackendRepr to determine valid 64-bit return types

a7bd285

Fix target list of link_section

4787834

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

Add regression test for link_section targets

1589c6c

avoid in-process serializing&deserializing

eb8d87d

nicer serde impls

978ab7c

Print tip for human error format when check fail

f8ee9f0

move serde impls to separate module

c5ab530

Fix comments error for CtfeProvenance

713e0dd

c-variadic: fix thir-print for ... without a pattern

0a3f1d5

cmse: disallow impl Trait in cmse-nonsecure-entry return types

fbdc685

Rollup merge of rust-lang#147402 - yotamofek:wip/rustdoc/search_index…

4461dd9

…/impl-display, r=GuillaumeGomez [rustdoc] Don't serialize & deserialize data that doesn't go OTW `@GuillaumeGomez`

Rollup merge of rust-lang#147418 - JonathanBrouwer:link_section_targe…

0072d0c

…ts, r=jdonszelmann Fix target list of `link_section` Fixes rust-lang#147411 (comment) r? `@jdonszelmann` `@rustbot` beta-nominate T-compiler

Rollup merge of rust-lang#147441 - chenyukang:yukang-trivial-fix-comm…

883032b

…ents, r=RalfJung Fix comments error for Provenance impls r? `@RalfJung`

Rollup merge of rust-lang#147442 - folkertdev:thir-print-c-variadic, …

5f03328

…r=fmease c-variadic: fix thir-print for `...` without a pattern tracking issue: rust-lang#44930 fixes rust-lang#147409 r? `@fmease`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 7, 2025

bors merged commit d62f33a into rust-lang:master Oct 7, 2025
11 checks passed

rustbot added this to the 1.92.0 milestone Oct 7, 2025

bors mentioned this pull request Oct 7, 2025

sort attribute targets for more consistent error messages #147445

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests#147449

Rollup of 7 pull requests#147449
bors merged 18 commits intorust-lang:masterfrom
matthiaskrgr:rollup-njyi5yr

matthiaskrgr commented Oct 7, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Oct 7, 2025

Uh oh!

bors commented Oct 7, 2025

Uh oh!

bors commented Oct 7, 2025

Uh oh!

bors commented Oct 7, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Oct 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

matthiaskrgr commented Oct 7, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Oct 7, 2025

Uh oh!

bors commented Oct 7, 2025

Uh oh!

bors commented Oct 7, 2025

Uh oh!

bors commented Oct 7, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Oct 7, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

matthiaskrgr commented Oct 7, 2025 •

edited by rustbot

Loading