Avoid redundant UB check in RangeFrom slice indexing#147620
Avoid redundant UB check in RangeFrom slice indexing#147620bors merged 1 commit intorust-lang:masterfrom
Conversation
|
@bors r+ rollup=iffy |
…ottmcm Avoid redundant UB check in RangeFrom slice indexing I noticed this while picking through the IR we generate for rust-lang#134938. I think we just forgot to apply this trick to `RangeFrom`?
Rollup of 11 pull requests Successful merges: - #146277 (Enable `u64` limbs in `core::num::bignum`) - #146976 (constify basic Clone impls) - #147249 (Do two passes of `handle_opaque_type_uses_next`) - #147266 (fix 2 search graph bugs) - #147468 (Implement fs api set_times and set_times_nofollow) - #147497 (`proc_macro` cleanups (3/N)) - #147594 (std: implement `pal::os::exit` for VEXos) - #147596 (Adjust the Arm targets in CI to reflect latest changes) - #147607 (GVN: Invalidate derefs at loop headers) - #147620 (Avoid redundant UB check in RangeFrom slice indexing) - #147647 (Hide vendoring and copyright in GHA group) r? `@ghost` `@rustbot` modify labels: rollup
…ottmcm Avoid redundant UB check in RangeFrom slice indexing I noticed this while picking through the IR we generate for rust-lang#134938. I think we just forgot to apply this trick to `RangeFrom`?
Rollup of 12 pull requests Successful merges: - #146277 (Enable `u64` limbs in `core::num::bignum`) - #146976 (constify basic Clone impls) - #147249 (Do two passes of `handle_opaque_type_uses_next`) - #147266 (fix 2 search graph bugs) - #147497 (`proc_macro` cleanups (3/N)) - #147546 (Suppress unused_parens for labeled break) - #147548 (Fix ICE for never pattern as closure parameters) - #147594 (std: implement `pal::os::exit` for VEXos) - #147596 (Adjust the Arm targets in CI to reflect latest changes) - #147607 (GVN: Invalidate derefs at loop headers) - #147620 (Avoid redundant UB check in RangeFrom slice indexing) - #147647 (Hide vendoring and copyright in GHA group) r? `@ghost` `@rustbot` modify labels: rollup
|
@rust-timer build 55b1ddf |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (55b1ddf): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 2.6%, secondary -3.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -0.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.1%, secondary -0.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 475.635s -> 475.478s (-0.03%) |
…ottmcm Avoid redundant UB check in RangeFrom slice indexing I noticed this while picking through the IR we generate for rust-lang#134938. I think we just forgot to apply this trick to `RangeFrom`?
Rollup of 12 pull requests Successful merges: - rust-lang#146277 (Enable `u64` limbs in `core::num::bignum`) - rust-lang#146976 (constify basic Clone impls) - rust-lang#147249 (Do two passes of `handle_opaque_type_uses_next`) - rust-lang#147266 (fix 2 search graph bugs) - rust-lang#147497 (`proc_macro` cleanups (3/N)) - rust-lang#147546 (Suppress unused_parens for labeled break) - rust-lang#147548 (Fix ICE for never pattern as closure parameters) - rust-lang#147594 (std: implement `pal::os::exit` for VEXos) - rust-lang#147596 (Adjust the Arm targets in CI to reflect latest changes) - rust-lang#147607 (GVN: Invalidate derefs at loop headers) - rust-lang#147620 (Avoid redundant UB check in RangeFrom slice indexing) - rust-lang#147647 (Hide vendoring and copyright in GHA group) r? `@ghost` `@rustbot` modify labels: rollup
I noticed this while picking through the IR we generate for #134938. I think we just forgot to apply this trick to
RangeFrom?