Revert constification of Borrow and Deref for Cow due to inference failure#148016
Merged
bors merged 2 commits intorust-lang:masterfrom Oct 24, 2025
Merged
Revert constification of Borrow and Deref for Cow due to inference failure#148016bors merged 2 commits intorust-lang:masterfrom
Borrow and Deref for Cow due to inference failure#148016bors merged 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
Contributor
Author
|
@rustbot blocked |
rustbot
added
S-blocked
theemathas
added
the
beta-nominated
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
clarfonthey
force-pushed
the
const-convert-revert-2
branch
from
72c9876 to
ebd5bea
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
How about adding the minimized regression test? |
Contributor
Author
|
Right, I wasn't sure what the timing was for the beta backport but I can add one later today. |
Contributor
Author
|
Added a simple regression test which seems to both pass with this fix, and fail without it. No idea if this is best as a UI test in its current location or not, so, feel free to suggest changes if you have opinions about it. Also made a separate commit in case the backport timing means we want to merge without the test bikeshedding sooner. Also to clarify, when I meant that a crater run is necessary, I mean that there might have been other inference issues caused by trait constification that didn't surface due to the existence of these issues, so, it's worth double-checking after everything is merged. Not sure if this specific issue is fully resolved after this PR or not. |
Member
Collaborator
bors
added
S-waiting-on-bors
rustbot
added
the
beta-accepted
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Oct 23, 2025
…, r=cuviper Revert constification of `Borrow` and `Deref for Cow` due to inference failure Reported issue: rust-lang#147964 Original PR: rust-lang#145279 Previous revert: rust-lang#148011 `const Borrow`/`Deref` tracking issue: rust-lang#143773 Should have additional crater run to verify this fixes the issue. Since other PR is in the queue, this will need to be rebased after that merges. Also will want a beta nomination.
bors
added a commit
that referenced
this pull request
Oct 24, 2025
Rollup of 5 pull requests Successful merges: - #148016 (Revert constification of `Borrow` and `Deref for Cow` due to inference failure) - #148021 ([rustdoc] Simplify module rendering and HTML tags handling) - #148039 (Add myself to the review rotation) - #148042 (test(frontmatter): Cover spaces between infostring parts) - #148054 (Streamline iterator chaining when computing successors.) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 24, 2025
Rollup merge of #148016 - clarfonthey:const-convert-revert-2, r=cuviper Revert constification of `Borrow` and `Deref for Cow` due to inference failure Reported issue: #147964 Original PR: #145279 Previous revert: #148011 `const Borrow`/`Deref` tracking issue: #143773 Should have additional crater run to verify this fixes the issue. Since other PR is in the queue, this will need to be rebased after that merges. Also will want a beta nomination.
Member
|
Bors hasn't noticed that this was merged. @bors r- |
bors
added
S-waiting-on-author
Merged
cuviper
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Oct 25, 2025
[beta] backports - Revert constification of `AsRef for Cow` due to inference failure #148011 - Revert constification of `Borrow` and `Deref for Cow` due to inference failure #148016 - Revert "fix: Filter suggestion parts that match existing code" #148043 - Revert "feat: implement `hash_map!` macro" #148049 - fix panic when rustc tries to reduce intermediate filenames len with utf8 #148018 r? cuviper
bors
added a commit
that referenced
this pull request
Oct 25, 2025
[beta] backports - Revert constification of `AsRef for Cow` due to inference failure #148011 - Revert constification of `Borrow` and `Deref for Cow` due to inference failure #148016 - Revert "fix: Filter suggestion parts that match existing code" #148043 - Revert "feat: implement `hash_map!` macro" #148049 - fix panic when rustc tries to reduce intermediate filenames len with utf8 #148018 r? cuviper
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
…, r=cuviper Revert constification of `Borrow` and `Deref for Cow` due to inference failure Reported issue: rust-lang#147964 Original PR: rust-lang#145279 Previous revert: rust-lang#148011 `const Borrow`/`Deref` tracking issue: rust-lang#143773 Should have additional crater run to verify this fixes the issue. Since other PR is in the queue, this will need to be rebased after that merges. Also will want a beta nomination.
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
Rollup of 5 pull requests Successful merges: - rust-lang#148016 (Revert constification of `Borrow` and `Deref for Cow` due to inference failure) - rust-lang#148021 ([rustdoc] Simplify module rendering and HTML tags handling) - rust-lang#148039 (Add myself to the review rotation) - rust-lang#148042 (test(frontmatter): Cover spaces between infostring parts) - rust-lang#148054 (Streamline iterator chaining when computing successors.) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported issue: #147964
Original PR: #145279
Previous revert: #148011
const Borrow/Dereftracking issue: #143773Should have additional crater run to verify this fixes the issue.
Since other PR is in the queue, this will need to be rebased after that merges. Also will want a beta nomination.