Skip to content

Port some attributes to the attr parser#152212

Open
Ozzy1423 wants to merge 3 commits intorust-lang:mainfrom
Ozzy1423:three-attrs
Open

Port some attributes to the attr parser#152212
Ozzy1423 wants to merge 3 commits intorust-lang:mainfrom
Ozzy1423:three-attrs

Conversation

@Ozzy1423
Copy link
Contributor

@Ozzy1423 Ozzy1423 commented Feb 6, 2026

Tracking issue: #131229

r? @JonathanBrouwer

@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2026

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 6, 2026
@JonathanBrouwer
Copy link
Contributor

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 6, 2026

📌 Commit 170747d has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2026
rust-bors bot pushed a commit that referenced this pull request Feb 6, 2026
…uwer

Rollup of 13 pull requests

Successful merges:

 - #152191 (Convert to inline diagnostics in `rustc_hir_analysis`)
 - #149329 (Mark match arms in try and for as being from desugarings.)
 - #151474 (Minor structural improvements)
 - #152107 (Convert to inline diagnostics in `rustc_borrowck`)
 - #152117 (Convert to inline diagnostics in `rustc_trait_selection`)
 - #152136 (Consolidate type const checks on `tcx.is_type_const`)
 - #152140 (Hard code the error code registry for custom drivers)
 - #152155 (Fix typos in riscv64a23-unknown-linux-gnu.md)
 - #152170 (Port `rustc_effective_visibility` to the new attribute parser)
 - #152182 (update compiler stable backport zulip msg)
 - #152184 (Port rustc_abi to the attribute parser)
 - #152195 (update openmp/offload builds to LLVM 22, Part 1)
 - #152202 (chore: clearify tidy's error message)

Failed merges:

 - #151744 (fix refining_impl_trait suggestion with return_type_notation)
 - #152212 (Port some attributes to the attr parser)
@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 6, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 6, 2026

☔ The latest upstream changes (presumably #152213) made this pull request unmergeable. Please resolve the merge conflicts.

This pull request was unapproved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants