Rollup of 13 pull requests#152213
Merged
rust-bors[bot] merged 32 commits intorust-lang:mainfrom Feb 6, 2026
Merged
Conversation
It contains the `Cursor` type and an `impl Cursor` block with a few methods. But there is a larger `impl Cursor` block in the crate root. The only other thing in the `cursor` module is the simple `FrontmatterAllowed` type. So this commit just moves everything in the `cursor` module (which isn't much) into the crate root.
Every diagnostic struct in `rustc_parse` is in the `errors` module, except for `ForbiddenLetReason` and `MisspelledKw`. There's no good reason for this, and presumably it is just an accidental inconsistency. This commit moves them into `errors`.
From the `parser` module to the `errors` module, which is where most of its uses are. This means the `errors` module no longer depends on the `parser` module, removing a cyclic dependency between the two modules.
And move try_find_description to rustc_errors::codes.
…is, r=jdonszelmann Convert to inline diagnostics in `rustc_hir_analysis` For rust-lang#151366 r? @jdonszelmann
Mark match arms in try and for as being from desugarings. Some of the arms created by these desugarings have an expression which isn't marked as coming from the desugaring. e.g. try generates `Continue(val) => val` where the expression has the span of the original parameter (done for diagnostic purposes). Since the arm created just used that span they end up without a desugaring mark unnecessarily. This is only a minor annoyance with some work I'm doing in clippy.
Minor structural improvements Some small cleanups. r? @davidtwco
…r=lqd Convert to inline diagnostics in `rustc_borrowck` For rust-lang#151366 r? @jdonszelmann
…ction2, r=GuillaumeGomez Convert to inline diagnostics in `rustc_trait_selection` For rust-lang#151366 r? @jdonszelmann
…ks, r=BoxyUwU Consolidate type const checks on `tcx.is_type_const` A little bit of cleanup; explanation can be found in the reporting issue. Fixes rust-lang#152124 r? BoxyUwU
…=jdonszelmann Hard code the error code registry for custom drivers And do some cleanups enabled by this.
Fix typos in riscv64a23-unknown-linux-gnu.md
…visibility, r=JonathanBrouwer Port `rustc_effective_visibility` to the new attribute parser r? @JonathanBrouwer
…ckport-zulip-msg, r=jieyouxu update compiler stable backport zulip msg I'd like to update the message when stable backports (for t-compiler) Zulip topics are opened. Stable backports mention the channel i.e. also people who might not have context, example: [#t-compiler/backports > rust-lang#150590: stable-nominated @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/474880-t-compiler.2Fbackports/topic/.23150590.3A.20stable-nominated/near/569989784) Beta backports mention author+reviewer (which fits better), example: [#t-compiler/backports > rust-lang#151896: beta-nominated @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/474880-t-compiler.2Fbackports/topic/.23151896.3A.20beta-nominated/near/571171604) This patch makes the `stable` backport opening message just like the `beta` backport one. Thanks
Port rustc_abi to the attribute parser Tracking issue: rust-lang#131229 This attribute either dumps the abi info for functions (debug arg) or if you put it on a pair of fn ptr's it checks they match (assert_eq arg) r? @JonathanBrouwer
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
added
merged-by-bors
Contributor
This was referenced Feb 6, 2026
Open
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing cf16cd9 (parent) -> 035b01b (this PR) Test differencesShow 116 test diffsStage 0
Stage 1
Additionally, 38 doctest diffs were found. These are ignored, as they are noisy. Job group index Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 035b01b794602d5861daa43ac792f372f8981ed7 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: cf16cd9b75 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Feb 6, 2026
Collaborator
|
Finished benchmarking commit (035b01b): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.2%, secondary -1.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 3.1%, secondary 2.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.0%, secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 474.937s -> 476.944s (0.42%) |
Contributor
Author
|
The regression looks like noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc_hir_analysis#152191 (Convert to inline diagnostics inrustc_hir_analysis)rustc_borrowck#152107 (Convert to inline diagnostics inrustc_borrowck)rustc_trait_selection#152117 (Convert to inline diagnostics inrustc_trait_selection)tcx.is_type_const#152136 (Consolidate type const checks ontcx.is_type_const)rustc_effective_visibilityto the new attribute parser #152170 (Portrustc_effective_visibilityto the new attribute parser)Failed merges:
r? @ghost
Create a similar rollup