Skip to content

Improve error display for codeblocks in rustdoc#53933

Merged
bors merged 2 commits intorust-lang:masterfrom
GuillaumeGomez:codeblock-error-display
Oct 12, 2018
Merged

Improve error display for codeblocks in rustdoc#53933
bors merged 2 commits intorust-lang:masterfrom
GuillaumeGomez:codeblock-error-display

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Sep 3, 2018 •
edited by QuietMisdreavus
Loading

Part of #53919.

r? @QuietMisdreavus

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 3, 2018
@rust-highfive
Copy link
Contributor

rust-highfive commented Sep 3, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:47:44] ....................................................................................................
[00:47:48] ....................................................................................................
[00:47:50] ...........................i........................................................................
[00:47:53] ....................................................................................................
[00:47:56] .............................................................................iiiiiiiii..............
[00:48:01] ....................................................................................................
[00:48:05] ....................................................................................................
[00:48:07] .........................................................i..........................................
[00:48:10] ....................................................................................................
---
travis_time:start:test_rustdoc
Check compiletest suite=rustdoc mode=rustdoc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:59:58] 
[00:59:58] running 258 tests
[01:00:24] .......................i................................................................F...........
stage0-sysroot/lib/rustlib/x86_64-unknown-linux-gnu
74020 ./obj/build/x86_64-unknown-linux-gnu/stage0-sysroot/lib/rustlib/x86_64-unknown-linux-gnu/lib
72532 ./src/llvm/lib
71772 ./obj/build/x86_64-unknown-linux-gnu/doc/std
---
38124 ./src/test/ui
38112 ./obj/build/x86_64-unknown-linux-gnu/stage0-std
37752 ./src/tools/lldb/www
36984 ./obj/build/x86_64-unknown-linux-gnu/stage0-std/release
36960 ./otf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0fd39067
travis_time:start:0fd39067
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0cc56efb
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@QuietMisdreavus
Copy link
Contributor

QuietMisdreavus commented Sep 4, 2018 

[01:00:56] ---- [rustdoc] rustdoc/issue-12834.rs stdout ----
[01:00:56] 
[01:00:56] error: rustdoc failed!
[01:00:56] status: exit code: 1
[01:00:56] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/issue-12834/auxiliary" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/issue-12834" "/checkout/src/test/rustdoc/issue-12834.rs"
[01:00:56] stdout:
[01:00:56] ------------------------------------------
[01:00:56] 
[01:00:56] ------------------------------------------
[01:00:56] stderr:
[01:00:56] ------------------------------------------
[01:00:56] warning: Backing out of syntax highlighting
[01:00:56]   |
[01:00:56]   = note: You probably did not intend to render this as a rust code-block
[01:00:56] 
[01:00:56] error: internal compiler error: Error constructed but not emitted
[01:00:56] 
[01:00:56] thread '<unnamed>' panicked at 'explicit panic', librustc_errors/diagnostic_builder.rs:295:13
[01:00:56] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:00:56] 
[01:00:56] error: internal compiler error: unexpected panic
[01:00:56] 
[01:00:56] note: the compiler unexpectedly panicked. this is a bug.
[01:00:56] 
[01:00:56] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:00:56] 
[01:00:56] note: rustc 1.30.0-dev running on x86_64-unknown-linux-gnu
[01:00:56] 
[01:00:56] 
[01:00:56] ------------------------------------------
[01:00:56] 
[01:00:56] thread '[rustdoc] rustdoc/issue-12834.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3196:9
[01:00:56] 
[01:00:56] 
[01:00:56] failures:
[01:00:56]     [rustdoc] rustdoc/issue-12834.rs

@QuietMisdreavus
Copy link
Contributor

QuietMisdreavus commented Sep 4, 2018

Also, can you add a test? Maybe try to reduce some of the linked issue's bindgen output into something we can stuff into a rustdoc-ui test?

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Sep 4, 2018

Oh damn, forgot to add the test!

@GuillaumeGomez GuillaumeGomez force-pushed the codeblock-error-display branch from 97ac9ae to f14a145 Compare September 4, 2018 21:37
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Sep 6, 2018

CI passed and forgotten test added.

@TimNN
Copy link
Contributor

TimNN commented Sep 11, 2018

Ping from triage @QuietMisdreavus: This PR requires your review.

@QuietMisdreavus
Copy link
Contributor

QuietMisdreavus commented Sep 12, 2018

Whoops, sorry for letting this one slip!

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 12, 2018

📌 Commit f14a14535976e13938cae6442053201adee3bcb2 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2018
@kennytm kennytm mentioned this pull request Sep 13, 2018
Merged
@kennytm
Copy link
Member

kennytm commented Sep 13, 2018 •
edited
Loading

@bors r-

In this test from cargo, the exit code becomes 0 instead of 101. See #54168 (comment).

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 13, 2018
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Sep 13, 2018

This is... weird... I suppose the stderr isn't checked the same way or something along the line. I'll fix it in the next days.

@QuietMisdreavus
Copy link
Contributor

QuietMisdreavus commented Sep 13, 2018 

but: exited with exit code: 0

I think Cargo is expecting this test to crash rustdoc; does this PR make parse errors non-fatal?

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Sep 13, 2018

It does indeed. That was the whole point of the PR, which is why I'm having trouble in here. Should I disable the test on cargo waiting for this PR to get merged?

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Sep 13, 2018

@rust-lang/cargo Should I open a PR on cargo to disable the failing test before merging this one (and then fixing the test on cargo)?

@alexcrichton
Copy link
Member

alexcrichton commented Sep 13, 2018

Either that or updating the test to only verify the output and not the exit code should be fine, yeah.

@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 11, 2018
@rust-highfive
Copy link
Contributor

rust-highfive commented Oct 11, 2018

The job dist-x86_64-apple of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:03:28]       Memory: 8 GB
[00:03:28]       Boot ROM Version: VMW71.00V.0.B64.1704110547
[00:03:28]       Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
[00:03:28]       SMC Version (system): 2.8f0
[00:03:28]       Serial Number (system): VMSJC3eTOgH2
[00:03:28] 
[00:03:28] hw.ncpu: 4
[00:03:28] hw.byteorder: 1234
[00:03:28] hw.memsize: 8589934592
---
uploading "0423b5ee38deef3482c4b3acdaaeef2cc1c3c9e0/clippy-nightly-x86_64-apple-darwin.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
uploading "0423b5ee38deef3482c4b3acdaaeef2cc1c3c9e0/cargo-nightly-x86_64-apple-darwin.tar.xz" with {:content_type=>"application/x-xz", :acl=>"public-read"}
uploading "0423b5ee38deef3482c4b3acdaaeef2cc1c3c9e0/cargo-nightly-x86_64-apple-darwin.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
travis_fold:end:dpl.3
/Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-core-2.11.147/lib/seahorse/client/plugins/raise_response_errors.rb:15:in `call': Encountered a `SocketError` while attempting to connect to: (Aws::Errors::NoSuchEndpointError)
  https://rust-lang-ci2.s3.us-west-1.amazonaws.com/rustc-builds/0423b5ee38deef3482c4b3acdaaeef2cc1c3c9e0/lldb-nightly-x86_64-apple-darwin.tar.xz
This is typically the result of an invalid `:region` option or a
poorly formatted `:endpoint` option.
* Avoid configuring the `:endpoint` option directly. Endpoints are constructed
  from the `:region`. The `:endpoint` option is reserved for connecting to
  non-standard test endpoints.
* Not every service is available in every region.
* Never suffix region names with availability zones.
  Use "us-east-1", not "us-east-1a"
Known AWS regions include (not specific to this service):
ap-northeast-1
ap-northeast-2
ap-south-1
ap-southeast-1
ap-southeast-2
ca-central-1
eu-central-1
eu-west-1
eu-west-2
eu-west-3
sa-east-1
us-east-2
us-west-1
us-west-2
cn-north-1
cn-north-1
cn-northwest-1
us-gov-west-1
 from /Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-core-2.11.147/lib/aws-sdk-core/plugins/s3_sse_cpk.rb:19:in `call'
 from /Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-core-2.11.147/lib/aws-sdk-core/plugins/s3_dualstack.rb:24:in `call'
 from /Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-core-2.11.147/lib/aws-sdk-core/plugins/s3_accelerate.rb:34:in `call'
 from /Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-core-2.11.147/lib/aws-sdk-core/plugins/jsonvalue_converter.rb:20:in `call'
 from /Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-core-2.11.147/lib/aws-sdk-core/plugins/idempotency_token.rb:18:in `call'
 from /Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-core-2.11.147/lib/aws-sdk-core/plugins/param_converter.rb:20:in `call'
 from /Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-core-2.11.147/lib/seahorse/client/plugins/response_target.rb:21:in `call'
 from /Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-core-2.11.147/lib/seahorse/client/request.rb:70:in `send_request'
 from /Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-core-2.11.147/lib/seahorse/client/base.rb:207:in `block (2 levels) in define_operation_methods'
 from /Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-resources-2.11.147/lib/aws-sdk-resources/services/s3/file_uploader.rb:42:in `block in put_object'
 from /Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-resources-2.11.147/lib/aws-sdk-resources/services/s3/file_uploader.rb:49:in `open_file'
 from /Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-resources-2.11.147/lib/aws-sdk-resources/services/s3/file_uploader.rb:41:in `put_object'
 from /Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-resources-2.11.147/lib/aws-sdk-resources/services/s3/file_uploader.rb:34:in `upload'
 from /Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-resources-2.11.147/lib/aws-sdk-resources/services/s3/object.rb:252:in `upload_file'
 from /Users/travis/.rvm/gems/ruby-2.4.2/gems/dpl-s3-1.10.3/lib/dpl/provider/s3.rb:114:in `block (2 levels) in upload_multithreaded'
failed to deploy

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@QuietMisdreavus
Copy link
Contributor

QuietMisdreavus commented Oct 11, 2018 

/Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-core-2.11.147/lib/seahorse/client/plugins/raise_response_errors.rb:15:in `call': Encountered a `SocketError` while attempting to connect to: (Aws::Errors::NoSuchEndpointError)

@rust-lang/infra Is this a known error?

@emilyalbini
Copy link
Member

emilyalbini commented Oct 11, 2018

Seems like a spurious failure while uploading artifacts to S3.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2018
@bors
Copy link
Collaborator

bors commented Oct 11, 2018

⌛ Testing commit 322e469 with merge 13187c545947d3711a173cc472e00344dfdca5b4...

@bors bors mentioned this pull request Oct 11, 2018
Merged
@bors
Copy link
Collaborator

bors commented Oct 12, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 12, 2018
@rust-highfive
Copy link
Contributor

rust-highfive commented Oct 12, 2018

The job dist-i686-freebsd of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[01:25:02]   = note: #[warn(stable_features)] on by default
[01:25:02] 
[01:25:03] error: linking with `cc` failed: exit code: 1
[01:25:03]   |
[01:25:03]   = note: "cc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-m64" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/clippy-15124f236156578c.clippy.1agv0obf-cgu.0.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/clippy-15124f236156578c.clippy.1agv0obf-cgu.1.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/clippy-15124f236156578c.clippy.1agv0obf-cgu.10.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/clippy-15124f236156578c.clippy.1agv0obf-cgu.11.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/clippy-15124f236156578c.clippy.1agv0obf-cgu.2.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/clippy-15124f236156578c.clippy.1agv0obf-cgu.3.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/clippy-15124f236156578c.clippy.1agv0obf-cgu.4.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/clippy-15124f236156578c.clippy.1agv0obf-cgu.5.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/clippy-15124f236156578c.clippy.1agv0obf-cgu.6.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/clippy-15124f236156578c.clippy.1agv0obf-cgu.7.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/clippy-15124f236156578c.clippy.1agv0obf-cgu.8.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/clippy-15124f236156578c.clippy.1agv0obf-cgu.9.rcgu.o" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libclippy-15124f236156578c.so" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/clippy-15124f236156578c.1y50zvxxnwe2325g.rcgu.o" "-Wl,-zrelro" "-Wl,-znow" "-Wl,-O1" "-nodefaultlibs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/build/backtrace-sys-edad71622cd60d2b/out" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,-Bstatic" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libclippy_lints-517622f2d7094231.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libregex_syntax-d99a9e7fe17e1709.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libucd_util-40867e16e2190c19.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libcargo_metadata-0a9cadf19c7a4c31.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libserde_json-59129c341ad872a6.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libryu-59c135f1fc351081.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libitoa-509471e5f67cb366.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/liberror_chain-aa187a0cd1cf1022.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libbacktrace-6d7836e5ac3143d2.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libbacktrace_sys-adba8cae73433f34.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/librustc_demangle-1d88837c6879dfb2.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libcfg_if-aee537a085b362cf.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/liblibc-106ac06e02ff56d5.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/liburl-e2f6b561e47c651b.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libpercent_encoding-3783fa80e5f01f07.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libidna-8b1f43891ddbcf87.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libunicode_normalization-4c5d7871b7875e4b.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libunicode_bidi-fe284fb0313b315f.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libpulldown_cmark-c5509840527ae4c1.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libbitflags-2ad120d3f682b481.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libitertools-dad53bc08bfbb402.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libeither-1e6d330a920f28a4.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libsmallvec-0e05123d85fc439f.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libunreachable-54aacf46b2e709d8.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libvoid-b1fc79e3aa32b650.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libquine_mc_cluskey-745c16f5c5b40647.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libsemver-91bae1b34cb26fed.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libsemver_parser-27a3b03ac27f1b4a.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/liblazy_static-a4248ac654964eb6.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libif_chain-55cd14ce1b88b428.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libmatches-d5f28523e3e0a1dd.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libtoml-b665a1c1c50f1900.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc1zwYC0/libserde-e2e51d009260be21.rlib" "-Wl,--no-whole-archive" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,-Bdynamic" "-lrustc_typeck-20a93b0501d4af1e" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lrustc_platform_intrinsics-cc67f1099ac72082" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lrustc_plugin-a9664b99d28517ae" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lrustc_metadata-bd84e5cb8aa6b52a" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lrustc_metadata_utils-efe0ce1f56260ebf" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lsyntax_ext-9921f40455de38c8" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lrustc-8c0c858aa6b28b3f" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-ltest-3d1aea000bbcc21b" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lterm-e1a8aa057bdf54dc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lrustc_fs_util-0146c3e4dc3227d0" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lproc_macro-95a4557be658337b" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lgraphviz-15d4cd3659511b95" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lfmt_macros-85c7dad9767e6849" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lsyntax-122617cc400e18a5" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lrustc_target-1177af84337e4fb2" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lrustc_errors-d3e30e257c22766a" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lsyntax_pos-b84863978854a1dd" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-larena-70fcead15723545e" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lrustc_data_structures-52683d91dacf34ed" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lrustc_cratesio_shim-5f55b26ed35a240f" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lserialize-c38436022542d398" "-Wl,--start-group" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lstd-678475b44b87e768" "-Wl,--end-group" "-Wl,-Bstatic" "/tmp/rustc1zwYC0/libcompiler_builtins-e5b85903e43edcdb.rlib" "-Wl,-Bdynamic" "-lutil" "-lutil" "-lutil" "-lutil" "-ldl" "-lrt" "-lpthread" "-lpthread" "-lgcc_s" "-lc" "-lm" "-lrt" "-lpthread" "-lutil" "-lutil" "-shared"
[01:25:03]   = note: /usr/bin/ld: i386 architecture of input file `/tmp/rustc1zwYC0/libbacktrace_sys-adba8cae73433f34.rlib(alloc.o)' is incompatible with i386:x86-64 output
[01:25:03]           /usr/bin/ld: i386 architecture of input file `/tmp/rustc1zwYC0/libbacktrace_sys-adba8cae73433f34.rlib(dwarf.o)' is incompatible with i386:x86-64 output
[01:25:03]           /usr/bin/ld: i386 architecture of input file `/tmp/rustc1zwYC0/libbacktrace_sys-adba8cae73433f34.rlib(fileline.o)' is incompatible with i386:x86-64 output
[01:25:03]           /usr/bin/ld: i386 architecture of input file `/tmp/rustc1zwYC0/libbacktrace_sys-adba8cae73433f34.rlib(posix.o)' is incompatible with i386:x86-64 output
[01:25:03]           /usr/bin/ld: i386 architecture of input file `/tmp/rustc1zwYC0/libbacktrace_sys-adba8cae73433f34.rlib(read.o)' is incompatible with i386:x86-64 output
[01:25:03]           /usr/bin/ld: i386 architecture of input file `/tmp/rustc1zwYC0/libbacktrace_sys-adba8cae73433f34.rlib(sort.o)' is incompatible with i386:x86-64 output
[01:25:03]           /usr/bin/ld: i386 architecture of input file `/tmp/rustc1zwYC0/libbacktrace_sys-adba8cae73433f34.rlib(state.o)' is incompatible with i386:x86-64 output
[01:25:03]           /usr/bin/ld: i386 architecture of input file `/tmp/rustc1zwYC0/libbacktrace_sys-adba8cae73433f34.rlib(elf.o)' is incompatible with i386:x86-64 output
[01:25:03]           /tmp/rustc1zwYC0/libbacktrace_sys-adba8cae73433f34.rlib(alloc.o): In function `__rbt_backtrace_alloc':
[01:25:03]           /tmp/rustc1zwYC0/libbacktrace_sys-adba8cae73433f34.rlib(alloc.o): In function `__rbt_backtrace_vector_grow':
[01:25:03]           alloc.c:(.text.__rbt_backtrace_vector_grow+0x83): undefined reference to `__error'
[01:25:03]           /tmp/rustc1zwYC0/libbacktrace_sys-adba8cae73433f34.rlib(alloc.o): In function `__rbt_backtrace_vector_finish':
[01:25:03]           alloc.c:(.text.__rbt_backtrace_vector_finish+0x45): undefined reference to `__error'
---
uploading "13187c545947d3711a173cc472e00344dfdca5b4/cargo-nightly-i686-unknown-freebsd.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
uploading "13187c545947d3711a173cc472e00344dfdca5b4/llvm-tools-nightly-i686-unknown-freebsd.tar.xz" with {:content_type=>"application/x-xz", :acl=>"public-read"}
uploading "13187c545947d3711a173cc472e00344dfdca5b4/rust-nightly-i686-unknown-freebsd.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
travis_fold:end:dpl.3
/home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-resources-2.11.148/lib/aws-sdk-resources/services/s3/multipart_file_uploader.rb:81:in `abort_upload': multipart upload failed: execution expired (Aws::S3::MultipartUploadError)
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-resources-2.11.148/lib/aws-sdk-resources/services/s3/multipart_file_uploader.rb:70:in `upload_parts'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-resources-2.11.148/lib/aws-sdk-resources/services/s3/multipart_file_uploader.rb:44:in `upload'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-resources-2.11.148/lib/aws-sdk-resources/services/s3/file_uploader.rb:32:in `upload'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-resources-2.11.148/lib/aws-sdk-resources/services/s3/object.rb:252:in `upload_file'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/dpl-s3-1.10.3/lib/dpl/provider/s3.rb:114:in `block (2 levels) in upload_multithreaded'
failed to deploy

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm
Copy link
Member

kennytm commented Oct 12, 2018

@bors retry

S3 deploy error again

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2018
@bors
Copy link
Collaborator

bors commented Oct 12, 2018

⌛ Testing commit 322e469 with merge 794ee371e552644933c2ab037253f1befdf7391f...

@bors
Copy link
Collaborator

bors commented Oct 12, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 12, 2018
@rust-highfive
Copy link
Contributor

rust-highfive commented Oct 12, 2018

The job x86_64-gnu-aux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[01:44:54] 
[01:44:54] testing https://github.com/servo/servo
[01:44:54] Initialized empty Git repository in /checkout/obj/build/ct/servo/.git/
[01:44:54] fatal: Could not parse object '987e376ca7a4245dbc3e0c06e963278ee1ac92d1'.
[01:45:15] fatal: unable to access 'https://github.com/servo/servo/': Could not resolve host: github.com
[01:45:15] thread 'main' panicked at 'assertion failed: status.success()', tools/cargotest/main.rs:128:13
[01:45:15] 
[01:45:15] 
[01:45:15] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/cargotest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build/ct"
[01:45:15] expected success, got: exit code: 101
[01:45:15] expected success, got: exit code: 101
[01:45:15] 
[01:45:15] 
[01:45:15] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/test/pretty src/test/run-pass/pretty src/test/run-fail/pretty src/test/run-pass-valgrind/pretty src/test/run-pass-fulldeps/pretty src/test/run-fail-fulldeps/pretty src/tools/cargo src/tools/cargotest
[01:45:15] Build completed unsuccessfully in 0:45:49
[01:45:15] Makefile:60: recipe for target 'check-aux' failed
[01:45:15] make: *** [check-aux] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:162a14ab
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:25ebaf30:start=1539326244792973736,finish=1539326244800038638,duration=7064902
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:3651e634
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:021b3008
travis_time:start:021b3008
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:2600d487
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Oct 12, 2018

@bors: retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2018
@bors
Copy link
Collaborator

bors commented Oct 12, 2018

⌛ Testing commit 322e469 with merge 849a0e9...

bors added a commit that referenced this pull request Oct 12, 2018
@bors
Auto merge of #53933 - GuillaumeGomez:codeblock-error-display, r=Quie…
849a0e9 
…tMisdreavus

Improve error display for codeblocks in rustdoc

Part of #53919.

r? @QuietMisdreavus
@bors
Copy link
Collaborator

bors commented Oct 12, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing 849a0e9 to master...

@bors bors merged commit 322e469 into rust-lang:master Oct 12, 2018
@GuillaumeGomez GuillaumeGomez deleted the codeblock-error-display branch October 12, 2018 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@QuietMisdreavus QuietMisdreavus

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@GuillaumeGomez @rust-highfive @QuietMisdreavus @TimNN @bors @kennytm @alexcrichton @ehuss @XAMPPRocky @emilyalbini