Rollup of 11 pull requests by kennytm · Pull Request #54168 · rust-lang/rust

kennytm · 2018-09-13T02:02:26Z

Successful merges:

Do not emit E0277 on incorrect tuple destructured binding #53371 (Do not emit E0277 on incorrect tuple destructured binding)
Add rustc SHA to released DWARF debuginfo #53829 (Add rustc SHA to released DWARF debuginfo)
Allow for opting out of ThinLTO and clean up LTO related cli flag handling. #53950 (Allow for opting out of ThinLTO and clean up LTO related cli flag handling.)
Replace unwrap calls in example by expect #53976 (Replace unwrap calls in example by expect)
Add Error::description soft-deprecation to RELEASES #54070 (Add Error::description soft-deprecation to RELEASES)
miri loop detector hashing #54076 (miri loop detector hashing)
Add some unit tests for find_best_match_for_name #54119 (Add some unit tests for find_best_match_for_name)
Add a test that tries to modify static memory at compile-time #54147 (Add a test that tries to modify static memory at compile-time)
Updated 1.29 release notes with --document-private-items flag #54150 (Updated 1.29 release notes with --document-private-items flag)
Update stage 0 to latest beta #54163 (Update stage 0 to latest beta)
COMPILER_TESTS.md has been moved #54170 (COMPILER_TESTS.md has been moved)

…dling.

…inant; do not hash extra machine state standalone miri is not interested in loop detection

This commit updates the debuginfo that is encoded in all of our released artifacts by default. Currently it has paths like `/checkout/src/...` but these are a little inconsistent and have changed over time. This commit instead attempts to actually define the file paths in our debuginfo to be consistent between releases. All debuginfo paths are now intended to be `/rustc/$sha` where `$sha` is the git sha of the released compiler. Sub-paths are all paths into the git repo at that `$sha`.

There were only some UI tests that covered this function. Since there's more diagnostic work going on, I think it makes sense to have this unit tested.

Fixes bootstrap on AArch64

Do not emit E0277 on incorrect tuple destructured binding Fix rust-lang#50333.

kennytm · 2018-09-13T02:02:49Z

@bors r+ p=10

bors · 2018-09-13T02:02:49Z

📌 Commit f8a06272daa57ea10db8dce2f0dbd0bdcb97d4e6 has been approved by kennytm

bors · 2018-09-13T02:44:25Z

⌛ Testing commit f8a06272daa57ea10db8dce2f0dbd0bdcb97d4e6 with merge 565c960be6d1297d37a793ec7618b4559b470c2a...

bors · 2018-09-13T03:36:12Z

💔 Test failed - status-travis

kennytm · 2018-09-13T04:07:44Z

@bors retry

The document is now hosted at rust-lang-nursery.github.io.

bors · 2018-09-13T06:02:32Z

⌛ Testing commit f8a06272daa57ea10db8dce2f0dbd0bdcb97d4e6 with merge 40a3b5d1876ac63ae5ac8c65dfcdd772b2e373bb...

bors · 2018-09-13T06:54:08Z

💔 Test failed - status-travis

bors · 2018-09-13T13:35:28Z

⌛ Testing commit 737916c519a1378956aff8d976eb1bc1d2dfbabc with merge acc23980b00391c0a38a7ff237492e333034b374...

bors · 2018-09-13T15:16:16Z

💔 Test failed - status-appveyor

emilyalbini · 2018-09-13T15:21:58Z

Uuuh, a legit failure \o/

@bors treeclosed-

kennytm · 2018-09-13T16:32:27Z

Caused by #53933.

---- doc::output_not_captured stdout ----
running `C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\release\cargo.exe doc`
thread 'doc::output_not_captured' panicked at '
Expected: execs
    but: exited with exit code: 0
--- stdout
--- stderr
 Documenting a v0.0.1 (file:///C:/projects/rust/build/x86_64-pc-windows-msvc/stage2-tools/x86_64-pc-windows-msvc/cit/t506/foo/a)
    Checking a v0.0.1 (file:///C:/projects/rust/build/x86_64-pc-windows-msvc/stage2-tools/x86_64-pc-windows-msvc/cit/t506/foo/a)
error: unknown start of token: \u{2603}
 --> <stdin>:1:1
  |
1 | ☃
  | ^
warning: Invalid doc comment starting with: `☃`
 Documenting foo v0.0.1 (file:///C:/projects/rust/build/x86_64-pc-windows-msvc/stage2-tools/x86_64-pc-windows-msvc/cit/t506/foo)
    Finished dev [unoptimized + debuginfo] target(s) in 0.90s
', tools\cargo\tests\testsuite\support\mod.rs:731:13
note: Run with `RUST_BACKTRACE=1` for a backtrace.
failures:
    doc::output_not_captured

@steveklabnik

…eklabnik Replace unwrap calls in example by expect Part of rust-lang#51668. r? @steveklabnik

Add Error::description soft-deprecation to RELEASES

@oli-obk

miri loop detector hashing * fix enum hashing to also consider discriminant * do not hash extra machine state * standalone miri is not interested in loop detection, so let it opt-out In the future I think we want to move the hashing logic out of the miri engine, this is CTFE-only. r? @oli-obk

…or_name, r=nikomatsakis Add some unit tests for find_best_match_for_name There were only some UI tests that covered this function. Since there's more diagnostic work going on, I think it makes sense to have this unit tested.

@oli-obk

Add a test that tries to modify static memory at compile-time Attempt to fix rust-lang#53818 cc @oli-obk

Updated 1.29 release notes with --document-private-items flag [Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md#cargo)

Update stage 0 to latest beta Fixes bootstrap on AArch64 by pulling in rust-lang#53939

COMPILER_TESTS.md has been moved The document is now hosted at rust-lang-nursery.github.io.

…ichaelwoerister Add rustc SHA to released DWARF debuginfo This commit updates the debuginfo that is encoded in all of our released artifacts by default. Currently it has paths like `/checkout/src/...` but these are a little inconsistent and have changed over time. This commit instead attempts to actually define the file paths in our debuginfo to be consistent between releases. All debuginfo paths are now intended to be `/rustc/$sha` where `$sha` is the git sha of the released compiler. Sub-paths are all paths into the git repo at that `$sha`.

…excrichton Allow for opting out of ThinLTO and clean up LTO related cli flag handling. It turns out that there currently is no way to explicitly disable ThinLTO (except for the nightly-only `-Zthinlto` flag). This PR extends `-C lto` to take `yes` and `no` in addition to `thin` and `fat`. It should be backwards compatible. It also cleans up how LTO mode selection is handled. Note that merging the PR in the current state would make the new values for `-C lto` available on the stable channel. I think that would be fine but maybe some team should vote on it.

kennytm · 2018-09-13T16:47:40Z

@bors r+

Removed #53933 (causing error above)
Removed #53621 (already testing)
Added #53829, #53950

bors · 2018-09-13T16:47:41Z

📌 Commit 07dc4b3 has been approved by kennytm

bors · 2018-09-13T22:40:43Z

⌛ Testing commit 07dc4b3 with merge 4f921d7...

Rollup of 11 pull requests Successful merges: - #53371 (Do not emit E0277 on incorrect tuple destructured binding) - #53829 (Add rustc SHA to released DWARF debuginfo) - #53950 (Allow for opting out of ThinLTO and clean up LTO related cli flag handling.) - #53976 (Replace unwrap calls in example by expect) - #54070 (Add Error::description soft-deprecation to RELEASES) - #54076 (miri loop detector hashing) - #54119 (Add some unit tests for find_best_match_for_name) - #54147 (Add a test that tries to modify static memory at compile-time) - #54150 (Updated 1.29 release notes with --document-private-items flag) - #54163 (Update stage 0 to latest beta) - #54170 (COMPILER_TESTS.md has been moved)

bors · 2018-09-14T01:07:12Z

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 4f921d7 to master...

michaelwoerister and others added 14 commits September 5, 2018 12:52

Allow for opting out of ThinLTO and clean up LTO related cli flag han…

24093a6

…dling.

Replace unwrap calls in example by expect

72ba0ba

Add Error::description soft-deprecation to RELEASES

e25e2ab

miri loop detector hashing: fix enum hashing to also consider discrim…

3cb736a

…inant; do not hash extra machine state standalone miri is not interested in loop detection

Add some unit tests for find_best_match_for_name

09973d2

There were only some UI tests that covered this function. Since there's more diagnostic work going on, I think it makes sense to have this unit tested.

Update stage0 to latest beta

dfd04e1

Fixes bootstrap on AArch64

Do not emit E0277 on incorrect tuple destructured binding

3d7099a

Simplify the recovered tuple ty

633a47b

address review comment, reduce scope

5f8bf91

Add a test that tries to modify static memory at compile-time

3d6c260

Updated 1.29 release notes with --document-private-items flag

3c1efcd

Add comment explaining reasoning

63cd81c

Rollup merge of rust-lang#53371 - estebank:tuple, r=nikomatsakis

9af125d

Do not emit E0277 on incorrect tuple destructured binding Fix rust-lang#50333.

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 13, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 13, 2018

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2018

COMPILER_TESTS.md has been moved

f656fe3

The document is now hosted at rust-lang-nursery.github.io.

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 13, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 13, 2018

kennytm mentioned this pull request Sep 13, 2018

Improve error display for codeblocks in rustdoc #53933

Merged

kennytm added 10 commits September 14, 2018 00:41

Rollup merge of rust-lang#53976 - GuillaumeGomez:expect-world, r=stev…

2882119

…eklabnik Replace unwrap calls in example by expect Part of rust-lang#51668. r? @steveklabnik

Rollup merge of rust-lang#54070 - passcod:patch-1, r=steveklabnik

74cf074

Add Error::description soft-deprecation to RELEASES

Rollup merge of rust-lang#54147 - agnxy:const-eval-test, r=oli-obk

d6421c7

Add a test that tries to modify static memory at compile-time Attempt to fix rust-lang#53818 cc @oli-obk

Rollup merge of rust-lang#54150 - Aaronepower:master, r=Mark-Simulacrum

73a7482

Updated 1.29 release notes with --document-private-items flag [Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md#cargo)

Rollup merge of rust-lang#54163 - parched:stage0, r=Mark-Simulacrum

67efb39

Update stage 0 to latest beta Fixes bootstrap on AArch64 by pulling in rust-lang#53939

Rollup merge of rust-lang#54170 - kzys:contrib-md, r=zackmdavis

e92f1b9

COMPILER_TESTS.md has been moved The document is now hosted at rust-lang-nursery.github.io.

kennytm force-pushed the rollup branch from 737916c to 07dc4b3 Compare September 13, 2018 16:47

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2018

bors merged commit 07dc4b3 into rust-lang:master Sep 14, 2018

bors mentioned this pull request Sep 14, 2018

Replace unwrap calls in examples by expect #51668

Closed

Centril added the rollup A PR which is a rollup label Oct 2, 2019

Uh oh!

Conversation

kennytm commented Sep 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kennytm commented Sep 13, 2018

Uh oh!

bors commented Sep 13, 2018

Uh oh!

bors commented Sep 13, 2018

Uh oh!

bors commented Sep 13, 2018

Uh oh!

This comment has been minimized.

kennytm commented Sep 13, 2018

Uh oh!

bors commented Sep 13, 2018

Uh oh!

bors commented Sep 13, 2018

Uh oh!

bors commented Sep 13, 2018

Uh oh!

bors commented Sep 13, 2018

Uh oh!

emilyalbini commented Sep 13, 2018

Uh oh!

kennytm commented Sep 13, 2018

Uh oh!

kennytm commented Sep 13, 2018

Uh oh!

bors commented Sep 13, 2018

Uh oh!

bors commented Sep 13, 2018

Uh oh!

bors commented Sep 14, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

kennytm commented Sep 13, 2018 •

edited

Loading