Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Collaborator
|
☔ The latest upstream changes (presumably #53409) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
hide-default-impls-items
branch
from
edd7fe2 to
f36fcca
Compare
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
GuillaumeGomez
force-pushed
the
hide-default-impls-items
branch
from
f36fcca to
11e8690
Compare
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
GuillaumeGomez
force-pushed
the
hide-default-impls-items
branch
from
11e8690 to
25124dd
Compare
Member
Author
|
Updated. |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Member
Author
|
Not ready for the moment (because of #54492). |
Contributor
|
Triage; @QuietMisdreavus Hello, are you able to review this PR? |
Member
Author
|
@Aaronepower: Not ready yet so reviewing wouldn't be very useful for the moment... |
XAMPPRocky
added
S-waiting-on-author
Contributor
|
Ping from triage @GuillaumeGomez: what is the status of this PR? |
Member
Author
|
Still need to be updated. Trying to do more urgent issues first. |
GuillaumeGomez
force-pushed
the
hide-default-impls-items
branch
from
25124dd to
f729f4a
Compare
Member
Author
|
Should be ready to go now! |
src/librustdoc/clean/mod.rs
Outdated
| pub fn is_associated(&self) -> bool { | ||
| match *self { | ||
| ItemEnum::TypedefItem(_, _) | | ||
| ItemEnum::AssociatedConstItem(_, _) | |
Contributor
There was a problem hiding this comment.
I feel like associated consts don't need to be shown all the time, since we don't show const values any more.
Contributor
|
Ping from triage @GuillaumeGomez: it looks like some updates have been requested to your PR. |
Member
Author
|
I'll update it in the next days. |
QuietMisdreavus
approved these changes
Nov 1, 2018
Contributor
QuietMisdreavus
left a comment
QuietMisdreavus
left a comment
There was a problem hiding this comment.
r=me pending travis
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Contributor
This is the second |
Member
Author
|
I think the problem is a missing class here. |
GuillaumeGomez
force-pushed
the
hide-default-impls-items
branch
from
cb5d220 to
ca65b43
Compare
Member
Author
|
Updated the failing test accordingly (it was a missing class). |
Contributor
|
r=me pending travis |
Member
Author
|
@bors: r=QuietMisdreavus |
Collaborator
|
📌 Commit ca65b43 has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 3, 2018
…tems, r=QuietMisdreavus Hide default impls items Follow up of rust-lang#51885. Fixes rust-lang#54025. cc @Mark-Simulacrum r? @QuietMisdreavus And screenshots of course: <img width="1440" alt="screen shot 2018-09-12 at 23 30 35" src="https://user-images.githubusercontent.com/3050060/45454424-1ff8d500-b6e4-11e8-9257-030322495d58.png"> <img width="1440" alt="screen shot 2018-09-12 at 23 30 42" src="https://user-images.githubusercontent.com/3050060/45454431-2424f280-b6e4-11e8-8d65-db0d85ac18f0.png">
bors
added a commit
that referenced
this pull request
Nov 3, 2018
Rollup of 5 pull requests Successful merges: - #54162 (Hide default impls items) - #55555 (Make `-Z ls` list the actual filename of external dependencies) - #55567 (add test for deriving Debug on uninhabited enum) - #55568 (test that rustdoc doesn't overflow on a big enum) - #55598 (publish-toolstate: ping maintainers when a tool builds again) Failed merges: r? @ghost
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #51885.
Fixes #54025.
cc @Mark-Simulacrum
r? @QuietMisdreavus
And screenshots of course: