Add long error explanation for E0575#65334
Merged
bors merged 2 commits intorust-lang:masterfrom Oct 19, 2019
Merged
Conversation
Contributor
|
Some changes occurred in diagnostic error codes |
Contributor
|
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
100 tasks
Collaborator
|
☔ The latest upstream changes (presumably #65454) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
long-err-explanation-E0575
branch
from
6d49b11 to
585719d
Compare
Member
Author
|
r? @kinnison |
kinnison
suggested changes
Oct 16, 2019
Contributor
kinnison
left a comment
kinnison
left a comment
There was a problem hiding this comment.
Two possible language tweaks, otherwise good IMO.
src/librustc_resolve/error_codes.rs
Outdated
Contributor
There was a problem hiding this comment.
I think 'other' rather than 'else' would be better:
Something other than a type or an associated type was given.
src/librustc_resolve/error_codes.rs
Outdated
Contributor
There was a problem hiding this comment.
I feel the repetition of 'in both cases' is clumsy. Perhaps:
In both cases we're declaring a variable (called
_) and we're
stating what we believe to be a type. However, .......
?
GuillaumeGomez
force-pushed
the
long-err-explanation-E0575
branch
from
585719d to
367cda4
Compare
Member
Author
|
Updated. |
kinnison
approved these changes
Oct 16, 2019
Member
Author
|
@bors: r=kinnison |
Collaborator
|
📌 Commit 367cda4 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 16, 2019
…-E0575, r=kinnison Add long error explanation for E0575 Part of rust-lang#61137.
Collaborator
|
☔ The latest upstream changes (presumably #65234) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
long-err-explanation-E0575
branch
from
367cda4 to
21d9258
Compare
Member
Author
|
And here we go again! @bors: r=kinnison |
Collaborator
|
📌 Commit 21d9258 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 17, 2019
…-E0575, r=kinnison Add long error explanation for E0575 Part of rust-lang#61137.
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Oct 18, 2019
…-E0575, r=kinnison Add long error explanation for E0575 Part of rust-lang#61137.
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Oct 18, 2019
…-E0575, r=kinnison Add long error explanation for E0575 Part of rust-lang#61137.
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Oct 18, 2019
…-E0575, r=kinnison Add long error explanation for E0575 Part of rust-lang#61137.
bors
added a commit
that referenced
this pull request
Oct 19, 2019
Rollup of 19 pull requests Successful merges: - #65016 (Always inline `mem::{size_of,align_of}` in debug builds) - #65197 (Prepare `MutVisitor`s to handle interned projections) - #65201 (Disable Go and OCaml bindings when building LLVM) - #65334 (Add long error explanation for E0575) - #65364 (Collect occurrences of empty blocks for mismatched braces diagnostic) - #65455 (Avoid unnecessary `TokenTree` to `TokenStream` conversions) - #65472 (Use a sharded dep node to dep node index map) - #65480 (Speed up `LexicalResolve::expansion()`) - #65493 (Add long error explanation for E0584) - #65496 (properly document panics in div_euclid and rem_euclid) - #65498 (Plugins deprecation: don’t suggest simply removing the attribute) - #65508 (add option to ping llvm ice-breakers to triagebot) - #65511 (save-analysis: Nest tables when processing impl block definitions) - #65513 (reorder fmt docs for more clarity) - #65532 (doc: make BitSet intro more short) - #65535 (rustc: arena-allocate the slice in `ty::GenericsPredicate`, not the whole struct.) - #65540 (show up some extra info when t!() fails) - #65549 (Fix left/right shift typo in wrapping rotate docs) - #65552 (Clarify diagnostics when using `~` as a unary op) Failed merges: - #65390 (Add long error explanation for E0576) - #65434 (Add long error explanation for E0577) - #65471 (Add long error explanation for E0578) r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #61137.