Merged
Conversation
Those two are const fn and do not have any arguments. Inlining helps reducing generated code size in debug builds.
Instead of instaling OCaml bindings in a location where installation will not fail, don't build them in the first place.
Change-Id: I20ba0b62308370ee961141fa1aefc4b9c9f0cb3a
Change-Id: I20ba0b62308370ee961141fa1aefc4b9c9f0cb3a
Change-Id: I20ba0b62308370ee961141fa1aefc4b9c9f0cb3a
This wins 3% on `unicode_normalization`.
The commit also removes the debug statement, because they annoyed me. This change wins another 1% on `unicode_normalization`, at least partly because it no longer needs to increment `iteration`.
Building Servo with a recent Nightly produces: ```rust warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See rust-lang#29597 --> components/script/lib.rs:14:1 | 14 | #![plugin(script_plugins)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute | = note: `#[warn(deprecated)]` on by default ``` First, linking to rust-lang#29597 is not ideal since there is pretty much no discussion there of the deprecation and what can be used instead. This PR changes the link to the deprecation PR which does have more discussion. Second, the “remove this attribute” suggestion is rather unhelpful. Just because a feature is deprecated doesn’t mean that simply removing its use without a replacement is acceptable. In the case of custom lint, there is no replacement available. Prefixing a message with “help:” when telling users that they’re screwed honestly feels disrespectful. This PR also changes the message to be more factual.
Co-Authored-By: Mark Rousskov <mark.simulacrum@gmail.com>
Also, add a link to the growable type
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 3850408 with merge 91c3cd89f0cf61fae40500e346bf7c5f3e7050e7... |
Collaborator
|
💥 Test timed out |
bors
added
S-waiting-on-review
Member
Author
|
I can't figure out why this failed. For now, @bors retry |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Oct 19, 2019
Rollup of 19 pull requests Successful merges: - #65016 (Always inline `mem::{size_of,align_of}` in debug builds) - #65197 (Prepare `MutVisitor`s to handle interned projections) - #65201 (Disable Go and OCaml bindings when building LLVM) - #65334 (Add long error explanation for E0575) - #65364 (Collect occurrences of empty blocks for mismatched braces diagnostic) - #65455 (Avoid unnecessary `TokenTree` to `TokenStream` conversions) - #65472 (Use a sharded dep node to dep node index map) - #65480 (Speed up `LexicalResolve::expansion()`) - #65493 (Add long error explanation for E0584) - #65496 (properly document panics in div_euclid and rem_euclid) - #65498 (Plugins deprecation: don’t suggest simply removing the attribute) - #65508 (add option to ping llvm ice-breakers to triagebot) - #65511 (save-analysis: Nest tables when processing impl block definitions) - #65513 (reorder fmt docs for more clarity) - #65532 (doc: make BitSet intro more short) - #65535 (rustc: arena-allocate the slice in `ty::GenericsPredicate`, not the whole struct.) - #65540 (show up some extra info when t!() fails) - #65549 (Fix left/right shift typo in wrapping rotate docs) - #65552 (Clarify diagnostics when using `~` as a unary op) Failed merges: - #65390 (Add long error explanation for E0576) - #65434 (Add long error explanation for E0577) - #65471 (Add long error explanation for E0578) r? @ghost
Collaborator
|
☀️ Test successful - checks-azure |
This was referenced Oct 19, 2019
Contributor
|
📣 Toolstate changed by #65570! Tested on commit 14f0ed6. 💔 clippy-driver on windows: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra). |
This was referenced Oct 19, 2019
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Oct 19, 2019
Tested on commit rust-lang/rust@14f0ed6. Direct link to PR: <rust-lang/rust#65570> 💔 clippy-driver on windows: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra). 🎉 rls on linux: test-fail → test-pass (cc @Xanewok, @rust-lang/infra).
This was referenced Oct 19, 2019
tmandry
added
A-spurious
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
mem::{size_of,align_of}in debug builds #65016 (Always inlinemem::{size_of,align_of}in debug builds)MutVisitors to handle interned projections #65197 (PrepareMutVisitors to handle interned projections)TokenTreetoTokenStreamconversions #65455 (Avoid unnecessaryTokenTreetoTokenStreamconversions)LexicalResolve::expansion()#65480 (Speed upLexicalResolve::expansion())ty::GenericsPredicate, not the whole struct. #65535 (rustc: arena-allocate the slice inty::GenericsPredicate, not the whole struct.)~as a unary op #65552 (Clarify diagnostics when using~as a unary op)Failed merges:
r? @ghost