rustc: arena-allocate the slice in ty::GenericsPredicate, not the whole struct.#65535
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 19, 2019
Merged
rustc: arena-allocate the slice in ty::GenericsPredicate, not the whole struct.#65535bors merged 1 commit intorust-lang:masterfrom
ty::GenericsPredicate, not the whole struct.#65535bors merged 1 commit intorust-lang:masterfrom
Conversation
Member
Author
|
@bors try |
Collaborator
|
⌛ Trying commit cd9e444 with merge ce12120dcef3c0c5d02f2ee8406e58431034487c... |
Member
Author
|
cc @michaelwoerister @nikomatsakis This is post-#59953 / pre-#59789, you may want to take a look. |
Collaborator
|
☀️ Try build successful - checks-azure |
Member
Author
|
@rust-timer build ce12120dcef3c0c5d02f2ee8406e58431034487c |
Collaborator
|
Queued ce12120dcef3c0c5d02f2ee8406e58431034487c with parent fa0f7d0, future comparison URL. |
nikomatsakis
approved these changes
Oct 18, 2019
Contributor
nikomatsakis
left a comment
nikomatsakis
left a comment
There was a problem hiding this comment.
r=me, but feel free to wait for perf
Collaborator
|
Finished benchmarking try commit ce12120dcef3c0c5d02f2ee8406e58431034487c, comparison URL. |
Member
Author
|
@bors r=nikomatsakis |
Collaborator
|
📌 Commit cd9e444 has been approved by |
bors
added
the
S-waiting-on-bors
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Oct 18, 2019
…akis rustc: arena-allocate the slice in `ty::GenericsPredicate`, not the whole struct. While rebasing rust-lang#59789 I noticed we can do this now. However, it doesn't help much without changing `inferred_outlives_of` to the same type, which I might try next.
bors
added a commit
that referenced
this pull request
Oct 19, 2019
Rollup of 19 pull requests Successful merges: - #65016 (Always inline `mem::{size_of,align_of}` in debug builds) - #65197 (Prepare `MutVisitor`s to handle interned projections) - #65201 (Disable Go and OCaml bindings when building LLVM) - #65334 (Add long error explanation for E0575) - #65364 (Collect occurrences of empty blocks for mismatched braces diagnostic) - #65455 (Avoid unnecessary `TokenTree` to `TokenStream` conversions) - #65472 (Use a sharded dep node to dep node index map) - #65480 (Speed up `LexicalResolve::expansion()`) - #65493 (Add long error explanation for E0584) - #65496 (properly document panics in div_euclid and rem_euclid) - #65498 (Plugins deprecation: don’t suggest simply removing the attribute) - #65508 (add option to ping llvm ice-breakers to triagebot) - #65511 (save-analysis: Nest tables when processing impl block definitions) - #65513 (reorder fmt docs for more clarity) - #65532 (doc: make BitSet intro more short) - #65535 (rustc: arena-allocate the slice in `ty::GenericsPredicate`, not the whole struct.) - #65540 (show up some extra info when t!() fails) - #65549 (Fix left/right shift typo in wrapping rotate docs) - #65552 (Clarify diagnostics when using `~` as a unary op) Failed merges: - #65390 (Add long error explanation for E0576) - #65434 (Add long error explanation for E0577) - #65471 (Add long error explanation for E0578) r? @ghost
tesuji
added a commit
to tesuji/rust-clippy
that referenced
this pull request
Oct 19, 2019
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Oct 19, 2019
rustup rust-lang/rust#65535 cc rust-lang/rust#65585 changelog: none
hellow554
pushed a commit
to hellow554/rust-clippy
that referenced
this pull request
Oct 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While rebasing #59789 I noticed we can do this now. However, it doesn't help much without changing
inferred_outlives_ofto the same type, which I might try next.