Move {hir::lowering -> hir}::is_range_literal#67536
Merged
bors merged 3 commits intorust-lang:masterfrom Dec 23, 2019
Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
Member
|
@bors r+ That was really small! |
Collaborator
|
📌 Commit db4cc3b has been approved by |
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 22, 2019
…rk-Simulacrum
Move `{hir::lowering -> hir}::is_range_literal`
The function is never used inside lowering, but only ever in external crates.
By moving it, we facilitate lowering as its own crate.
Best read commit-by-commit.
r? @Mark-Simulacrum
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-author
The function is never used inside lowering, but only ever in external crates. By moving it, we faciliate lowering as its own crate.
Centril
force-pushed
the
move-is_range_literal
branch
from
db4cc3b to
86764b3
Compare
Contributor
Author
|
@bors r=Mark-Simulacrum |
Collaborator
|
📌 Commit 86764b3586f733b2e5dc829644869b743b532da0 has been approved by |
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
move-is_range_literal
branch
from
86764b3 to
4bb8346
Compare
Contributor
Author
|
@bors r=Mark-Simulacrum |
Collaborator
|
📌 Commit 4bb8346 has been approved by |
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 23, 2019
…rk-Simulacrum
Move `{hir::lowering -> hir}::is_range_literal`
The function is never used inside lowering, but only ever in external crates.
By moving it, we facilitate lowering as its own crate.
Best read commit-by-commit.
r? @Mark-Simulacrum
bors
added a commit
that referenced
this pull request
Dec 23, 2019
Rollup of 8 pull requests Successful merges: - #67233 (Add PartialEq and Eq to Cursor) - #67466 (Require const stability attributes on intrinsics to be able to use them in constant contexts) - #67507 (Remove mem::uninitalized from tests) - #67527 (Results show too much) - #67536 (Move `{hir::lowering -> hir}::is_range_literal`) - #67538 (Improve diagnostics for invalid assignment) - #67546 (Fix ICE in mir interpretation) - #67559 (Document that calling Drop, even after it panics, is UB) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function is never used inside lowering, but only ever in external crates.
By moving it, we facilitate lowering as its own crate.
Best read commit-by-commit.
r? @Mark-Simulacrum