Tweak 'static suggestion code#71235
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
These suggestions look much better to me! Is this ready for review? |
|
@ecstatic-morse thanks! Yes, I think I don't have anything else I can improve in the output except for one case in particular that could be confusing, but the added suggestion helps clear it up. I would also like to clean this up, but it can be done in a separate PR. |
ecstatic-morse
left a comment
ecstatic-morse
left a comment
There was a problem hiding this comment.
Sweet! As I mentioned above, these errors read much better to me. I like how the fix is written out in full, especially in the more complex cases. The logic seems cleaner than the old version as well. I left a few requests for clarification but overall I think this is good.
| segment.ident.span | ||
| } else { | ||
| trait_ref.path.span | ||
| }; |
There was a problem hiding this comment.
Out of curiosity, was this fixed elsewhere?
There was a problem hiding this comment.
Partly. I think this used to affect multiple tests but the only case that appears now is at https://github.com/rust-lang/rust/pull/71235/files#diff-1bd3f65ee2d72d0225a5db83a8391165.
| m | ||
| )); | ||
| true | ||
| false |
There was a problem hiding this comment.
It seems that the semantics of the return value of report_elision_failure have changed. What does the bool indicate here? Would you mind documenting it?
|
r=me with comment about meaning of return value for |
|
@bors r=ecstatic-morse |
|
📌 Commit fe7216d has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit fe7216d with merge cc8e308c6b15ea75974aef459c7c340e5fcb31de... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
@bors retry seems like a transient windows CI issue https://dev.azure.com/rust-lang/rust/_build/results?buildId=26917&view=logs&j=90f6024d-9735-531d-4933-8983ca347d60&t=0ac37a54-82be-5e9e-e574-4c58820a1ef5 |
bors
added
S-waiting-on-bors
Tweak `'static` suggestion code Fix rust-lang#71196.
|
Seems failed in rollup: #71377 (comment) |
bors
removed
the
S-waiting-on-bors
bors
added
the
S-waiting-on-author
|
@bors r=ecstatic-morse fixed test |
|
📌 Commit 59c816d has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
|
@bors r=ecstatic-morse always sort |
|
📌 Commit 25f8966 has been approved by |
Tweak `'static` suggestion code Fix rust-lang#71196.
Rollup of 5 pull requests Successful merges: - rust-lang#71235 (Tweak `'static` suggestion code) - rust-lang#71318 (miri-unleash tests: ensure they fire even with 'allow(const_err)') - rust-lang#71428 (Let compiletest recognize gdb 10.x) - rust-lang#71475 (Miri Frame: use mir::Location to represent position in function) - rust-lang#71476 (more compact way to adjust test sizes for Miri) Failed merges: r? @ghost
5 participants
Fix #71196.