Rollup of 4 pull requests#71377
Closed
Dylan-DPC-zz wants to merge 15 commits intorust-lang:masterfrom
Closed
Conversation
These were all build-pass before and don't seem to need it. Helps with rust-lang#62277
Tweak `'static` suggestion code Fix rust-lang#71196.
Remove unused rustc_serialize::hex module * Remove unused `rustc_serialize::hex` module * Cleanup `Cargo.toml`
…laumeGomez Moving all rustdoc-ui tests to check-pass These were all build-pass before and don't seem to need it. Helps with rust-lang#62277 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/rust-lang/rust/71337) <!-- Reviewable:end -->
Use assoc int consts3 Define module level int consts with associated constants instead of `min_value()` and `max_value()`. So the code become consistent with what the docs recommend etc. Seems natural. Also remove the last usages of the int module constants from this repo (except src/test/ directory which I have still not really done anything in). Some places were missed in the previous PRs because the code uses `crate::<IntTy>` to reach the constants. This is a continuation of rust-lang#70857 r? @dtolnay
Author
|
@bors r+ rollup=never p=4 |
Collaborator
|
📌 Commit 7f3250a has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 7f3250a with merge 7584a204e75a084b3d8f0ad0298c7e220bf50860... |
Author
|
@bors retry (Yielding to beta) |
Collaborator
|
⌛ Testing commit 7f3250a with merge 8ea7216b116e0701ca6f5c8ce932d4e064f8552a... |
Author
|
@bors retry |
Collaborator
|
⌛ Testing commit 7f3250a with merge 43bd143921b6f43782d3d0383b495e430e9c422f... |
Author
|
@bors retry yield |
Collaborator
|
⌛ Testing commit 7f3250a with merge 54a9013e30e719a47a3dfeb8c01b267d5c5afe1d... |
Collaborator
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
'staticsuggestion code #71235 (Tweak'staticsuggestion code)Failed merges:
r? @ghost