Const floating point bitcasts and classification by ecstatic-morse · Pull Request #72449 · rust-lang/rust

ecstatic-morse · 2020-05-22T02:06:15Z

Makes the f32 and f64 methods described in #72447 and #72505 unstably const.

src/test/ui/consts/const-float-bits-conv.rs

RalfJung · 2020-05-22T07:27:44Z

LGTM, but I'd also like to know what @oli-obk thinks.

RalfJung · 2020-05-22T20:05:55Z

Would it make sense to also add abs_private and is_finite to the batch of functions that are being constified here? It's just a trivial wrapper around to_bits/from_bits.

Asking for #72440.

ecstatic-morse · 2020-05-23T16:50:56Z

Would it make sense to also add abs_private and is_finite to the batch of functions that are being constified here?

Sure.

oli-obk · 2020-05-26T16:39:17Z

lgtm. Stabilizing these will be blocked on stabilizing floating point types in const fn.

ecstatic-morse · 2020-06-11T21:04:22Z

Going through old PRs today. Is there still desire for this? I'll close if not.

RalfJung · 2020-06-12T07:10:10Z

Sorry, I had no idea this was waiting for my review. @Elinvynia a ping would have helped. :)

Elinvynia · 2020-06-12T07:11:33Z

Unfortunately, we aren't allowed to ping team members.

RalfJung · 2020-06-12T07:18:45Z

@bors r=RalfJung,oli-obk

bors · 2020-06-12T07:18:47Z

📌 Commit 9dadeb3 has been approved by RalfJung,oli-obk

@RalfJung

… r=RalfJung,oli-obk Const floating point bitcasts and classification Makes the `f32` and `f64` methods described in rust-lang#72447 and rust-lang#72505 unstably const. r? @RalfJung

src/test/ui/consts/const-float-bits-conv.rs

src/test/ui/consts/const-float-classify.rs

RalfJung · 2020-08-07T11:15:40Z

@ecstatic-morse sorry for the long silence. Could you rebase and address my latest review? Then I think this can land.

ecstatic-morse · 2020-08-22T21:32:00Z

This is ready to go now. I don't see a path to stabilization for these until we resolve the questions around determinism that are blocking floating point operations inside const fn, but I don't see a reason that nightly users shouldn't be allowed to experiment with them.

src/test/ui/consts/const-float-bits-conv.rs

src/test/ui/consts/const-float-classify.rs

RalfJung · 2020-08-23T14:17:17Z

r=me with the test attributes fixed.

Co-authored-by: Ralf Jung <post@ralfj.de>

RalfJung · 2020-08-23T18:28:26Z

@bors r+

bors · 2020-08-23T18:28:27Z

📌 Commit 130766c has been approved by RalfJung

bors · 2020-08-23T19:15:00Z

⌛ Testing commit 130766c with merge 0ec9459...

bors · 2020-08-23T21:18:00Z

☀️ Test successful - checks-actions, checks-azure
Approved by: RalfJung
Pushing 0ec9459 to master...

Make the following methods of `Duration` unstable const under `duration_const_2`: - `from_secs_f64` - `from_secs_f32` - `mul_f64` - `mul_f32` - `div_f64` - `div_f32` This results in all methods of `Duration` being (unstable) const. Also adds tests for these methods in a const context, moved the test to `library` as part of rust-lang#76268. Possible because of rust-lang#72449, which made the relevant `f32` and `f64` methods const. Tracking issue: rust-lang#72440

@ecstatic-morse

…orse Make all methods of `Duration` unstably const Make the following methods of `Duration` unstable const under `duration_const_2`: - `from_secs_f64` - `from_secs_f32` - `mul_f64` - `mul_f32` - `div_f64` - `div_f32` This results in all methods of `Duration` being (unstable) const. Moved the tests to `library` as part of rust-lang#76268. Possible because of rust-lang#72449, which made the relevant `f32` and `f64` methods const. Tracking issue: rust-lang#72440 r? @ecstatic-morse

@ecstatic-morse

…orse Make all methods of `Duration` unstably const Make the following methods of `Duration` unstable const under `duration_const_2`: - `from_secs_f64` - `from_secs_f32` - `mul_f64` - `mul_f32` - `div_f64` - `div_f32` This results in all methods of `Duration` being (unstable) const. Moved the tests to `library` as part of rust-lang#76268. Possible because of rust-lang#72449, which made the relevant `f32` and `f64` methods const. Tracking issue: rust-lang#72440 r? @ecstatic-morse

@ecstatic-morse

…orse Make all methods of `Duration` unstably const Make the following methods of `Duration` unstable const under `duration_const_2`: - `from_secs_f64` - `from_secs_f32` - `mul_f64` - `mul_f32` - `div_f64` - `div_f32` This results in all methods of `Duration` being (unstable) const. Moved the tests to `library` as part of rust-lang#76268. Possible because of rust-lang#72449, which made the relevant `f32` and `f64` methods const. Tracking issue: rust-lang#72440 r? @ecstatic-morse

@ecstatic-morse

…orse Make all methods of `Duration` unstably const Make the following methods of `Duration` unstable const under `duration_const_2`: - `from_secs_f64` - `from_secs_f32` - `mul_f64` - `mul_f32` - `div_f64` - `div_f32` This results in all methods of `Duration` being (unstable) const. Moved the tests to `library` as part of rust-lang#76268. Possible because of rust-lang#72449, which made the relevant `f32` and `f64` methods const. Tracking issue: rust-lang#72440 r? @ecstatic-morse

@ecstatic-morse

…orse Make all methods of `Duration` unstably const Make the following methods of `Duration` unstable const under `duration_const_2`: - `from_secs_f64` - `from_secs_f32` - `mul_f64` - `mul_f32` - `div_f64` - `div_f32` This results in all methods of `Duration` being (unstable) const. Moved the tests to `library` as part of rust-lang#76268. Possible because of rust-lang#72449, which made the relevant `f32` and `f64` methods const. Tracking issue: rust-lang#72440 r? @ecstatic-morse

rust-highfive assigned RalfJung May 22, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 22, 2020

ecstatic-morse force-pushed the const-float-bitcast branch from 711e244 to c3bb670 Compare May 22, 2020 02:27

RalfJung reviewed May 22, 2020

View reviewed changes

src/test/ui/consts/const-float-bits-conv.rs Outdated Show resolved Hide resolved

RalfJung reviewed May 22, 2020

View reviewed changes

src/test/ui/consts/const-float-bits-conv.rs Outdated Show resolved Hide resolved

RalfJung mentioned this pull request May 22, 2020

Tracking Issue for constify-ing non-trait Duration methods #72440

Closed

5 tasks

marmeladema mentioned this pull request May 22, 2020

Constify most non-trait Duration methods as described in #72440 #72481

Merged

ecstatic-morse force-pushed the const-float-bitcast branch from c3bb670 to 5f9c391 Compare May 23, 2020 17:38

ecstatic-morse changed the title ~~Const floating point bitcasts~~ Const floating point bitcasts and classification May 23, 2020

ecstatic-morse force-pushed the const-float-bitcast branch from 5f9c391 to 8de4f06 Compare May 23, 2020 18:23

This comment has been minimized.

Sign in to view

ecstatic-morse force-pushed the const-float-bitcast branch from 8de4f06 to 9dadeb3 Compare May 23, 2020 19:30

Elinvynia added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2020

RalfJung mentioned this pull request Jun 12, 2020

Rollup of 5 pull requests #73271

Closed

RalfJung reviewed Aug 7, 2020

View reviewed changes

src/test/ui/consts/const-float-bits-conv.rs Outdated Show resolved Hide resolved

RalfJung reviewed Aug 7, 2020

View reviewed changes

src/test/ui/consts/const-float-classify.rs Outdated Show resolved Hide resolved

ecstatic-morse added 2 commits August 22, 2020 12:28

Add #![feature(const_float_bits_conv)] for f64::to_bits and friends

3cd450e

Add #![feature(const_float_classify)] for f64::classify and friends

23e08e2

ecstatic-morse force-pushed the const-float-bitcast branch from 426ece4 to d9a5637 Compare August 22, 2020 19:51

Test new floating point bit casts

b65daa7

ecstatic-morse force-pushed the const-float-bitcast branch from d9a5637 to b65daa7 Compare August 22, 2020 20:35

RalfJung reviewed Aug 23, 2020

View reviewed changes

src/test/ui/consts/const-float-bits-conv.rs Outdated Show resolved Hide resolved

RalfJung reviewed Aug 23, 2020

View reviewed changes

src/test/ui/consts/const-float-classify.rs Outdated Show resolved Hide resolved

Fix compile-flags directive

130766c

Co-authored-by: Ralf Jung <post@ralfj.de>

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 23, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 23, 2020

bors merged commit 0ec9459 into rust-lang:master Aug 23, 2020

CDirkx mentioned this pull request Sep 4, 2020

Make all methods of Duration unstably const #76335

Merged

ecstatic-morse deleted the const-float-bitcast branch October 6, 2020 01:42

Uh oh!

Conversation

ecstatic-morse commented May 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RalfJung commented May 22, 2020

Uh oh!

RalfJung commented May 22, 2020

Uh oh!

ecstatic-morse commented May 23, 2020

Uh oh!

This comment has been minimized.

oli-obk commented May 26, 2020

Uh oh!

ecstatic-morse commented Jun 11, 2020

Uh oh!

RalfJung commented Jun 12, 2020

Uh oh!

Elinvynia commented Jun 12, 2020

Uh oh!

RalfJung commented Jun 12, 2020

Uh oh!

bors commented Jun 12, 2020

Uh oh!

Uh oh!

Uh oh!

RalfJung commented Aug 7, 2020

Uh oh!

ecstatic-morse commented Aug 22, 2020

Uh oh!

Uh oh!

Uh oh!

RalfJung commented Aug 23, 2020

Uh oh!

RalfJung commented Aug 23, 2020

Uh oh!

bors commented Aug 23, 2020

Uh oh!

bors commented Aug 23, 2020

Uh oh!

bors commented Aug 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ecstatic-morse commented May 22, 2020 •

edited

Loading