Constify most non-trait Duration methods as described in #72440#72481
Merged
bors merged 1 commit intorust-lang:masterfrom Jul 16, 2020
Merged
Constify most non-trait Duration methods as described in #72440#72481bors merged 1 commit intorust-lang:masterfrom
Duration methods as described in #72440#72481bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
RalfJung
reviewed
May 23, 2020
Member
|
Cc @rust-lang/wg-const-eval |
Contributor
|
Marking as const-hack so we remember to go back to the original code once the relevant functions become const fn |
Contributor
|
r=me with Ralf's comment resolved to either |
Contributor
Author
marmeladema
force-pushed
the
duration-consts-2
branch
from
b3cfde2 to
7527409
Compare
Member
|
Expanding the methods covered by the gate in a follow-up PR is fine. |
RalfJung
reviewed
May 30, 2020
5 tasks
Elinvynia
added
S-waiting-on-review
Elinvynia
added
S-waiting-on-review
Member
|
r? @oli-obk - re-asigning reviewer following the conversations. |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 7527409 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jul 14, 2020
…i-obk Constify most non-trait `Duration` methods as described in rust-lang#72440 The remaining methods could probably be made const once rust-lang#72449 lands with support for `f<32|64>::is_finite()`.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 14, 2020
…i-obk Constify most non-trait `Duration` methods as described in rust-lang#72440 The remaining methods could probably be made const once rust-lang#72449 lands with support for `f<32|64>::is_finite()`.
Member
bors
added
S-waiting-on-author
marmeladema
force-pushed
the
duration-consts-2
branch
from
7527409 to
4a96800
Compare
Contributor
Author
|
r? @oli-obk |
lcnr
added
S-waiting-on-review
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 4a96800 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remaining methods could probably be made const once #72449 lands with support for
f<32|64>::is_finite().