Skip to content

Update to LLVM 12.0.0 final#84230

Merged
bors merged 1 commit intorust-lang:masterfrom
cuviper:llvm-12
Apr 16, 2021
Merged

Update to LLVM 12.0.0 final#84230
bors merged 1 commit intorust-lang:masterfrom
cuviper:llvm-12

Conversation

@cuviper
Copy link
Member

@cuviper cuviper commented Apr 15, 2021

No description provided.

@rust-highfive
Copy link
Contributor

rust-highfive commented Apr 15, 2021

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

rust-highfive commented Apr 15, 2021

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2021
@cuviper
Copy link
Member Author

cuviper commented Apr 15, 2021

@nagisa mentioned wanting a few more backports, so we could wait and roll that together here. Let's try in the meantime...

r? @nikic
@bors try

@bors
Copy link
Collaborator

bors commented Apr 15, 2021

⌛ Trying commit 3a96140 with merge f49484f1a882c6384f1f0a464c45617920af84d2...

@bors
Copy link
Collaborator

bors commented Apr 15, 2021

☀️ Try build successful - checks-actions
Build commit: f49484f1a882c6384f1f0a464c45617920af84d2 (f49484f1a882c6384f1f0a464c45617920af84d2)

@nikic
Copy link
Contributor

nikic commented Apr 16, 2021

@bors r+ rollup=never (just in case, as this pulls in a few more commits than usual)

The only other backport we need that I'm aware of is https://reviews.llvm.org/D99469, and that one hasn't landed upstream yet.

@bors
Copy link
Collaborator

bors commented Apr 16, 2021

📌 Commit 3a96140 has been approved by nikic

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2021
@bors
Copy link
Collaborator

bors commented Apr 16, 2021

⌛ Testing commit 3a96140 with merge 3833636...

@bors
Copy link
Collaborator

bors commented Apr 16, 2021

☀️ Test successful - checks-actions
Approved by: nikic
Pushing 3833636 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 16, 2021
@bors bors merged commit 3833636 into rust-lang:master Apr 16, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 16, 2021
@nikic nikic mentioned this pull request Apr 16, 2021
Closed
@nikic nikic added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 16, 2021
@nagisa
Copy link
Member

nagisa commented Apr 16, 2021

https://reviews.llvm.org/rG1c268a8ff4e90a85d0e634350b1104080614cf2b was one of the backport candidates I had in mind. Looks like it didn't make v12.0.0 so will have to backport it to both nightly and beta.

@cuviper cuviper mentioned this pull request Apr 17, 2021
Merged
@wesleywiser
Copy link
Member

wesleywiser commented Apr 22, 2021

We discussed this in the compiler team triage meeting this morning and decided to approve the backport. I see a beta PR (#84271) has already been opened so I will leave the approval tag on that PR.

@wesleywiser wesleywiser removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 22, 2021
This was referenced May 21, 2021
Closed
Closed
@cuviper cuviper deleted the llvm-12 branch September 21, 2021 16:43
stlankes added a commit to RWTH-OS/eduOS-rs that referenced this pull request Dec 8, 2021
@stlankes
Take ExceptionStackFrame by value
6fa0be8 
Since LLVM 12 (rust-lang/rust#84230) ExceptionStackFrame has to be taken by value. See rust-lang/rust#40180 (comment).
stlankes added a commit to RWTH-OS/eduOS-rs that referenced this pull request Dec 8, 2021
@stlankes
Take ExceptionStackFrame by value
2595648 
Since LLVM 12 (rust-lang/rust#84230) ExceptionStackFrame has to be taken by value. See rust-lang/rust#40180 (comment).
stlankes added a commit to RWTH-OS/eduOS-rs that referenced this pull request Dec 8, 2021
@stlankes
Take ExceptionStackFrame by value
93e92c3 
Since LLVM 12 (rust-lang/rust#84230) ExceptionStackFrame has to be taken by value. See rust-lang/rust#40180 (comment).
stlankes added a commit to RWTH-OS/eduOS-rs that referenced this pull request Dec 8, 2021
@stlankes
Take ExceptionStackFrame by value
39f136b 
Since LLVM 12 (rust-lang/rust#84230) ExceptionStackFrame has to be taken by value. See rust-lang/rust#40180 (comment).
stlankes added a commit to RWTH-OS/eduOS-rs that referenced this pull request Dec 8, 2021
@stlankes
Take ExceptionStackFrame by value
4918d6e 
Since LLVM 12 (rust-lang/rust#84230) ExceptionStackFrame has to be taken by value. See rust-lang/rust#40180 (comment).
@workingjubilee workingjubilee added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikic nikic

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.53.0

Development

Successfully merging this pull request may close these issues.

9 participants

@cuviper @rust-highfive @bors @nikic @nagisa @wesleywiser @Mark-Simulacrum @workingjubilee @rustbot