[beta] Bump LLVM to a upstream 12.0 release#84271
Conversation
|
r? @cuviper (rust-highfive has picked a reviewer for you, use r? to override) |
|
|
#84230 is already beta-nominated -- shouldn't we wait for that process? You also pulled in the stack-probe dwarf change here, not sure if that was intentional. |
|
Yes, it was intentional to pull in that change, though, now that I think about it, the DWARF problem is in stable already so we don't really need to backport it like we should with the others. |
|
Ah, I was wrong. while it would've reached stable, it did not because of #83412 and so it is valuable to consider this for backport, including separately from the other LLVM 12.0 backport. |
|
We discussed this in the compiler team triage meeting and decided to approve the backport. |
|
@bors r+ |
|
📌 Commit 46a2c6a has been approved by |
|
☀️ Test successful - checks-actions |
Currently the
betabranch utilizes a release candidate of LLVM 12.0. Since then a large number of issues have been fixed upstream, including those that are known to affect Rust code.It would be unfortunate if we released a stable Rust with all of those issues when we have the fixes in the actual LLVM release and/or our backports of commits that didn't make the release cut on top of it.
cc @cuviper / @nikic